From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Benjamin Riefenstahl Newsgroups: gmane.emacs.bugs Subject: bug#28505: 26.0.60; Crash in Fmove_point_visually Date: Tue, 19 Sep 2017 18:13:05 +0200 Message-ID: <87ingefyzy.fsf@blei.turtle-trading.net> References: <877ewvixax.fsf@blei.turtle-trading.net> <87d16n7maz.fsf@blei.turtle-trading.net> <83shfjgwf8.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1505837661 11543 195.159.176.226 (19 Sep 2017 16:14:21 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 19 Sep 2017 16:14:21 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.60 (gnu/linux) Cc: 28505@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Sep 19 18:14:14 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1duLA5-0002Vo-84 for geb-bug-gnu-emacs@m.gmane.org; Tue, 19 Sep 2017 18:14:13 +0200 Original-Received: from localhost ([::1]:43996 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1duLAC-0006IN-G3 for geb-bug-gnu-emacs@m.gmane.org; Tue, 19 Sep 2017 12:14:20 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:48106) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1duLA0-0006F7-7N for bug-gnu-emacs@gnu.org; Tue, 19 Sep 2017 12:14:09 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1duL9v-0006yv-QN for bug-gnu-emacs@gnu.org; Tue, 19 Sep 2017 12:14:08 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:39775) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1duL9v-0006yq-NX for bug-gnu-emacs@gnu.org; Tue, 19 Sep 2017 12:14:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1duL9v-0006Ei-Fo for bug-gnu-emacs@gnu.org; Tue, 19 Sep 2017 12:14:03 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Benjamin Riefenstahl Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 19 Sep 2017 16:14:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 28505 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 28505-submit@debbugs.gnu.org id=B28505.150583759623891 (code B ref 28505); Tue, 19 Sep 2017 16:14:03 +0000 Original-Received: (at 28505) by debbugs.gnu.org; 19 Sep 2017 16:13:16 +0000 Original-Received: from localhost ([127.0.0.1]:48452 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1duL99-0006DH-Mm for submit@debbugs.gnu.org; Tue, 19 Sep 2017 12:13:15 -0400 Original-Received: from odoacer.turtle-trading.net ([217.91.34.180]:50544) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1duL97-0006D4-A9 for 28505@debbugs.gnu.org; Tue, 19 Sep 2017 12:13:13 -0400 Original-Received: from justinian.turtle-trading.net ([192.168.2.118]) by odoacer.turtle-trading.net with esmtp (Exim 4.80) (envelope-from ) id 1duL8z-00047T-GA; Tue, 19 Sep 2017 18:13:05 +0200 Original-Received: from benny by justinian.turtle-trading.net with local (Exim 4.84_2) (envelope-from ) id 1duL8z-0007f2-CQ; Tue, 19 Sep 2017 18:13:05 +0200 In-Reply-To: <83shfjgwf8.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 19 Sep 2017 07:11:07 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:137132 Archived-At: >> From: Benjamin Riefenstahl >> Date: Mon, 18 Sep 2017 23:02:12 +0200 >> >> So I recompiled with -O0 and after reading the code I added a few more >> "p"s in GDB. I see that "w->current_matrix" has "rows_allocated = 1, >> nrows = 1", but still "row" was initialized from "rows" and than >> incremented by "dir" (1). Is that as it should be? Eli Zaretskii writes: > Yes, but the incremented value is then checked for validity with this > snippet: > > if (row < MATRIX_FIRST_TEXT_ROW (w->current_matrix) > || row > MATRIX_BOTTOM_TEXT_ROW (w->current_matrix, w)) > goto simulate_display; MATRIX_BOTTON_TEXT_ROW calculates "rows + nrows" (plus the mode-line, but this is the minibuffer, so it does not have a mode-line). So despite the name of the macro the result points *after* the bottom row, not *at* it. Should that comparison be "row >= BOTTOM"? I'll try that. The macro seems to be misnamed though if that is the problem. benny