From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Michael Albinus Newsgroups: gmane.emacs.bugs Subject: bug#30595: [PATCH] Handle command line wrapping in Tramp adb. Date: Mon, 26 Feb 2018 16:59:58 +0100 Message-ID: <87inaj91xd.fsf@gmx.de> References: <20180224180709.29641-1-m.othacehe@gmail.com> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1519660762 31009 195.159.176.226 (26 Feb 2018 15:59:22 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 26 Feb 2018 15:59:22 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: 30595@debbugs.gnu.org To: Mathieu Othacehe Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Feb 26 16:59:18 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eqLBN-0007fM-SH for geb-bug-gnu-emacs@m.gmane.org; Mon, 26 Feb 2018 16:59:17 +0100 Original-Received: from localhost ([::1]:59891 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eqLDQ-0001G5-Cq for geb-bug-gnu-emacs@m.gmane.org; Mon, 26 Feb 2018 11:01:24 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:51686) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eqLD9-0001F4-NS for bug-gnu-emacs@gnu.org; Mon, 26 Feb 2018 11:01:17 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eqLD5-0008Hh-8p for bug-gnu-emacs@gnu.org; Mon, 26 Feb 2018 11:01:07 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:54015) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eqLD5-0008HP-4K for bug-gnu-emacs@gnu.org; Mon, 26 Feb 2018 11:01:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1eqLD3-0004CG-Hx for bug-gnu-emacs@gnu.org; Mon, 26 Feb 2018 11:01:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Michael Albinus Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 26 Feb 2018 16:01:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 30595 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 30595-submit@debbugs.gnu.org id=B30595.151966080816065 (code B ref 30595); Mon, 26 Feb 2018 16:01:01 +0000 Original-Received: (at 30595) by debbugs.gnu.org; 26 Feb 2018 16:00:08 +0000 Original-Received: from localhost ([127.0.0.1]:33679 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eqLCC-0004B2-Il for submit@debbugs.gnu.org; Mon, 26 Feb 2018 11:00:08 -0500 Original-Received: from mout.gmx.net ([212.227.15.15]:56783) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eqLCA-00049D-EN for 30595@debbugs.gnu.org; Mon, 26 Feb 2018 11:00:07 -0500 Original-Received: from detlef.gmx.de ([79.140.124.243]) by mail.gmx.com (mrgmx002 [212.227.17.190]) with ESMTPSA (Nemesis) id 0MfVU3-1f6dme3cSJ-00P3HN; Mon, 26 Feb 2018 16:59:59 +0100 In-Reply-To: <20180224180709.29641-1-m.othacehe@gmail.com> (Mathieu Othacehe's message of "Sat, 24 Feb 2018 19:07:09 +0100") X-Provags-ID: V03:K0:ZzRvdDQe7YYL+RCqOKIb+xRKf+ogBs9wL+2C68ees3G7feSIvkx 0XnTLrq6ZdUfM8yHbtEz0UPkPRfDAN+3f2cHBfuwJuIo1+CWafkXU0JxpHoN4+9LrX7VB9v KPjBSfnBsP8HW2cr+Dir1gHui5LvV+w2FSzNmoNgBL2bZldTeytMXe8se2fvAJjrgH4EQzH nl7ZpkZiqfZoU1/gEO6+w== X-UI-Out-Filterresults: notjunk:1;V01:K0:beMqhaTmF1Q=:leUlZnraeckoErz0/rkVcL QoLwmKmFH3q7uSx3f1aeuGGsEh3C7HSzWntplErRWM0Stsp0QR2AdAtSaC8la43TIQhvA/yCz T/QKoXNiaNaVMIPoALiryV7OcxiGZPxhDIIH9a6WkQF0UXqFOh2EqW5980XDfDSJSb/xbN5Mv wpVYy4Qdfupc1+5ylzajXttEzSEma1o1SlKVcyCp7P9P7yniq4xuvJf7WoYIKwBBm1swbE8ey cg6NHC60oYteZxVLq7se2tb21pv/m15QK1YoKXKaoL/+zIHnLbvR2teYc0mQzHGnDhwUQdzYm Zoc4GuH/TvxPESInpPFw/VhFTDX/S9Zawk9duhqRQHXCBit26tKTTm0xcuBBslhGBEZ4NALy+ VEbRqQygLqpUNpw1ptkIwRAYvHb5fond+GxienyO8M2RmmNSl+NWRh+KjA/YIWypy9rPWaI0d YYj0SEfFKcgeRWWCHnaEcG/5HDBYJbEGHJo9+ojQhUFnPlU55RDJSC55YTi43qaMvqy3h9uoR 93MqfOdVk1yQBAPzIWPMSX8xQx3xRMqStoD69hr3xVWG9ohWmSRyZcimsybjMMWCnmkGse2tB HrswKa58mn8aYhjzCPhHdlekuLxhA+I/oBuUSpis/U8wH6uen9Z/5u4K5hFLDyBftclzTU0SZ 2S3JDIgH5cm8E+VNzyoTZf60Mtnk+yQGKc8gOjvA4RXyPoryYt8PMQrjlVXSj+2sr1VJ4cmdp inUs0dBxO8z/IwXwcxih3kldKSzHuwq/3d/Zobb3e8GjwBt8/XDPZ9LcyYY6EcXcVeXYoWnO X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:143671 Archived-At: Mathieu Othacehe writes: Hi Mathieu, > The command sent to an adb shell input might be wrapped around > terminal column count by the kernel. Remove CR and LF introduced when > it happends. Your patch doesn't pass Tramp's test suite, using my plain Galaxy S6. It fails in tramp-test09-insert-file-contents. Could you, pls, check? In order to run the test suite in Tramp's git repository, apply $ env REMOTE_TEMPORARY_FILE_DIRECTORY=/adb::/sdcard/tmp make check If you use Emacs' git repository instead, apply $ env REMOTE_TEMPORARY_FILE_DIRECTORY=/adb::/sdcard/tmp \ make check -C test tramp-tests (You might use another temporary directory on your device.) Pls sync first with the git repository; I've pushed a patch earlier today fixing another nasty (unrelated) bug which let Tramp fail in test. Btw, your other patch wrt bug#30594 runs OK with the tests. Best regards, Michael.