From: Noam Postavsky <npostavs@gmail.com>
To: Stefan Monnier <monnier@IRO.UMontreal.CA>
Cc: 30846@debbugs.gnu.org
Subject: bug#30846: 26.0.91; debug-watch of kill-all-local-variables triggers 'assertion failed: found == !EQ (blv->defcell, blv->valcell)'
Date: Thu, 22 Mar 2018 20:20:13 -0400 [thread overview]
Message-ID: <87in9nskw2.fsf@gmail.com> (raw)
In-Reply-To: <jwv4ll8uqe7.fsf-monnier+bug#30846@gnu.org> (Stefan Monnier's message of "Thu, 22 Mar 2018 11:45:32 -0400")
Stefan Monnier <monnier@IRO.UMontreal.CA> writes:
> If you feel this is too risky for emacs-26, I wouldn't blame you (this
> is pretty tricky code): while the assertion crashes Emacs, a normal
> build without assertions will likely not notice the problem at all.
> I came up with a test case that catches the problem, but I think that in
> "real" life it's very unlikely to cause a problem.
Should we disable the assertion in emacs-26 then?
And would the diff below updating comments on struct
Lisp_Buffer_Local_Value be correct?
--- i/src/lisp.h
+++ w/src/lisp.h
@@ -2593,10 +2593,10 @@ XUSER_PTR (Lisp_Object a)
variable, you must first make sure the right binding is loaded;
then you can access the value in (or through) `realvalue'.
- `buffer' and `frame' are the buffer and frame for which the loaded
- binding was found. If those have changed, to make sure the right
+ `where' is the buffer for which the loaded
+ binding was found. If it has changed, to make sure the right
binding is loaded it is necessary to find which binding goes with
- the current buffer and selected frame, then load it. To load it,
+ the current buffer, then load it. To load it,
first unload the previous binding, then copy the value of the new
binding into `realvalue' (or through it). Also update
LOADED-BINDING to point to the newly loaded binding.
@@ -2615,14 +2615,14 @@ XUSER_PTR (Lisp_Object a)
bool_bf found : 1;
/* If non-NULL, a forwarding to the C var where it should also be set. */
union Lisp_Fwd *fwd; /* Should never be (Buffer|Kboard)_Objfwd. */
- /* The buffer or frame for which the loaded binding was found. */
+ /* The buffer for which the loaded binding was found. */
Lisp_Object where;
/* A cons cell that holds the default value. It has the form
(SYMBOL . DEFAULT-VALUE). */
Lisp_Object defcell;
/* The cons cell from `where's parameter alist.
It always has the form (SYMBOL . VALUE)
- Note that if `forward' is non-nil, VALUE may be out of date.
+ Note that if `fwd' is non-NULL, VALUE may be out of date.
Also if the currently loaded binding is the default binding, then
this is `eq'ual to defcell. */
Lisp_Object valcell;
next prev parent reply other threads:[~2018-03-23 0:20 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-18 13:10 bug#30846: 26.0.91; debug-watch of kill-all-local-variables triggers 'assertion failed: found == !EQ (blv->defcell, blv->valcell)' Noam Postavsky
2018-03-18 14:05 ` Eli Zaretskii
2018-03-18 14:07 ` Eli Zaretskii
2018-03-18 14:20 ` Noam Postavsky
2018-03-18 14:38 ` Eli Zaretskii
2018-03-21 0:48 ` Noam Postavsky
2018-03-21 13:04 ` Stefan Monnier
2018-03-22 15:45 ` Stefan Monnier
2018-03-22 15:53 ` Eli Zaretskii
2018-03-23 0:20 ` Noam Postavsky [this message]
2018-03-23 1:22 ` Stefan Monnier
2018-03-23 12:25 ` Noam Postavsky
2018-03-23 8:12 ` Eli Zaretskii
2018-03-23 12:57 ` Stefan Monnier
2018-03-23 14:23 ` Eli Zaretskii
2018-03-23 14:42 ` Stefan Monnier
2018-03-23 15:29 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87in9nskw2.fsf@gmail.com \
--to=npostavs@gmail.com \
--cc=30846@debbugs.gnu.org \
--cc=monnier@IRO.UMontreal.CA \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.