From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: John Shahid Newsgroups: gmane.emacs.bugs Subject: bug#31793: 26.1; (error "Lisp nesting exceeds =?UTF-8?Q?=E2=80=98max-lisp-eval-depth=E2=80=99?=") Date: Tue, 03 Jul 2018 16:43:38 +0000 Message-ID: <87in5wxoat.fsf@gmail.com> References: <99D8E495-B396-4266-8BF1-BA0B609DEC3D@gnu.org> <87k1qpsdxc.fsf@gmail.com> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Trace: blaine.gmane.org 1530637132 23194 195.159.176.226 (3 Jul 2018 16:58:52 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 3 Jul 2018 16:58:52 +0000 (UTC) User-Agent: mu4e 1.1.0; emacs 27.0.50 Cc: 31793@debbugs.gnu.org To: Leo Liu Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Jul 03 18:58:48 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1faOda-0005uX-MB for geb-bug-gnu-emacs@m.gmane.org; Tue, 03 Jul 2018 18:58:46 +0200 Original-Received: from localhost ([::1]:41790 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1faOfh-00064u-Vz for geb-bug-gnu-emacs@m.gmane.org; Tue, 03 Jul 2018 13:00:58 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:51855) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1faOPO-00071X-8p for bug-gnu-emacs@gnu.org; Tue, 03 Jul 2018 12:44:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1faOPL-0004jA-1G for bug-gnu-emacs@gnu.org; Tue, 03 Jul 2018 12:44:06 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:37751) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1faOPK-0004ik-Rt for bug-gnu-emacs@gnu.org; Tue, 03 Jul 2018 12:44:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1faOPK-0003ep-Cg for bug-gnu-emacs@gnu.org; Tue, 03 Jul 2018 12:44:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: John Shahid Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 03 Jul 2018 16:44:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 31793 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 31793-submit@debbugs.gnu.org id=B31793.153063623014034 (code B ref 31793); Tue, 03 Jul 2018 16:44:02 +0000 Original-Received: (at 31793) by debbugs.gnu.org; 3 Jul 2018 16:43:50 +0000 Original-Received: from localhost ([127.0.0.1]:45648 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1faOP7-0003eI-Nw for submit@debbugs.gnu.org; Tue, 03 Jul 2018 12:43:49 -0400 Original-Received: from mail-qt0-f177.google.com ([209.85.216.177]:42559) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1faOP5-0003e5-Pd for 31793@debbugs.gnu.org; Tue, 03 Jul 2018 12:43:48 -0400 Original-Received: by mail-qt0-f177.google.com with SMTP id y31-v6so2132133qty.9 for <31793@debbugs.gnu.org>; Tue, 03 Jul 2018 09:43:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=references:user-agent:from:to:cc:subject:in-reply-to:date :message-id:mime-version; bh=LiNhAFAsp6s78x1WRVrkbtCWJCMvjsvaosR1atHhczo=; b=Z43aNLvjT25Ll1HU/AUzkVQSRa7/93KOCu6uT0QjM0bXRzBKV7fhMiJn7S/OnAkISy LQ8c7Cer7hU8P50tTmJd9S2WpEW4VcL7YROWuxmX/pUTBFcGakswrNjjiImdUZJN+K56 4XVYLfRPFo9j9TfqgWkeb4CrX1XM4WxrhXMAkoc03aJC9iyTp/HwTgc3wcMQN8xPn5Jk iW376mCCQkvLbIm8dU6vysbqcWfgx6VbTz+x3TfCDEm3wjbG2lBegXc3lzJRYDzcBhNJ 7RJKMLCv1JVzUiUIU8rWFtMEojHrdNQ+ienU9tnzDbtihhJsEXQ2dY/3MfM5pipIGxzH k1fA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:references:user-agent:from:to:cc:subject :in-reply-to:date:message-id:mime-version; bh=LiNhAFAsp6s78x1WRVrkbtCWJCMvjsvaosR1atHhczo=; b=BhjPwHcRhzpdcgJ1Ej95cz9glzFLNMdy0dwlVuvwo0lcZz0tbpQUOIKad/VKzEcJer p841UtQIIbVaB4NrvBenFWsVgOrVUmW5HzDUyJA8Af1VeOATjyJFG6NdiGuS1u87O7zD 53hmXR/6aIJFSY+65eOUN2lYWh3Ml1gnty2PE+Xs1N311yt311gtr9/xOdfa2iF2zRNx BT8pY2QtP5eu+2FbEtXlUl2LfZ7R2C60WjHGhrORlQLvo6dwINQ1kl+eXWa9KwNk87Lx DB/XhpkWY+i6XT582O3ROYC+K+8htV1xHpgYJv4SFEukuGcUOvuPeZ83ZPMKqWZe78mN 6uAQ== X-Gm-Message-State: APt69E2/Gki63UcZN19KP3hNI0zJYnoWQ10bhyMqjUqlXeGHTr4nX/Gq wnApIYceJt1axVlryPlQifeDf6lc X-Google-Smtp-Source: AAOMgpc7GsiJBaABhrttfDoNwe5pXUFXNhl2uIIXlCBz5exM6zPqTaomAozg6JJBoExTzq6uyI162A== X-Received: by 2002:ac8:2485:: with SMTP id s5-v6mr27728926qts.350.1530636221841; Tue, 03 Jul 2018 09:43:41 -0700 (PDT) Original-Received: from 9a50e8462956 ([142.154.219.2]) by smtp.gmail.com with ESMTPSA id t17-v6sm1191596qth.10.2018.07.03.09.43.40 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 03 Jul 2018 09:43:40 -0700 (PDT) In-reply-to: <87k1qpsdxc.fsf@gmail.com> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:148157 Archived-At: --=-=-= Content-Type: text/plain John Shahid writes: > Leo Liu writes: > >> On 2018-06-12 08:21 +0300, Eli Zaretskii wrote: >>> Ugh, macOS... This means no xbacktrace and no other GDB >>> wizardry... >> >> Indeed. >> >>> Well, I think the most important thing is to produce a Lisp >>> backtrace from the error. >> >> Turns out 26.1 cannot load a version of python.el (by dave love) that I >> have in my site-lisp. >> >> 1. emacs -Q -l python.el >> 2. M-x python-mode >> >> ,----[ error ] >> | Variable binding depth exceeds max-specpdl-size >> | Error in post-command-hook (global-eldoc-mode-check-buffers): (error "Variable binding depth exceeds max-specpdl-size") >> `---- >> >> Gnus was just loading python-mode to fontify some code in an article. > > double posting since I sent the email only to Leo. > > VVVV original email VVVV > > That seems to be a result of converting `global-eldoc-mode' to use > `define-globalized-minor-mode' in 2349f. The recursive call seems to be > a result of the following sequence of calls: > > 1. python-mode is enabled which adds an eldoc-mode-hook > 2. eldoc-mode is turned on in the buffer triggering python's > eldoc-mode-hook > 3. python-mode hook will start an inferior process which in turn trigger > ,MODE-enable-in-buffers > 4. ,MODE-enable-in-buffers will go over the list again trying to enable > eldoc-mode > > The problem is in step 4. The eldoc-global-mode buffer list isn't reset > in step 2. Step 4 will try to enabe the mode for the same buffer and > start a sequence of calls at 2. I was able to fix this problem by > setting the buffer-list to nil inside ,MODE-enable-in-buffers. I > attached a patch below. Added the bug number to the changelog entry and attached a new patch. --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=0001-Avoid-turning-on-the-global-minor-mode-recursively-B.patch >From 893e62ee7e3630c981adb3efa39ef409500d7657 Mon Sep 17 00:00:00 2001 From: John Shahid Date: Sat, 23 Jun 2018 11:12:44 -0400 Subject: [PATCH] Avoid turning on the global-minor-mode recursively (Bug#31793) * lisp/emacs-lisp/easy-mmode.el (define-globalized-minor-mode): Reset the buffer-list inside ,MODE-enable-in-buffers to avoid enabling the mode recursively --- lisp/emacs-lisp/easy-mmode.el | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/lisp/emacs-lisp/easy-mmode.el b/lisp/emacs-lisp/easy-mmode.el index b83b53a8e5..648b88ca77 100644 --- a/lisp/emacs-lisp/easy-mmode.el +++ b/lisp/emacs-lisp/easy-mmode.el @@ -474,7 +474,9 @@ define-globalized-minor-mode ;; The function that calls TURN-ON in each buffer. (defun ,MODE-enable-in-buffers () - (dolist (buf ,MODE-buffers) + (let ((buffers ,MODE-buffers)) + (setq ,MODE-buffers nil) + (dolist (buf buffers) (when (buffer-live-p buf) (with-current-buffer buf (unless ,MODE-set-explicitly @@ -484,12 +486,11 @@ define-globalized-minor-mode (,mode -1) (funcall #',turn-on)) (funcall #',turn-on)))) - (setq ,MODE-major-mode major-mode))))) + (setq ,MODE-major-mode major-mode)))))) (put ',MODE-enable-in-buffers 'definition-name ',global-mode) (defun ,MODE-check-buffers () (,MODE-enable-in-buffers) - (setq ,MODE-buffers nil) (remove-hook 'post-command-hook ',MODE-check-buffers)) (put ',MODE-check-buffers 'definition-name ',global-mode) -- 2.18.0 --=-=-=--