From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Noam Postavsky Newsgroups: gmane.emacs.bugs Subject: bug#30823: 25.3; modification-hooks of overlays are not run in some cases Date: Fri, 17 Aug 2018 16:52:54 -0400 Message-ID: <87in48ww9l.fsf@gmail.com> References: <83lgetri7r.fsf@gnu.org> <87in9cpd3a.fsf@gmail.com> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1534539132 19119 195.159.176.226 (17 Aug 2018 20:52:12 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 17 Aug 2018 20:52:12 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) Cc: 30823@debbugs.gnu.org, Stefan Monnier To: Ren Victor Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Aug 17 22:52:07 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fqlj5-0004pV-FZ for geb-bug-gnu-emacs@m.gmane.org; Fri, 17 Aug 2018 22:52:07 +0200 Original-Received: from localhost ([::1]:36360 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fqllA-0004Zc-Cl for geb-bug-gnu-emacs@m.gmane.org; Fri, 17 Aug 2018 16:54:16 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:60328) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fqll1-0004ZX-VC for bug-gnu-emacs@gnu.org; Fri, 17 Aug 2018 16:54:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fqlkw-0007ge-BN for bug-gnu-emacs@gnu.org; Fri, 17 Aug 2018 16:54:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:48774) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fqlkw-0007gM-6H for bug-gnu-emacs@gnu.org; Fri, 17 Aug 2018 16:54:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1fqlkw-0002fQ-40 for bug-gnu-emacs@gnu.org; Fri, 17 Aug 2018 16:54:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Noam Postavsky Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 17 Aug 2018 20:54:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 30823 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 30823-submit@debbugs.gnu.org id=B30823.153453918310178 (code B ref 30823); Fri, 17 Aug 2018 20:54:02 +0000 Original-Received: (at 30823) by debbugs.gnu.org; 17 Aug 2018 20:53:03 +0000 Original-Received: from localhost ([127.0.0.1]:53792 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fqljz-0002e6-3w for submit@debbugs.gnu.org; Fri, 17 Aug 2018 16:53:03 -0400 Original-Received: from mail-io0-f176.google.com ([209.85.223.176]:38495) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fqljx-0002dY-Ir for 30823@debbugs.gnu.org; Fri, 17 Aug 2018 16:53:01 -0400 Original-Received: by mail-io0-f176.google.com with SMTP id y3-v6so3572723ioc.5 for <30823@debbugs.gnu.org>; Fri, 17 Aug 2018 13:53:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=Ix1Uszu56y7NKacC1rNwRASfJaiY7imjdeL+SgNvGcw=; b=bZAcPu7gvl9Xik1VoecOnMw6Ea9cpSjW+BniHsUu46e1AehVGj7RQkfFdaesboI2Hm QRS8Un9JVkyDW9dSQmr6fijLLWx0c9stSKXmpJsgVC99R5mpJtGLiUp9+/eiGWdhUme8 rxBDbz0/eHtVVP+7RYlDPojKqIDd1PDQu0l1gGDdCs41cmXaZZukiuED37pxHNkoJkov Mn4QUr62aSbaebB6OPBrCuYNHeVikdwgHI+Q6XqjPlS/K+6L4PSGD+YnDWKyM3/Jok2j 1zguo9RI3Zrxl78ZS3kG4EkYQ/Od0PHejuHaufnCEWjGV7r6tt5vr+awoIUJtb/fnciC UvrQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=Ix1Uszu56y7NKacC1rNwRASfJaiY7imjdeL+SgNvGcw=; b=Hsog+n+JQlve+wN76CJ/17/FrxpSJTToJ9qhnb/03eKz3CUo7seCat2fzhE4yRHA55 bCQFaPCMYfJC/QOYNGhwivPfK16IRqz1OYSf4i9UKQmU7A507Le1fGseU3h/cSf3XFD+ StJpDSDdP0gxT0txE3M+azkPFtQOIktA8miqpl2TM54ubxsdPK/M9YrNhCq0yaEbAxew zNJcEDDQVpoFACXOX9PlY7QA3jBIEBVAcazB6DBJNhzNVn8uOJfDNFYWSUxupmsSpAMy Xz7tWDkGQhLpWhfrnTeKdwrd93gikjVvSYAnLKY6SCpMrdEmMTEXKiNNFW6Bi4wI30um WvqA== X-Gm-Message-State: AOUpUlFEtcqTOOldRDqbCOMyj4uoCWdLBV88LqeelxwpqUK2ldCKlfQm 40d4zDvbELcD+t3h9U3e8Z8= X-Google-Smtp-Source: AA+uWPzcJMqMFuHo7jO5S99VGLoBsfd4JVSJYOKxAm6rHlP01dNeY5UCVx+X67IJhGaweGgZ8pRoiQ== X-Received: by 2002:a6b:b0c5:: with SMTP id z188-v6mr30441071ioe.220.1534539175911; Fri, 17 Aug 2018 13:52:55 -0700 (PDT) Original-Received: from zebian (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.googlemail.com with ESMTPSA id r3-v6sm1257387ioo.11.2018.08.17.13.52.55 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 17 Aug 2018 13:52:55 -0700 (PDT) In-Reply-To: <87in9cpd3a.fsf@gmail.com> (Noam Postavsky's message of "Sat, 31 Mar 2018 09:51:53 -0400") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:149562 Archived-At: Noam Postavsky writes: > @@ -10403,6 +10403,13 @@ message_dolog (const char *m, ptrdiff_t nbytes, bool nlflag, bool multibyte) > ptrdiff_t this_bol, this_bol_byte, prev_bol, prev_bol_byte; > printmax_t dups; > > + /* Since we call del_range_both passing false for PREPARE, > + we aren't prepared to run modification hooks (we could > + end up calling modification hooks from another buffer and > + only with AFTER=t, Bug#21824). */ > + ptrdiff_t count = SPECPDL_INDEX (); > + specbind (Qinhibit_modification_hooks, Qt); > + > insert_1_both ("\n", 1, 1, true, false, false); > > scan_newline (Z, Z_BYTE, BEG, BEG_BYTE, -2, false); Coming back to this, there is also the possibility of passing true for PREPARE, though I'm not sure if that would be better or worse. Any comments? (adding Stefan to Cc since I think this somewhat relates to/collides with the patch for *Messages* buffer text properties in https://lists.gnu.org/archive/html/emacs-devel/2018-05/msg00600.html).