From: "Mark A. Hershberger" <mah@everybody.org>
To: 32741@debbugs.gnu.org
Subject: bug#32741: [PATCH] Update references in core emacs from save-place to save-place-mode
Date: Sat, 15 Sep 2018 12:49:49 -0400 [thread overview]
Message-ID: <87in367ljm.fsf@everybody.org> (raw)
* lisp/menu-bar.el (menu-bar-options-save, menu-bar-options-menu):
* lisp/saveplace.el (save-place-to-alist, save-places-to-alist,
save-place-find-file-hook, save-place-dired-hook): Use
save-place-mode instead of the obsolete save-place.
* doc/lispref/customize.texi (Variable Definitions): Replace defcustom
example from 2005 with a more recent one.
---
doc/lispref/customize.texi | 12 ++++++------
| 6 +++---
lisp/saveplace.el | 12 ++++++------
3 files changed, 15 insertions(+), 15 deletions(-)
diff --git a/doc/lispref/customize.texi b/doc/lispref/customize.texi
index b3528b12d5..d7e97fcae7 100644
--- a/doc/lispref/customize.texi
+++ b/doc/lispref/customize.texi
@@ -450,14 +450,14 @@ Variable Definitions
that turns on a certain feature. This causes Emacs to load the
feature, if it is not already loaded, whenever the option is set.
@xref{Common Keywords}. Here is an example, from the library
-@file{saveplace.el}:
+@file{org-bbdb.el}:
@example
-(defcustom save-place nil
- "Non-nil means automatically save place in each file..."
- :type 'boolean
- :require 'saveplace
- :group 'save-place)
+(defcustom org-bbdb-default-anniversary-format "birthday"
+ "Default anniversary class."
+ :type 'string
+ :group 'org-bbdb-anniversaries
+ :require 'bbdb)
@end example
If a customization item has a type such as @code{hook} or
--git a/lisp/menu-bar.el b/lisp/menu-bar.el
index 20d5ad95d8..e626369cfb 100644
--- a/lisp/menu-bar.el
+++ b/lisp/menu-bar.el
@@ -689,7 +689,7 @@ menu-bar-options-save
debug-on-quit debug-on-error
;; Somehow this works, when tool-bar and menu-bar don't.
tooltip-mode window-divider-mode
- save-place uniquify-buffer-name-style fringe-mode
+ save-place-mode uniquify-buffer-name-style fringe-mode
indicate-empty-lines indicate-buffer-boundaries
case-fold-search font-use-system-font
current-language-environment default-input-method
@@ -1409,7 +1409,7 @@ menu-bar-options-menu
(bindings--define-key menu [save-place]
(menu-bar-make-toggle
- toggle-save-place-globally save-place
+ toggle-save-place-globally save-place-mode
"Save Place in Files between Sessions"
"Saving place in files %s"
"Visit files of previous session when restarting Emacs"
@@ -1417,7 +1417,7 @@ menu-bar-options-menu
;; Do it by name, to avoid a free-variable
;; warning during byte compilation.
(set-default
- 'save-place (not (symbol-value 'save-place)))))
+ 'save-place-mode (not (symbol-value 'save-place-mode)))))
(bindings--define-key menu [uniquify]
(menu-bar-make-toggle
diff --git a/lisp/saveplace.el b/lisp/saveplace.el
index 9d3f10ac35..f8f15cabcd 100644
--- a/lisp/saveplace.el
+++ b/lisp/saveplace.el
@@ -27,7 +27,7 @@
;; Automatically save place in files, so that visiting them later
;; (even during a different Emacs session) automatically moves point
;; to the saved position, when the file is first found. Uses the
-;; value of buffer-local variable save-place to determine whether to
+;; value of buffer-local variable save-place-mode to determine whether to
;; save position or not.
;;
;; Thanks to Stefan Schoef, who sent a patch with the
@@ -176,7 +176,7 @@ save-place-local-mode
(defun save-place-to-alist ()
;; put filename and point in a cons box and then cons that onto the
- ;; front of the save-place-alist, if save-place is non-nil.
+ ;; front of the save-place-alist, if save-place-mode is non-nil.
;; Otherwise, just delete that file from the alist.
;; first check to make sure alist has been loaded in from the master
;; file. If not, do so, then feel free to modify the alist. It
@@ -306,8 +306,8 @@ load-save-place-alist-from-file
nil))))
(defun save-places-to-alist ()
- ;; go through buffer-list, saving places to alist if save-place is
- ;; non-nil, deleting them from alist if it is nil.
+ ;; go through buffer-list, saving places to alist if save-place-mode
+ ;; is non-nil, deleting them from alist if it is nil.
(let ((buf-list (buffer-list)))
(while buf-list
;; put this into a save-excursion in case someone is counting on
@@ -332,7 +332,7 @@ save-place-find-file-hook
(and (integerp (cdr cell))
(goto-char (cdr cell))))
;; and make sure it will be saved again for later
- (setq save-place t)))))
+ (setq save-place-mode t)))))
(declare-function dired-goto-file "dired" (file))
@@ -357,7 +357,7 @@ save-place-dired-hook
((and (listp (cdr cell)) (assq 'dired-filename (cdr cell)))
(dired-goto-file (cdr (assq 'dired-filename (cdr cell)))))))
;; and make sure it will be saved again for later
- (setq save-place t)))))
+ (setq save-place-mode t)))))
(defun save-place-kill-emacs-hook ()
;; First update the alist. This loads the old save-place-file if nec.
--
2.18.0
next reply other threads:[~2018-09-15 16:49 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-15 16:49 Mark A. Hershberger [this message]
2018-09-22 8:04 ` bug#32741: [PATCH] Update references in core emacs from save-place to save-place-mode Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87in367ljm.fsf@everybody.org \
--to=mah@everybody.org \
--cc=32741@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.