From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#32850: 27.0.50; window-swap-states doesn't swap window prev/next-buffers Date: Thu, 25 Oct 2018 22:31:20 +0300 Organization: LINKOV.NET Message-ID: <87in1pltn3.fsf@mail.linkov.net> References: <875zyrrhk8.fsf@mail.linkov.net> <5BAD2538.1060609@gmx.at> <871s9e1syw.fsf@mail.linkov.net> <5BB082A6.6040709@gmx.at> <87o9cepxfv.fsf@mail.linkov.net> <5BB1DC5D.2070903@gmx.at> <87ftxgqcx0.fsf@mail.linkov.net> <5BBC5C61.4090901@gmx.at> <87ftx79brv.fsf@mail.linkov.net> <5BC5A536.7020603@gmx.at> <87o9bqlu7y.fsf@mail.linkov.net> <5BC98A76.9070207@gmx.at> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1540496447 13123 195.159.176.226 (25 Oct 2018 19:40:47 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Thu, 25 Oct 2018 19:40:47 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (x86_64-pc-linux-gnu) Cc: 32850@debbugs.gnu.org To: martin rudalics Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Oct 25 21:40:42 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gFlUo-0003J3-6R for geb-bug-gnu-emacs@m.gmane.org; Thu, 25 Oct 2018 21:40:42 +0200 Original-Received: from localhost ([::1]:56693 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gFlWu-0007Io-Rf for geb-bug-gnu-emacs@m.gmane.org; Thu, 25 Oct 2018 15:42:52 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:59102) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gFlWB-0006cZ-EH for bug-gnu-emacs@gnu.org; Thu, 25 Oct 2018 15:42:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gFlW7-000610-Eu for bug-gnu-emacs@gnu.org; Thu, 25 Oct 2018 15:42:07 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:38606) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gFlW7-00060r-BA for bug-gnu-emacs@gnu.org; Thu, 25 Oct 2018 15:42:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1gFlW7-0005l9-7d for bug-gnu-emacs@gnu.org; Thu, 25 Oct 2018 15:42:03 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 25 Oct 2018 19:42:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 32850 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 32850-submit@debbugs.gnu.org id=B32850.154049649622078 (code B ref 32850); Thu, 25 Oct 2018 19:42:03 +0000 Original-Received: (at 32850) by debbugs.gnu.org; 25 Oct 2018 19:41:36 +0000 Original-Received: from localhost ([127.0.0.1]:42859 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gFlVg-0005k2-9d for submit@debbugs.gnu.org; Thu, 25 Oct 2018 15:41:36 -0400 Original-Received: from glow.birch.relay.mailchannels.net ([23.83.209.71]:55177) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gFlVe-0005jr-Ln for 32850@debbugs.gnu.org; Thu, 25 Oct 2018 15:41:35 -0400 X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Original-Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id 134D35E3C89; Thu, 25 Oct 2018 19:41:33 +0000 (UTC) Original-Received: from pdx1-sub0-mail-a25.g.dreamhost.com (unknown [100.96.26.166]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id 974AD5E3BE4; Thu, 25 Oct 2018 19:41:30 +0000 (UTC) X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Original-Received: from pdx1-sub0-mail-a25.g.dreamhost.com (pop.dreamhost.com [64.90.62.162]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384) by 0.0.0.0:2500 (trex/5.16.2); Thu, 25 Oct 2018 19:41:33 +0000 X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|jurta@jurta.org X-MailChannels-Auth-Id: dreamhost X-Turn-Harbor: 2d91aa311c3dda42_1540496490790_2665041686 X-MC-Loop-Signature: 1540496490790:922593635 X-MC-Ingress-Time: 1540496490790 Original-Received: from pdx1-sub0-mail-a25.g.dreamhost.com (localhost [127.0.0.1]) by pdx1-sub0-mail-a25.g.dreamhost.com (Postfix) with ESMTP id 57EA5807C3; Thu, 25 Oct 2018 12:41:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=linkov.net; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; s=linkov.net; bh=LXwKcpnqN38yKAXujqsOvHxXJ90=; b= qzh3DlAFGoWA1O4M8z1XaS8d/pI/sAQZNeEJKcHSI8ZVMMW9S/b09wmOjIDVbtCN bAD2bpHtgKyfXca/5J09Ge0Fp6V8gLva4ESi2C7EiL5QjBRTiCL/ffsXSobEasxU 5kyiO6LKu+q334xlgjEg4j6zFL+VAvj4jAFPyQKC4mk= Original-Received: from mail.jurta.org (m91-129-105-154.cust.tele2.ee [91.129.105.154]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: jurta@jurta.org) by pdx1-sub0-mail-a25.g.dreamhost.com (Postfix) with ESMTPSA id 55375807C5; Thu, 25 Oct 2018 12:41:27 -0700 (PDT) X-DH-BACKEND: pdx1-sub0-mail-a25 In-Reply-To: <5BC98A76.9070207@gmx.at> (martin rudalics's message of "Fri, 19 Oct 2018 09:40:38 +0200") X-VR-OUT-STATUS: OK X-VR-OUT-SCORE: -100 X-VR-OUT-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedtkedrgeelgddugedvucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuggftfghnshhusghstghrihgsvgdpffftgfetoffjqffuvfenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurhephffvufhofhffjgfkfgggtgesthdtredttdertdenucfhrhhomheplfhurhhiucfnihhnkhhovhcuoehjuhhriheslhhinhhkohhvrdhnvghtqeenucfkphepledurdduvdelrddutdehrdduheegnecurfgrrhgrmhepmhhouggvpehsmhhtphdphhgvlhhopehmrghilhdrjhhurhhtrgdrohhrghdpihhnvghtpeeluddruddvledruddthedrudehgedprhgvthhurhhnqdhprghthheplfhurhhiucfnihhnkhhovhcuoehjuhhriheslhhinhhkohhvrdhnvghtqedpmhgrihhlfhhrohhmpehjuhhriheslhhinhhkohhvrdhnvghtpdhnrhgtphhtthhopehruhgurghlihgtshesghhmgidrrghtnecuvehluhhsthgvrhfuihiivgepud X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:151618 Archived-At: >> I found a problem, it occurs very rarely: >> >> Debugger entered--Lisp error: (wrong-type-argument stringp nil) >> get-buffer(nil) >> #f(compiled-function (entry) #)((nil nil nil)) >> mapcar(#f(compiled-function (entry) #) (("*Group*" 1 139) (nil nil nil) ("*sent reply to martin rudalics*" 1 1090))) >> window--state-put-2(safe 737) >> window-state-put(...) >> >> Do you have an idea how did (nil nil nil) find its way into the list of >> prev-buffers? (window-state-get was used with the non-nil WRITABLE arg) > > The most simple way to find out is to define such a list in window.c > and have 'set-window-prev-buffers' holler if the prev_buffers argument > is equal to that list. I can't find out how '(nil nil nil)' gets into the prev-buffers, so to avoid the error, I propose to install this patch: diff --git a/lisp/window.el b/lisp/window.el index 27d7e42280..c562ed3cfa 100644 --- a/lisp/window.el +++ b/lisp/window.el @@ -5854,14 +5854,15 @@ window--state-put-2 (set-window-next-buffers window (delq nil (mapcar (lambda (buffer) - (setq buffer (get-buffer buffer)) + (setq buffer (and buffer (get-buffer buffer))) (when (buffer-live-p buffer) buffer)) next-buffers)))) (when prev-buffers (set-window-prev-buffers window (delq nil (mapcar (lambda (entry) - (let ((buffer (get-buffer (nth 0 entry))) + (let ((buffer (and (nth 0 entry) + (get-buffer (nth 0 entry)))) (m1 (nth 1 entry)) (m2 (nth 2 entry))) (when (buffer-live-p buffer)