From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#32850: 27.0.50; window-swap-states doesn't swap window prev/next-buffers Date: Sun, 28 Oct 2018 21:09:15 +0200 Organization: LINKOV.NET Message-ID: <87in1m1dec.fsf@mail.linkov.net> References: <875zyrrhk8.fsf@mail.linkov.net> <5BAD2538.1060609@gmx.at> <871s9e1syw.fsf@mail.linkov.net> <5BB082A6.6040709@gmx.at> <87o9cepxfv.fsf@mail.linkov.net> <5BB1DC5D.2070903@gmx.at> <87ftxgqcx0.fsf@mail.linkov.net> <5BBC5C61.4090901@gmx.at> <87ftx79brv.fsf@mail.linkov.net> <5BC5A536.7020603@gmx.at> <87o9bqlu7y.fsf@mail.linkov.net> <5BC98A76.9070207@gmx.at> <87in1pltn3.fsf@mail.linkov.net> <5BD2C50E.2090508@gmx.at> <87lg6jysql.fsf@mail.linkov.net> <5BD57AD4.1090008@gmx.at> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1540755585 10927 195.159.176.226 (28 Oct 2018 19:39:45 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 28 Oct 2018 19:39:45 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (x86_64-pc-linux-gnu) Cc: 32850@debbugs.gnu.org To: martin rudalics Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Oct 28 20:39:41 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gGquT-0002lY-64 for geb-bug-gnu-emacs@m.gmane.org; Sun, 28 Oct 2018 20:39:41 +0100 Original-Received: from localhost ([::1]:41760 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gGqwZ-00059q-Qo for geb-bug-gnu-emacs@m.gmane.org; Sun, 28 Oct 2018 15:41:51 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:42336) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gGqvr-0004lA-1f for bug-gnu-emacs@gnu.org; Sun, 28 Oct 2018 15:41:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gGqvn-0007UH-NM for bug-gnu-emacs@gnu.org; Sun, 28 Oct 2018 15:41:06 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:45091) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gGqvn-0007U5-Jc for bug-gnu-emacs@gnu.org; Sun, 28 Oct 2018 15:41:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1gGqvn-00054U-Gk for bug-gnu-emacs@gnu.org; Sun, 28 Oct 2018 15:41:03 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 28 Oct 2018 19:41:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 32850 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 32850-submit@debbugs.gnu.org id=B32850.154075562219395 (code B ref 32850); Sun, 28 Oct 2018 19:41:03 +0000 Original-Received: (at 32850) by debbugs.gnu.org; 28 Oct 2018 19:40:22 +0000 Original-Received: from localhost ([127.0.0.1]:49341 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gGqv8-00052l-3a for submit@debbugs.gnu.org; Sun, 28 Oct 2018 15:40:22 -0400 Original-Received: from gecko.birch.relay.mailchannels.net ([23.83.209.66]:43320) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gGqv6-00052b-5n for 32850@debbugs.gnu.org; Sun, 28 Oct 2018 15:40:20 -0400 X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Original-Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id 7C5E25E240E; Sun, 28 Oct 2018 19:40:18 +0000 (UTC) Original-Received: from pdx1-sub0-mail-a9.g.dreamhost.com (unknown [100.96.26.166]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id 4974E5E26F3; Sun, 28 Oct 2018 19:40:18 +0000 (UTC) X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Original-Received: from pdx1-sub0-mail-a9.g.dreamhost.com (pop.dreamhost.com [64.90.62.162]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384) by 0.0.0.0:2500 (trex/5.16.2); Sun, 28 Oct 2018 19:40:18 +0000 X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|jurta@jurta.org X-MailChannels-Auth-Id: dreamhost X-Share-Ski: 7a85b17006564366_1540755618373_3986465006 X-MC-Loop-Signature: 1540755618373:3157298583 X-MC-Ingress-Time: 1540755618373 Original-Received: from pdx1-sub0-mail-a9.g.dreamhost.com (localhost [127.0.0.1]) by pdx1-sub0-mail-a9.g.dreamhost.com (Postfix) with ESMTP id 0EA137F790; Sun, 28 Oct 2018 12:40:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=linkov.net; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; s=linkov.net; bh=FwvR0IihTjxIkJrMQGydNhn/wA8=; b= lolmbgu8RLpdaFjXkvcv7NCzSoAAFHNepSwCML/ClwXKyBsPYmbboUYM7BnbDlyj WnMbLjlaQspej03RUZv0Cvq9S9mePlBpbLLTLPVoSMp7i8iNWy82zRQilUORbKk2 gyjfYyHGvQfStU2bYFGuCB8nMLB011oFYdVAi3iy6zs= Original-Received: from mail.jurta.org (m91-129-105-154.cust.tele2.ee [91.129.105.154]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: jurta@jurta.org) by pdx1-sub0-mail-a9.g.dreamhost.com (Postfix) with ESMTPSA id 018357F788; Sun, 28 Oct 2018 12:40:15 -0700 (PDT) X-DH-BACKEND: pdx1-sub0-mail-a9 In-Reply-To: <5BD57AD4.1090008@gmx.at> (martin rudalics's message of "Sun, 28 Oct 2018 10:01:08 +0100") X-VR-OUT-STATUS: OK X-VR-OUT-SCORE: -100 X-VR-OUT-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedtkedrheeigddufedtucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuggftfghnshhusghstghrihgsvgdpffftgfetoffjqffuvfenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurhephffvufhofhffjgfkfgggtgesthdtredttdertdenucfhrhhomheplfhurhhiucfnihhnkhhovhcuoehjuhhriheslhhinhhkohhvrdhnvghtqeenucfkphepledurdduvdelrddutdehrdduheegnecurfgrrhgrmhepmhhouggvpehsmhhtphdphhgvlhhopehmrghilhdrjhhurhhtrgdrohhrghdpihhnvghtpeeluddruddvledruddthedrudehgedprhgvthhurhhnqdhprghthheplfhurhhiucfnihhnkhhovhcuoehjuhhriheslhhinhhkohhvrdhnvghtqedpmhgrihhlfhhrohhmpehjuhhriheslhhinhhkohhvrdhnvghtpdhnrhgtphhtthhopehruhgurghlihgtshesghhmgidrrghtnecuvehluhhsthgvrhfuihiivgeptd X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:151756 Archived-At: >> @@ -5552,9 +5552,14 @@ window--state-get-1 >> (buffer (window-buffer window)) >> (selected (eq window (selected-window))) >> (next-buffers (when (window-live-p window) >> - (window-next-buffers window))) >> + (delq nil (mapcar (lambda (buffer) >> + (and (buffer-live-p buffer) buffer)) >> + (window-next-buffers window))))) >> (prev-buffers (when (window-live-p window) >> - (window-prev-buffers window))) >> + (delq nil (mapcar (lambda (entry) >> + (and (buffer-live-p (nth 0 entry)) >> + entry)) >> + (window-prev-buffers window))))) >> (head >> `(,type >> ,@(unless (window-next-sibling window) `((last . t))) > > OK. Wouldn't 'window-state-put' run into a similar problem when a > buffer in some prev or next list gets killed in between getting and > putting? 'window-state-put' already checks for 'buffer-live-p', and checking for nil is not needed in 'window-state-put' after the patch above will protect against nil getting into the window state.