From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eric Abrahamsen Newsgroups: gmane.emacs.bugs Subject: bug#34974: 27.0.50; Moving article error with duplicate suppression disabled Date: Sun, 24 Mar 2019 10:14:02 -0700 Message-ID: <87imw8kxet.fsf@ericabrahamsen.net> References: <871s2wpedf.fsf@tcd.ie> <87ftrcmhxx.fsf@ericabrahamsen.net> <878sx419q7.fsf@tcd.ie> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="146320"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: Lars Ingebrigtsen , 34974@debbugs.gnu.org To: "Basil L. Contovounesios" Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Mar 24 18:16:50 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1h86jq-000bte-IE for geb-bug-gnu-emacs@m.gmane.org; Sun, 24 Mar 2019 18:16:50 +0100 Original-Received: from localhost ([127.0.0.1]:58632 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h86jp-0007A9-E3 for geb-bug-gnu-emacs@m.gmane.org; Sun, 24 Mar 2019 13:16:49 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:42832) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h86jN-0006zu-7u for bug-gnu-emacs@gnu.org; Sun, 24 Mar 2019 13:16:22 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1h86i6-0005zJ-NL for bug-gnu-emacs@gnu.org; Sun, 24 Mar 2019 13:15:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:43450) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1h86i6-0005z7-9z for bug-gnu-emacs@gnu.org; Sun, 24 Mar 2019 13:15:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1h86i5-0004Uw-Tj; Sun, 24 Mar 2019 13:15:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eric Abrahamsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org, bugs@gnus.org Resent-Date: Sun, 24 Mar 2019 17:15:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 34974 X-GNU-PR-Package: emacs,gnus X-GNU-PR-Keywords: patch Original-Received: via spool by 34974-submit@debbugs.gnu.org id=B34974.155344765317211 (code B ref 34974); Sun, 24 Mar 2019 17:15:01 +0000 Original-Received: (at 34974) by debbugs.gnu.org; 24 Mar 2019 17:14:13 +0000 Original-Received: from localhost ([127.0.0.1]:56994 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h86hI-0004TX-MN for submit@debbugs.gnu.org; Sun, 24 Mar 2019 13:14:12 -0400 Original-Received: from ericabrahamsen.net ([52.70.2.18]:38694 helo=mail.ericabrahamsen.net) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h86hG-0004TF-EI for 34974@debbugs.gnu.org; Sun, 24 Mar 2019 13:14:11 -0400 Original-Received: from localhost (97-113-60-14.tukw.qwest.net [97.113.60.14]) (Authenticated sender: eric@ericabrahamsen.net) by mail.ericabrahamsen.net (Postfix) with ESMTPSA id 275D7FA02B; Sun, 24 Mar 2019 17:14:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ericabrahamsen.net; s=mail; t=1553447644; bh=aBgQ3A9ayPPy3EXiAHeutCfBaPQCOj0hrQhOvIRS1Z4=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=cKAzsoXBylQtYGZ16kuNg6pgCsCKUqP0pFULQk98sNTCAqs9F4nMLqndD1u7e4fTA IS3BUYjqc3y75f8Wt+31r//BMSucsaBBXo1wRcpTCI3FuNmIDyJdrtnriex2Wl378F J/x5tkvyhHTFCPp7ZZKEZC/ZU/M0bDKZZ/T98axg= In-Reply-To: <878sx419q7.fsf@tcd.ie> (Basil L. Contovounesios's message of "Sun, 24 Mar 2019 17:08:16 +0000") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:156708 Archived-At: On 03/24/19 17:08 PM, Basil L. Contovounesios wrote: > Eric Abrahamsen writes: > >> "Basil L. Contovounesios" writes: >> >>> With gnus-suppress-duplicates left at its default value of nil, trying >>> to move an article with 'B m ' gives me the following backtrace: >>> >>> Debugger entered--Lisp error: (wrong-type-argument hash-table-p nil) >>> remhash("" nil) >>> gnus-dup-unsuppress-article(1988) >>> gnus-summary-move-article(nil) >>> funcall-interactively(gnus-summary-move-article nil) >>> call-interactively(gnus-summary-move-article nil nil) >>> command-execute(gnus-summary-move-article) >>> >>> I'm no expert, and I haven't tried reproducing this with a minimal >>> config, but I think gnus-summary-move-article should not call >>> gnus-dup-unsuppress-article when gnus-suppress-duplicates is nil, right? >>> >>> This issue seems to have been uncovered by the switch to hash-tables in >>> bug#33653. Previously, gnus-dup-unsuppress-article called unintern, >>> which would not complain when its second argument gnus-dup-hashtb was >>> nil, even though it probably should have. >>> >>> Patch to follow. >> >> It looks like the only other call to `gnus-dup-unsuppress-articles' is >> wrapped in a check for `gnus-suppress-duplicates' -- I suppose it would >> be enough just to wrap this one as well? > > That is what the proposed patch[1] does. Is it okay to push this to > master? > > [1]: https://debbugs.gnu.org/34973#8 Already done! Our messages keep passing each other...