From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Alex Newsgroups: gmane.emacs.bugs Subject: bug#35179: [PATCH] Plug memory leak in GTK x-display-monitor-attributes-list Date: Sun, 07 Apr 2019 12:52:45 -0600 Message-ID: <87imvptzpe.fsf@gmail.com> References: <87a7h2z96i.fsf@gmail.com> <871s2dvpgf.fsf@gmail.com> <83wok593ny.fsf@gnu.org> <87wok5u3bv.fsf@gmail.com> <87sgutu2uh.fsf@gmail.com> <83sgut8yn3.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="199820"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) Cc: 35179@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Apr 07 20:53:18 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hDCur-000psq-7K for geb-bug-gnu-emacs@m.gmane.org; Sun, 07 Apr 2019 20:53:17 +0200 Original-Received: from localhost ([127.0.0.1]:42400 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hDCuq-0003o2-4R for geb-bug-gnu-emacs@m.gmane.org; Sun, 07 Apr 2019 14:53:16 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:48958) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hDCuh-0003np-Jj for bug-gnu-emacs@gnu.org; Sun, 07 Apr 2019 14:53:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hDCuf-0005Kk-18 for bug-gnu-emacs@gnu.org; Sun, 07 Apr 2019 14:53:05 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:35154) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hDCuc-0005Il-K2 for bug-gnu-emacs@gnu.org; Sun, 07 Apr 2019 14:53:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hDCuc-0002e4-BD for bug-gnu-emacs@gnu.org; Sun, 07 Apr 2019 14:53:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Alex Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 07 Apr 2019 18:53:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35179 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 35179-submit@debbugs.gnu.org id=B35179.155466317510157 (code B ref 35179); Sun, 07 Apr 2019 18:53:02 +0000 Original-Received: (at 35179) by debbugs.gnu.org; 7 Apr 2019 18:52:55 +0000 Original-Received: from localhost ([127.0.0.1]:48698 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hDCuV-0002dk-IJ for submit@debbugs.gnu.org; Sun, 07 Apr 2019 14:52:55 -0400 Original-Received: from mail-pl1-f173.google.com ([209.85.214.173]:35530) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hDCuS-0002dK-Js; Sun, 07 Apr 2019 14:52:53 -0400 Original-Received: by mail-pl1-f173.google.com with SMTP id w24so6019264plp.2; Sun, 07 Apr 2019 11:52:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=1xVzQG/Ilcg6Otsw/Yz9iw0OmzSZWKWsVSsi3bpj8Co=; b=MipZrgjnYXkcn4Laf3lQCTfr3EYkVDI9DBRujj57dxCYIrGKZbc6sVuMyMIXzkLGXD c1b+hsp7iJiKSpfeiZbrerNyIFY9dSD9AWChqbpQcM9KtWlDpJLaSGnUMFcTygM3cDNK vyjF2O/K+PxroLpsdHsVXmZC7AOMmNRRx6VaUnKWmA9AmNkbhAT3cvJ6j782W2WkTs4A pf1GulIKsb9i029m1w6+zQRGOtHzZkk4rRJ8VEephJfHtEHH70KB9q3/AIuur/54wTEb S8f8ltScF+MhR5pkfaTcojmZFI7NCPlTSQLpetIo777H0DWqsK4ajtT4jo4EmrZM8aY/ Udpg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=1xVzQG/Ilcg6Otsw/Yz9iw0OmzSZWKWsVSsi3bpj8Co=; b=X31g9C+aerHZjjTQNnNdhqSWqAm6IapM8sGa2NMt2G3xh23thTQddxFrs7ilgbsNti RsTx32CECFpX5BWVddOJWxBcc3gqVawyd9TX+lbiSXPqaqOWnQaL2FE5CD+UiQV9k4ir pGDujtKMGCl51ctAuSUbZFLaX4E1tJXcqMWA/i6999I5Gq0iMd7JP/P4dFGRdBY+huqJ E5utJmcZjV98cqkzNLNeZny0iijvzIbkqJRiqqsqOUhykEySOn7Nk7zmSuVG7S5Tym/c nxme1RXwsCd+KJAR66sVgI7VWPwyh19+6Q+WJ0ODF/FfYVVvwmMOSPZdmp4C00HHGa9a hhEg== X-Gm-Message-State: APjAAAW6x/aLI5IvzIaWGfgW7uXCss8QYgxko+796T/WlH6ltiLdQFWs vUmhh6HCx//4JsWFaEdA36tAn+t0 X-Google-Smtp-Source: APXvYqxXFxjhxLC1Q3JY+ZXiolwYaRxyZ1+ODbBIstr9Ls7vJpCs8TUFTZMINVghH4ofb6UCUtjqgw== X-Received: by 2002:a17:902:2a89:: with SMTP id j9mr25985301plb.272.1554663166131; Sun, 07 Apr 2019 11:52:46 -0700 (PDT) Original-Received: from lylat ([2604:3d09:e37f:1500:1a72:4878:e793:7302]) by smtp.gmail.com with ESMTPSA id 129sm15691668pgc.24.2019.04.07.11.52.44 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 07 Apr 2019 11:52:45 -0700 (PDT) In-Reply-To: <83sgut8yn3.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 07 Apr 2019 21:21:20 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:157320 Archived-At: close 35179 quit Eli Zaretskii writes: >> From: Alex >> Cc: 35179@debbugs.gnu.org >> Date: Sun, 07 Apr 2019 11:44:54 -0600 >> >> Whoops, I forgot to add a closing parenthesis... > > Thanks. This variant is fine with me, but since we use xfree to free > the name, I think we should use xstrdup, not g_strdup, to copy it, as > the latter is documented to need g_free to free the storage. Okay, I pushed it as a35e06bbe2. I also added in a GTK version check since `name' isn't used if !GTK_CHECK_VERSION(2, 14, 0).