From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: John Shahid Newsgroups: gmane.emacs.devel Subject: commit 8147d3c27c breaks grep over tramp Date: Tue, 09 Apr 2019 10:28:15 -0400 Message-ID: <87imvn5k3k.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="179294"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: mu4e 1.1.0; emacs 27.0.50 To: Emacs developers Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Apr 09 16:28:31 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hDrji-000kZE-QM for ged-emacs-devel@m.gmane.org; Tue, 09 Apr 2019 16:28:30 +0200 Original-Received: from localhost ([127.0.0.1]:42526 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hDrjh-0001ym-NP for ged-emacs-devel@m.gmane.org; Tue, 09 Apr 2019 10:28:29 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:47364) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hDrjc-0001yU-06 for emacs-devel@gnu.org; Tue, 09 Apr 2019 10:28:24 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hDrjb-0007DW-4H for emacs-devel@gnu.org; Tue, 09 Apr 2019 10:28:23 -0400 Original-Received: from mail-qt1-x829.google.com ([2607:f8b0:4864:20::829]:36474) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hDrja-0007Cm-RG for emacs-devel@gnu.org; Tue, 09 Apr 2019 10:28:23 -0400 Original-Received: by mail-qt1-x829.google.com with SMTP id s15so11627797qtn.3 for ; Tue, 09 Apr 2019 07:28:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=user-agent:from:to:subject:date:message-id:mime-version; bh=3FsFbMUEKKSPsDLglPiteanqucGcGV9I8ks/pm3MvHM=; b=SejgPsNCkStvet8Q+sZ6D/IhL3R3rwet9uMUIFo/FgADyVw5kl9k0lG1+6KB4rddt2 LJG7AwS5K3fycrslN34nj48KO0lvyzKOxpJrlYG+R6BhkDLJ1HUsFzJDntEuQU2FNxw0 T9FnJ1ZlAh/CLObY5+/bsIgEWqP7h0Cp+odYL9wmfykskkqo7s9p7xXQbjnmUW7dO4/B BwH2K6eOlR8QSdXDtfN6TfyOYBLux6cLn3GnprMEJRr2q+Pxmzkdokva/LCMFNM3z4+P eDnmGHZeO6lpJ6r5ybmKm1C6JDvV5hMY4U3bctipWmT3HoSOOi9v6dfH4XOhyJnX1jgn DBVg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:user-agent:from:to:subject:date:message-id :mime-version; bh=3FsFbMUEKKSPsDLglPiteanqucGcGV9I8ks/pm3MvHM=; b=C4PE6wQKdVw0I1p+SpsA/O8LfQCc0yBmBf7/r8PT7MAs7BfLqlB/rQECXFI7kRHWwm yUhIg6C2SdZZq9x1wiJdYpIs7CQ1u5s9a6OSY7swMS88iLkrn2qEaD9JA4BLiqToUuVL uK4aJEH3o+giMq9AHInQEDwZC9cGuf+5jAgSZziMgwfVE3jbQ/+ZR1kjRhhR9glMNeyc WNj86V7dfVD0kwmu9RxZVcH7M2YthPueyPSI66IxEb/cTKz5eTVSbrfBH8fop/2Ug2iu 1d9s5sDx3P1KjaNm24bLxKvrrYd44Lq2HNq4Qrc3CPPx8nEEnxaZrolY8Kp9zFgJ+EQv /nhg== X-Gm-Message-State: APjAAAX4EB2kL9ajSVBeXENB8YZJMvAoz/w/rzJCmBNwrrbbJm0Qj9PX YVwYFz7FxaFZEAGkHULrrtTOHb/h X-Google-Smtp-Source: APXvYqxQPx70AIpxiXgiWSLQjEUcryF3Ti9e9bq1Am29f0HkQdZq3efPy9Wd26Xchqwmw2RLC0pjHg== X-Received: by 2002:a0c:ad15:: with SMTP id u21mr30433068qvc.37.1554820101040; Tue, 09 Apr 2019 07:28:21 -0700 (PDT) Original-Received: from amun ([142.154.219.2]) by smtp.gmail.com with ESMTPSA id 133sm14190174qkn.68.2019.04.09.07.28.19 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 09 Apr 2019 07:28:19 -0700 (PDT) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::829 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:235164 Archived-At: Hi all, Looks like commit 8147d3c27c breaks `grep' when ran on a remote host using tramp. Previous to the commit I would see the list of grep hits, but after this commit there is a command prompt as part of the grep hits. This makes the first hit unclickable. I bisected the history to find the offending commit and found the following change to be the cause: > @@ -2912,8 +2903,7 @@ tramp-sh-handle-make-process > ;; otherwise we might be interrupted by > ;; `verify-visited-file-modtime'. > (let ((buffer-undo-list t) > - (inhibit-read-only t) > - (mark (point-max))) > + (inhibit-read-only t)) > (clear-visited-file-modtime) > (narrow-to-region (point-max) (point-max)) > ;; We call `tramp-maybe-open-connection', in > @@ -2926,9 +2916,7 @@ tramp-sh-handle-make-process > (let ((pid (tramp-send-command-and-read v "echo $$"))) > (process-put p 'remote-pid pid) > (tramp-set-connection-property p "remote-pid" pid)) > - (widen) > - (delete-region mark (point-max)) > - (narrow-to-region (point-max) (point-max)) > + (delete-region (point-min) (point-max)) Is anyone else seeing the same thing or is it something with my configuration ? Cheers, JS