all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: John Shahid <jvshahid@gmail.com>
To: Emacs developers <emacs-devel@gnu.org>
Subject: commit 8147d3c27c breaks grep over tramp
Date: Tue, 09 Apr 2019 10:28:15 -0400	[thread overview]
Message-ID: <87imvn5k3k.fsf@gmail.com> (raw)

Hi all,

Looks like commit 8147d3c27c breaks `grep' when ran on a remote host
using tramp.  Previous to the commit I would see the list of grep hits,
but after this commit there is a command prompt as part of the grep
hits.  This makes the first hit unclickable.  I bisected the history to
find the offending commit and found the following change to be the
cause:

> @@ -2912,8 +2903,7 @@ tramp-sh-handle-make-process
>  		    ;; otherwise we might be interrupted by
>  		    ;; `verify-visited-file-modtime'.
>  		    (let ((buffer-undo-list t)
> -			  (inhibit-read-only t)
> -			  (mark (point-max)))
> +			  (inhibit-read-only t))
>  		      (clear-visited-file-modtime)
>  		      (narrow-to-region (point-max) (point-max))
>  		      ;; We call `tramp-maybe-open-connection', in
> @@ -2926,9 +2916,7 @@ tramp-sh-handle-make-process
>  			(let ((pid (tramp-send-command-and-read v "echo $$")))
>  			  (process-put p 'remote-pid pid)
>  			  (tramp-set-connection-property p "remote-pid" pid))
> -			(widen)
> -			(delete-region mark (point-max))
> -			(narrow-to-region (point-max) (point-max))
> +			(delete-region (point-min) (point-max))

Is anyone else seeing the same thing or is it something with my
configuration ?

Cheers,

JS



             reply	other threads:[~2019-04-09 14:28 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-09 14:28 John Shahid [this message]
2019-04-09 15:02 ` commit 8147d3c27c breaks grep over tramp Michael Albinus
2019-04-09 17:38   ` John Shahid
2019-04-13 10:39     ` Michael Albinus
2019-04-14 21:54       ` John Shahid

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87imvn5k3k.fsf@gmail.com \
    --to=jvshahid@gmail.com \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.