all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Noam Postavsky <npostavs@gmail.com>
To: Eric Abrahamsen <eric@ericabrahamsen.net>
Cc: 34776@debbugs.gnu.org
Subject: bug#34776: Acknowledgement (27.0.50; Some questions about choose-completion-string-functions)
Date: Tue, 09 Apr 2019 20:03:17 -0400	[thread overview]
Message-ID: <87imvmbube.fsf@gmail.com> (raw)
In-Reply-To: <871s3a90qo.fsf@ericabrahamsen.net> (Eric Abrahamsen's message of "Wed, 13 Mar 2019 09:51:11 -0700")

Eric Abrahamsen <eric@ericabrahamsen.net> writes:

> So never mind! But I'd still like to add something like the attached, as
> functions following the current docstring will raise an error.
>
> Eric
>
> diff --git a/lisp/simple.el b/lisp/simple.el
> index d4ae5ebb1f..0274bdb459 100644
> --- a/lisp/simple.el
> +++ b/lisp/simple.el
> @@ -8188,6 +8188,9 @@ choose-completion-string-functions
>  BUFFER - the buffer in which the choice should be inserted,
>  BASE-POSITION - where to insert the completion.
>  
> +Functions should also accept and ignore a potential fourth
> +argument, passed for backwards compatibility.
> +

Looks good to me.  And it can go to emacs-26 since it's a doc fix.





  reply	other threads:[~2019-04-10  0:03 UTC|newest]

Thread overview: 45+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-06 23:05 bug#34776: 27.0.50; Some questions about choose-completion-string-functions Eric Abrahamsen
     [not found] ` <handler.34776.B.155191354931988.ack@debbugs.gnu.org>
2019-03-09  0:05   ` bug#34776: Acknowledgement (27.0.50; Some questions about choose-completion-string-functions) Eric Abrahamsen
2019-03-09  2:07     ` Glenn Morris
2019-03-13 16:51       ` Eric Abrahamsen
2019-04-10  0:03         ` Noam Postavsky [this message]
2019-04-10  3:16           ` Eric Abrahamsen
2019-04-10  3:29           ` Glenn Morris
2019-04-10  4:33             ` Eli Zaretskii
2019-04-10  6:35               ` Eric Abrahamsen
2019-04-10  7:01                 ` Eli Zaretskii
2019-04-10  7:22                   ` Eric Abrahamsen
2019-04-10  7:29                     ` Eric Abrahamsen
2019-04-10  8:24                     ` Eli Zaretskii
2019-04-10  8:57                       ` Branch freezing for release (WAS: bug#34776) Noam Postavsky
2019-04-10  9:21                         ` Eli Zaretskii
2019-04-10 16:16                           ` Noam Postavsky
2019-04-10 16:40                             ` Eli Zaretskii
2019-04-10 16:59                               ` Branch freezing for release Basil L. Contovounesios
2019-04-10 17:12                                 ` Eli Zaretskii
2019-04-10 17:39                                   ` Basil L. Contovounesios
2019-04-10 18:31                                     ` Eli Zaretskii
2019-04-11 14:02                                       ` Basil L. Contovounesios
2019-04-22 13:03                                       ` Basil L. Contovounesios
2019-04-22 13:14                                         ` Eli Zaretskii
2019-04-22 15:18                                           ` Basil L. Contovounesios
2019-04-10 17:56                                   ` Stefan Monnier
2019-04-10 18:26                                     ` Eli Zaretskii
2019-04-10 18:54                                       ` Stefan Monnier
2019-04-10 19:19                                         ` Eli Zaretskii
2019-04-10 20:16                                           ` Dmitry Gutov
2019-04-11  0:12                                             ` Noam Postavsky
2019-04-11 13:52                                               ` Eli Zaretskii
2019-04-12  1:03                                                 ` Noam Postavsky
2019-04-12  7:04                                                   ` Eli Zaretskii
2019-04-12 10:18                                                     ` Noam Postavsky
2019-04-12 12:23                                                       ` Stefan Monnier
2019-04-12 12:24                                                       ` Eli Zaretskii
2019-04-12 14:14                                                     ` Dmitry Gutov
2019-04-10 13:14                         ` Stefan Monnier
2019-04-10 13:47                           ` Andreas Schwab
2019-04-10 15:03                           ` Eli Zaretskii
2019-04-10  8:05               ` bug#34776: Acknowledgement (27.0.50; Some questions about choose-completion-string-functions) Andreas Schwab
2019-04-10  8:22                 ` Eli Zaretskii
2019-04-10  8:39                   ` Andreas Schwab
2019-04-10  8:48                     ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87imvmbube.fsf@gmail.com \
    --to=npostavs@gmail.com \
    --cc=34776@debbugs.gnu.org \
    --cc=eric@ericabrahamsen.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.