From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Noam Postavsky Newsgroups: gmane.emacs.bugs Subject: bug#35222: 26.1; `read-command' documentation Date: Thu, 11 Apr 2019 20:11:15 -0400 Message-ID: <87imvk9j6k.fsf@gmail.com> References: <54098355-6406-459c-9a3a-b7c5b4fe286b@default> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="22721"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.91 (gnu/linux) Cc: 35222@debbugs.gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Apr 12 02:12:15 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hEjni-0005nB-Vj for geb-bug-gnu-emacs@m.gmane.org; Fri, 12 Apr 2019 02:12:15 +0200 Original-Received: from localhost ([127.0.0.1]:56615 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hEjnh-0007eF-Vu for geb-bug-gnu-emacs@m.gmane.org; Thu, 11 Apr 2019 20:12:14 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:54420) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hEjnb-0007dx-6e for bug-gnu-emacs@gnu.org; Thu, 11 Apr 2019 20:12:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hEjnZ-0005qf-Ab for bug-gnu-emacs@gnu.org; Thu, 11 Apr 2019 20:12:07 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:41770) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hEjnW-0005oy-Rg for bug-gnu-emacs@gnu.org; Thu, 11 Apr 2019 20:12:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hEjnW-0003Ef-Jc for bug-gnu-emacs@gnu.org; Thu, 11 Apr 2019 20:12:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Noam Postavsky Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 12 Apr 2019 00:12:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35222 X-GNU-PR-Package: emacs Original-Received: via spool by 35222-submit@debbugs.gnu.org id=B35222.155502788412390 (code B ref 35222); Fri, 12 Apr 2019 00:12:02 +0000 Original-Received: (at 35222) by debbugs.gnu.org; 12 Apr 2019 00:11:24 +0000 Original-Received: from localhost ([127.0.0.1]:55314 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hEjmu-0003Dm-AR for submit@debbugs.gnu.org; Thu, 11 Apr 2019 20:11:24 -0400 Original-Received: from mail-qt1-f170.google.com ([209.85.160.170]:37267) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hEjms-0003DX-TQ for 35222@debbugs.gnu.org; Thu, 11 Apr 2019 20:11:23 -0400 Original-Received: by mail-qt1-f170.google.com with SMTP id z16so9331528qtn.4 for <35222@debbugs.gnu.org>; Thu, 11 Apr 2019 17:11:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=PG6RBenpmZs1MErzLPzGVaZBDuUhgLkF2v1LxpZgZjg=; b=hafl7DeNW0yj+tQp5FycP4tIvRDfn++i1+wkM+VkMExMRF+IPUtigkS1RS0VoZkV3X 2MKwEP86uINqNICyRKojxuxtdorMUW4V3Mh2pXZPbBL7tUnlYZnpiJOK8pCH0RYEs4Pn mKZh5/7Gqz6Na0ggC2ZM0DgYcI2WSbMtxrzJVXxy5aPtv0w3pjXmAWw4WT7NTO1/qyIS oQsnjyeB4mymYph3sSMZZ+s3DMJJOlOJhrr/wIdBtQ+PjxddXxX6l3PG04BMpPb9y8E4 R0DEpU8r/ehh9fzS7J2GIglhN2jnzF5iJNmNL5zNmBk0h38ttUKj3UNJhSXg7vuYrBYt tQlw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=PG6RBenpmZs1MErzLPzGVaZBDuUhgLkF2v1LxpZgZjg=; b=GdgzGT2ik7tmvD82Q4aWycb7Ld7qjALdVH5r8/5/FJyJV+LKL7m2t3tEAc/tke+wCx W4YR2tfsEPOqa5xnecgciR8QjjVdhnU9iofFhLOpSNW5KlZv3yQFEcyGXbe6IShAD5sX hz0C3bsTiBcFYWDugvD0qtY0f+5jjjdRQVA2Ht1S1x1rLmr9mJABEX7R6V1B5krAKTza Rs4xU7RirS3sZfciBjn28qeWPBDDp4ExfrQ92b615XY7kWZqh4OxiusUnWtM4/LTC8kb QRPeT55IXf0BJPpof2O0kJERVyYC1jQh12da3d7qbjNhhUYen3hK/Q4cvYQMYZNEdEe8 vROg== X-Gm-Message-State: APjAAAUzmUMDpzGmmVmPX4mcfRcun00EGXeVXWZt8gZxfeOtXwB0Pwu0 M0L+8FAwNbqDb4vEuDJxuEU= X-Google-Smtp-Source: APXvYqwKQ0DP3ZQHhHCNlrAvHHgSx0xlcHoNDPOxDxd0FbpGiQ5PuILx3V7gbsVu2Yxaa7sn9qpIiQ== X-Received: by 2002:a0c:9945:: with SMTP id i5mr42708284qvd.159.1555027877530; Thu, 11 Apr 2019 17:11:17 -0700 (PDT) Original-Received: from minid (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.googlemail.com with ESMTPSA id v8sm25784880qtc.69.2019.04.11.17.11.16 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 11 Apr 2019 17:11:16 -0700 (PDT) In-Reply-To: (Stefan Monnier's message of "Thu, 11 Apr 2019 14:55:47 -0400") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:157529 Archived-At: Stefan Monnier writes: >>> 1. The doc string does not say what happens if DEFAULT is not provided >>> (so `nil') and the user enters empty input. And what happens is not >>> obvious. Please add that information to the doc string. >> Um, can we declare the current behaviour a bug, and instead return nil >> in this case? That matches the current doc string (i.e., return >> DEFAULT-VALUE), and avoids the whole mess with the empty string symbol >> which is weird and pretty useless as far as I can tell. > > Yes, it would seem to be more in line with the usual expected behavior. > The caller can get the current behavior by passing ## as the DEFAULT > argument, so there doesn't seem to be any good reason to return ## when > DEFAULT was nil. Since this bug is already closed, this should go Bug#35231.