From: Lars Ingebrigtsen <larsi@gnus.org>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 33002@debbugs.gnu.org, winston@ml1.net,
Federico Tedin <federicotedin@gmail.com>
Subject: bug#33002: 26.1; EWW sends unspecific "Accept: */*" header
Date: Mon, 13 May 2019 14:08:09 -0400 [thread overview]
Message-ID: <87imuew7li.fsf@mouse.gnus.org> (raw)
In-Reply-To: <83bm6s8hde.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 14 Nov 2018 05:31:25 +0200")
Eli Zaretskii <eliz@gnu.org> writes:
>> From: Federico Tedin <federicotedin@gmail.com>
>> Date: Tue, 13 Nov 2018 18:26:53 -0300
>> Cc: John Smith <winston@ml1.net>, 33002@debbugs.gnu.org
>>
>> Eli, sorry to bother you. Just wanted to know if the last patch I sent
>> is OK or if it needs any further changes.
>
> I still don't think that a variable is the right solution for this.
> Perhaps Lars (CC'ed) or someone else has an opinion or a better
> proposal?
I think it makes sense to use a variable here -- if for no other reason
that the string is used two different places in the eww source code, and
avoiding repeating that long string is nice. But leaving it
undocumented (in the manual) is fine, I think, as I don't see anybody
ever wanting to change it.
So I've applied Federico's patch to Emacs 27.1.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
prev parent reply other threads:[~2019-05-13 18:08 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-10 5:11 bug#33002: 26.1; EWW sends unspecific "Accept: */*" header Winston Weinert
2018-10-13 21:59 ` Federico Tedin
2018-11-04 3:15 ` Federico Tedin
2018-11-04 17:27 ` Eli Zaretskii
2018-11-04 18:29 ` Federico Tedin
2018-11-13 21:26 ` Federico Tedin
2018-11-14 3:31 ` Eli Zaretskii
2019-05-13 18:08 ` Lars Ingebrigtsen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87imuew7li.fsf@mouse.gnus.org \
--to=larsi@gnus.org \
--cc=33002@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=federicotedin@gmail.com \
--cc=winston@ml1.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.