From: "Óscar Fuentes" <ofv@wanadoo.es>
To: emacs-devel@gnu.org
Cc: Oleh Krehel <ohwoeowho@gmail.com>
Subject: Re: send new reply from gnus hangs
Date: Mon, 10 Jun 2019 01:33:42 +0200 [thread overview]
Message-ID: <87imtetju1.fsf@telefonica.net> (raw)
In-Reply-To: <87d0jmuyrj.fsf@telefonica.net> ("Óscar Fuentes"'s message of "Mon, 10 Jun 2019 01:25:52 +0200")
Confirmed, reverting that commit fixes the problem.
Óscar Fuentes <ofv@wanadoo.es> writes:
> Óscar Fuentes <ofv@wanadoo.es> writes:
>
>>>>>>> Andy Moreton <andrewjmoreton@gmail.com> writes:
>>>>>>>
>>>>>>>> A recent change on the master branch (within the last week) prevents
>>>>>>>> gnus from sending replies to newsgroups - it gets stuck with
>>>>>>>> "sending..." in the message area.
>>>>>>>>
>>>>>>>> I've looked at the recent commits that might affect gnus, but nothing
>>>>>>>> obvious jumps out. I'm not sure what the problem is or how to start
>>>>>>>> debugging it.
>>>>>>>>
>>>>>>>> Does anyone have any ideas ?
>>>>>>>
>>>>>>> git bisect
>
> The problematic commit is
>
> master e51adfbdb7587c2b0b5ba154be210b30db82b4ea
> Author: Oleh Krehel <ohwoeowho@gmail.com>
> AuthorDate: Thu Jun 6 16:01:10 2019 +0200
> Commit: Oleh Krehel <ohwoeowho@gmail.com>
> CommitDate: Thu Jun 6 16:01:10 2019 +0200
>
> Parent: e188f08fcd lisp/gnus/message.el (message--fold-long-headers): Add docstring
> Merged: emacs-26 master
> Containing: master
> Follows: emacs-26.1 (5471)
>
> lisp/gnus/message.el (message--check-continuation-headers): Extract
>
> 1 file changed, 13 insertions(+), 21 deletions(-)
> lisp/gnus/message.el | 34 +++++++++++++---------------------
>
> modified lisp/gnus/message.el
> @@ -4476,6 +4476,17 @@ message-send-mail-partially
>
> (declare-function hashcash-wait-async "hashcash" (&optional buffer))
>
> +(defun message--check-continuation-headers ()
> + (message-check 'continuation-headers
> + (goto-char (point-min))
> + (while (re-search-forward "^[^ \t\n][^ \t\n:]*[ \t\n]" nil t)
> + (goto-char (match-beginning 0))
> + (if (y-or-n-p "Fix continuation lines? ")
> + (insert " ")
> + (forward-line 1)
> + (unless (y-or-n-p "Send anyway? ")
> + (error "Failed to send the message"))))))
> +
> (defun message-send-mail (&optional _)
> (require 'mail-utils)
> (let* ((tembuf (message-generate-new-buffer-clone-locals " message temp"))
> @@ -4527,15 +4538,7 @@ message-send-mail
> (if news nil message-deletable-headers)))
> (message-generate-headers headers))
> ;; Check continuation headers.
> - (message-check 'continuation-headers
> - (goto-char (point-min))
> - (while (re-search-forward "^[^ \t\n][^ \t\n:]*[ \t\n]" nil t)
> - (goto-char (match-beginning 0))
> - (if (y-or-n-p "Fix continuation lines? ")
> - (insert " ")
> - (forward-line 1)
> - (unless (y-or-n-p "Send anyway? ")
> - (error "Failed to send the message")))))
> + (message--check-continuation-headers)
> (message--fold-long-headers)
> ;; Let the user do all of the above.
> (run-hooks 'message-header-hook))
> @@ -5159,18 +5162,7 @@ message-check-news-header-syntax
> (if (= (length errors) 1) "this" "these")
> (if (= (length errors) 1) "" "s")
> (mapconcat 'identity errors ", ")))))))
> - ;; Check continuation headers.
> - (message-check 'continuation-headers
> - (goto-char (point-min))
> - (let ((do-posting t))
> - (while (re-search-forward "^[^ \t\n][^ \t\n:]*[ \t\n]" nil t)
> - (goto-char (match-beginning 0))
> - (if (y-or-n-p "Fix continuation lines? ")
> - (insert " ")
> - (forward-line 1)
> - (unless (y-or-n-p "Send anyway? ")
> - (setq do-posting nil))))
> - do-posting))
> + (message--check-continuation-headers)
> ;; Check the Newsgroups & Followup-To headers for syntax errors.
> (message-check 'valid-newsgroups
> (let ((case-fold-search t)
next prev parent reply other threads:[~2019-06-09 23:33 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-07 21:20 send new reply from gnus hangs Andy Moreton
2019-06-07 22:34 ` Óscar Fuentes
2019-06-09 22:47 ` Óscar Fuentes
2019-06-09 23:00 ` Óscar Fuentes
2019-06-09 23:03 ` Óscar Fuentes
2019-06-09 23:11 ` Óscar Fuentes
2019-06-09 23:18 ` Óscar Fuentes
2019-06-09 23:19 ` Óscar Fuentes
2019-06-09 23:25 ` Óscar Fuentes
2019-06-09 23:33 ` Óscar Fuentes [this message]
2019-06-10 7:56 ` Robert Pluim
2019-06-10 11:52 ` Andy Moreton
2019-06-14 2:38 ` Eric Abrahamsen
2019-06-14 2:39 ` Eric Abrahamsen
2019-06-14 13:42 ` Óscar Fuentes
2019-06-14 14:58 ` Eric Abrahamsen
2019-06-09 23:04 ` Óscar Fuentes
2019-06-09 23:06 ` Óscar Fuentes
2019-06-09 23:16 ` Óscar Fuentes
2019-06-09 23:02 ` Óscar Fuentes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87imtetju1.fsf@telefonica.net \
--to=ofv@wanadoo.es \
--cc=emacs-devel@gnu.org \
--cc=ohwoeowho@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.