From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Michael Heerdegen Newsgroups: gmane.emacs.bugs Subject: bug#36324: 27.0.50; Error in savehist-save: (wrong-type-argument listp t) Date: Sat, 22 Jun 2019 17:29:22 +0200 Message-ID: <87imsxiqp9.fsf@web.de> References: <87zhma9b6v.fsf@web.de> <87h88ir09w.fsf@web.de> <87lfxuxs76.fsf@web.de> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="41395"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: 36324@debbugs.gnu.org, Davor Rotim To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Jun 22 17:30:18 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hehy4-000AYw-N6 for geb-bug-gnu-emacs@m.gmane.org; Sat, 22 Jun 2019 17:30:16 +0200 Original-Received: from localhost ([::1]:41266 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hehy3-0003Lk-O3 for geb-bug-gnu-emacs@m.gmane.org; Sat, 22 Jun 2019 11:30:15 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:38302) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hehxv-0003Kd-82 for bug-gnu-emacs@gnu.org; Sat, 22 Jun 2019 11:30:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hehxt-0001mo-K0 for bug-gnu-emacs@gnu.org; Sat, 22 Jun 2019 11:30:07 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:38875) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hehxq-0001hk-Lf for bug-gnu-emacs@gnu.org; Sat, 22 Jun 2019 11:30:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hehxq-0004Ci-Bc for bug-gnu-emacs@gnu.org; Sat, 22 Jun 2019 11:30:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Michael Heerdegen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 22 Jun 2019 15:30:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 36324 X-GNU-PR-Package: emacs Original-Received: via spool by 36324-submit@debbugs.gnu.org id=B36324.156121737716103 (code B ref 36324); Sat, 22 Jun 2019 15:30:02 +0000 Original-Received: (at 36324) by debbugs.gnu.org; 22 Jun 2019 15:29:37 +0000 Original-Received: from localhost ([127.0.0.1]:52419 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hehxQ-0004Bf-Mn for submit@debbugs.gnu.org; Sat, 22 Jun 2019 11:29:36 -0400 Original-Received: from mout.web.de ([212.227.15.14]:47461) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hehxN-0004BO-UL for 36324@debbugs.gnu.org; Sat, 22 Jun 2019 11:29:35 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=dbaedf251592; t=1561217364; bh=w8z99qcLUddv0rF7MH6gLS8MtFlY+JZzYfHEezFOPMA=; h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To; b=i4BYYHUPQusQ92TLl48lHSvaAg6ic40342gwqXVynBgVA5ee/V1IXo78mdgY/zy41 hyKxFn7pHVf1Orx/HsaNKAvverZEK+2EpCgOzV6rNF7p8SlA+m+UbGuK2gkbxBEGTP aJajsLTs7bhoZpNZdV5G/cRw5zfvzwTqRDzfx9EY= X-UI-Sender-Class: c548c8c5-30a9-4db5-a2e7-cb6cb037b8f9 Original-Received: from drachen.dragon ([188.98.106.25]) by smtp.web.de (mrweb004 [213.165.67.108]) with ESMTPSA (Nemesis) id 0MLlCd-1heQyN2i9r-000pqv; Sat, 22 Jun 2019 17:29:24 +0200 In-Reply-To: (Lars Ingebrigtsen's message of "Sat, 22 Jun 2019 11:33:32 +0200") X-Provags-ID: V03:K1:QspWw8LYHyco1zO7KynqP1UCnB+u2qvLraHW4B0Bn69XUzX65WX MwE6/tJuSNJU+RPJhl7x3xZKnYa4k4aEvLyGjgnhuxNCLSSbEn6McPNbgnUmNXEH5sqXDii UDrlUAq9DIArVItEekYdfXZeXmaBDHXPL4vr9sz7+G6m72e4JEQrNZaL3eDmmlAHBleeTGz J5T3k7rfGGWHChvsXbIMQ== X-UI-Out-Filterresults: notjunk:1;V03:K0:0531i12GxUI=:WXsBq2/ORtSMqLlMnPy2MN qG1srr/AeK94Ao0VCTdq1lXBmrj1mlXxVAMf1SirOnHVaFamElUcvGqkFTE+0Aq2pxKmsP4/M GFKdOYAHZpEH/vyIq4qHe+r8O0h/wfmbXnEA/4KO3eH45c/YKY64b8HDikXn/NEz0Qbbqe2jg TudoeyIHxXE4c3rPXttvpnw2154uN8j+CLwBUE7hGo31D3ndBbJKXLAtwpeNlwBdz0D1zZIDL 9tvSfHroS58nsogKcVEnxzZY7WqvaOw/G7/4R3n7Lon4/E4g0BaETpzGwRLwHixqeYZLmAZC0 s4Ei4W/vjsQS+BP/QUf8+YIF9OsKYw4/uzVm5JHXZAoJDriONa4Yec41LSgN9Xeky8/k81Kop roqvYYu/D3C5ESDUe58WIcM9ntndqgU166zhxENyF1cHQHhZ8uaS+h+rqtDpLD9veEO7lMs82 8DukIvT/dSWK2RdBMmwIqnKtFWntXXOy8qysnqmQn+nVGdT0C6n8owdsT5YAja5oEV2X0UiYm zVpBhsp03jM4588WxvwK/J82nBfVHwsqpQbyq2x+kgXioXJ0L7fcjkVYCA9sHbTy9bwKk/YBB GCknXDaRoYXQ1unbxeChmM58mJO4xyjJA54kz4w5eBMoQb77K1EsayzlF5Jn2XuCQIcxK/HTo m3v0fwgHplq/lmHrzqLEKEdwxcWQoWnLiTTAONqCnNyUkqjWzhRwQePC0r8PisipZE704vsVj RAY22svBP9HihRCK+AcAMu3ZrW7LaytbTlS/rYKKQnL+mbZIOleeKP/4opODIWqdr3PVbjTY X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:161036 Archived-At: Lars Ingebrigtsen writes: > I've now reapplied the patch, but restored the t check in the hook and > updated the comment. Fixed for me, thanks. > The doc string for `read-from-minibuffer' doesn't document the t value > for HISTORY at all -- perhaps that should also be fixed? It's also not hardcoded AFAIK. t is non-nil so Qminibuffer_history isn't substituted in `read-from-minibuffer', and it's not listp so `add-to-history' ignores it silently. AFAIU other values V with these properties would also work this way but still provoke the (wrong-type-argument listp V) error. Having some input not recorded in a history is a useful feature. IMHO this should be doable in an official way, and be documented. If we don't solve this here, I can also open a new report. Thanks, Michael.