bug#36186: 26.2.90; texinfmt: @uref{can't use @@ in its operand}

bug#36186: 26.2.90; texinfmt: @uref{can't use @@ in its operand}

[Katsumi Yamaoka]

[-- Attachment #1: Type: text/plain, Size: 714 bytes --]

Hi,

Here are two recipes:

(with-temp-buffer
  (insert "@setfilename test.info\n"
	  "@uref{https://www.example.com/, @@home page}\n")
  (texinfo-format-buffer))

(with-temp-buffer
  (insert "@setfilename test.info\n"
	  "@uref{mailto:foo@@example.com}")
  (texinfo-format-buffer))

The cause of both the errors is that the `texinfo-format-uref'
function moves point to the beginning of its formatted text,
texinfmt tries to format it again, and "@" (formatted "@@") is
treated as a command.

I'm not quite sure if there are things that should be formatted
again, but if it is not, it is unnecessary to go to the beginning
(a patch below).  Otherwise, the function must not format "@@" to
"@".

Thanks.
Regards,


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Type: text/x-patch, Size: 302 bytes --]

--- texinfmt.el~	2019-04-05 04:42:06.053686300 +0000
+++ texinfmt.el	2019-06-12 23:13:53.063255400 +0000
@@ -1294,4 +1294,3 @@
         (insert  (nth 1 args) " (" (nth 0 args) ")")
-      (insert "`" (nth 0 args) "'"))
-    (goto-char texinfo-command-start)))
+      (insert "`" (nth 0 args) "'"))))
 

bug#36186: 26.2.90; texinfmt: @uref{can't use @@ in its operand}

[Lars Ingebrigtsen]

Katsumi Yamaoka <yamaoka@jpl.org> writes:

> (with-temp-buffer
>   (insert "@setfilename test.info\n"
> 	  "@uref{mailto:foo@@example.com}")
>   (texinfo-format-buffer))
>
> The cause of both the errors is that the `texinfo-format-uref'
> function moves point to the beginning of its formatted text,
> texinfmt tries to format it again, and "@" (formatted "@@") is
> treated as a command.

Makes sense.  I've now applied your patch to the trunk and checked that
the .info files are generated without any warnings.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no