all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Tassilo Horn <tsdh@gnu.org>
To: Lars Ingebrigtsen <larsi@gnus.org>
Cc: 34160@debbugs.gnu.org, emacs-devel@gnu.org
Subject: bug#34160: About commit bff64115a0ad081282e0f99305f41c8dd1917d67, bug#34160, json.el
Date: Fri, 02 Aug 2019 18:16:59 +0200	[thread overview]
Message-ID: <87imrfa6f8.fsf__2130.32445624179$1564762694$gmane$org@gnu.org> (raw)
In-Reply-To: <8736iljd31.fsf@gnu.org> (Tassilo Horn's message of "Thu, 01 Aug 2019 14:16:02 +0200")

Tassilo Horn <tsdh@gnu.org> writes:

Hi Lars,

>>> It can still be a bit improved in understandability and efficiency.
>>>
>>> 1. The function passed to replace-region-contents runs on the narrowed
>>>    buffer anyway, so no need to narrow it yourself.
>>>
>>> 2. It would be better to create a temporary buffer, json-read
>>>    repeatedly from the original buffer, json-encode/insert to the temp
>>>    one, and then return the temp buffer.
>>
>> Sounds like a good idea; please go ahead.
>
> Will do at the weekend.

Ok, I did it just now (10065010a6).  Seems to work very well.

Bye,
Tassilo





  reply	other threads:[~2019-08-02 16:16 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-21 17:46 bug#34160: json-pretty-print deletes everything after first JSON object Albert Heinle
2019-07-09 18:41 ` Lars Ingebrigtsen
2019-07-10  8:53   ` Glenn Morris
2019-07-10 11:24     ` Lars Ingebrigtsen
2019-07-31  7:39 ` About commit bff64115a0ad081282e0f99305f41c8dd1917d67, bug#34160, json.el Tassilo Horn
2019-07-31 15:38   ` bug#34160: " Eli Zaretskii
2019-07-31 18:40     ` Tassilo Horn
2019-07-31 18:48       ` Eli Zaretskii
2019-07-31 18:48       ` Eli Zaretskii
2019-07-31 18:40     ` Tassilo Horn
2019-07-31 15:38   ` Eli Zaretskii
2019-07-31 18:41   ` Lars Ingebrigtsen
2019-07-31 18:41   ` Lars Ingebrigtsen
2019-07-31 19:30     ` Tassilo Horn
2019-07-31 20:21       ` Lars Ingebrigtsen
2019-08-01  4:54         ` Tassilo Horn
2019-08-01  4:54         ` Tassilo Horn
2019-08-01 11:11           ` Lars Ingebrigtsen
2019-08-01 12:16             ` Tassilo Horn
2019-08-02 16:16               ` Tassilo Horn [this message]
2019-08-02 16:16               ` Tassilo Horn
2019-08-01 12:16             ` Tassilo Horn
2019-08-01 11:11           ` Lars Ingebrigtsen
2019-07-31 20:21       ` Lars Ingebrigtsen
2019-07-31 19:30     ` Tassilo Horn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='87imrfa6f8.fsf__2130.32445624179$1564762694$gmane$org@gnu.org' \
    --to=tsdh@gnu.org \
    --cc=34160@debbugs.gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=larsi@gnus.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.