From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Tassilo Horn Newsgroups: gmane.emacs.devel Subject: Re: bug#34160: About commit bff64115a0ad081282e0f99305f41c8dd1917d67, bug#34160, json.el Date: Fri, 02 Aug 2019 18:16:59 +0200 Message-ID: <87imrfa6f8.fsf@gnu.org> References: <87ef26ac17.fsf@gnu.org> <87a7cuvyg3.fsf@mouse.gnus.org> <16c4982bea8.27dc.69bc538c4644581689883e654f15bce0@gnu.org> <87v9vinefd.fsf@mouse.gnus.org> <877e7xjxjj.fsf@gnu.org> <87ef25nns3.fsf@mouse.gnus.org> <8736iljd31.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="76975"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: 34160@debbugs.gnu.org, emacs-devel@gnu.org To: Lars Ingebrigtsen Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Aug 02 18:17:30 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1htaFF-000JwL-Oq for ged-emacs-devel@m.gmane.org; Fri, 02 Aug 2019 18:17:29 +0200 Original-Received: from localhost ([::1]:36296 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1htaFE-0004pb-My for ged-emacs-devel@m.gmane.org; Fri, 02 Aug 2019 12:17:28 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:34975) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1htaEs-0004pO-VB for emacs-devel@gnu.org; Fri, 02 Aug 2019 12:17:07 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:41548) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1htaEs-0007hW-Oz; Fri, 02 Aug 2019 12:17:06 -0400 Original-Received: from auth2-smtp.messagingengine.com ([66.111.4.228]:52069) by fencepost.gnu.org with esmtpsa (TLS1.2:DHE_RSA_AES_256_CBC_SHA256:256) (Exim 4.82) (envelope-from ) id 1htaEr-0000bK-Gh; Fri, 02 Aug 2019 12:17:06 -0400 Original-Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailauth.nyi.internal (Postfix) with ESMTP id D181F21F5A; Fri, 2 Aug 2019 12:17:04 -0400 (EDT) Original-Received: from mailfrontend2 ([10.202.2.163]) by compute7.internal (MEProxy); Fri, 02 Aug 2019 12:17:04 -0400 X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduvddrleelgdejudcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufhffjgfkfgggtgesthdtredttdertdenucfhrhhomhepvfgrshhsihhl ohcujfhorhhnuceothhsughhsehgnhhurdhorhhgqeenucfkphepgeeirdektddrjedtrd dvheenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhrnhdomhgvshhmthhprghuthhh phgvrhhsohhnrghlihhthidqkeeijeefkeejkeegqdeifeehvdelkedqthhsughhpeepgh hnuhdrohhrghesfhgrshhtmhgrihhlrdhfmhenucevlhhushhtvghrufhiiigvpedt X-ME-Proxy: Original-Received: from thinkpad-t440p (p2e504619.dip0.t-ipconnect.de [46.80.70.25]) by mail.messagingengine.com (Postfix) with ESMTPA id 3C96B380075; Fri, 2 Aug 2019 12:17:03 -0400 (EDT) Mail-Followup-To: Lars Ingebrigtsen , 34160@debbugs.gnu.org, emacs-devel@gnu.org In-Reply-To: <8736iljd31.fsf@gnu.org> (Tassilo Horn's message of "Thu, 01 Aug 2019 14:16:02 +0200") X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:239139 Archived-At: Tassilo Horn writes: Hi Lars, >>> It can still be a bit improved in understandability and efficiency. >>> >>> 1. The function passed to replace-region-contents runs on the narrowed >>> buffer anyway, so no need to narrow it yourself. >>> >>> 2. It would be better to create a temporary buffer, json-read >>> repeatedly from the original buffer, json-encode/insert to the temp >>> one, and then return the temp buffer. >> >> Sounds like a good idea; please go ahead. > > Will do at the weekend. Ok, I did it just now (10065010a6). Seems to work very well. Bye, Tassilo