From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#30990: Should the byte compiler warn about :type mismatches? Date: Mon, 30 Sep 2019 17:45:39 +0200 Message-ID: <87imp9aiu4.fsf@gnus.org> References: <87woxu7rf8.fsf@gmail.com> <838sq8grak.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="254097"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: alex.branham@gmail.com, Stefan Kangas , 30990@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Sep 30 17:54:20 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iEy0A-0013y0-L4 for geb-bug-gnu-emacs@m.gmane.org; Mon, 30 Sep 2019 17:54:18 +0200 Original-Received: from localhost ([::1]:54130 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iEy09-0007Yv-2h for geb-bug-gnu-emacs@m.gmane.org; Mon, 30 Sep 2019 11:54:17 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:36032) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iExsJ-0001Wd-Ad for bug-gnu-emacs@gnu.org; Mon, 30 Sep 2019 11:46:13 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iExsF-000586-DR for bug-gnu-emacs@gnu.org; Mon, 30 Sep 2019 11:46:10 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:51430) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iExsA-00057E-Hl for bug-gnu-emacs@gnu.org; Mon, 30 Sep 2019 11:46:04 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iExsA-0002E0-Ep for bug-gnu-emacs@gnu.org; Mon, 30 Sep 2019 11:46:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 30 Sep 2019 15:46:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 30990 X-GNU-PR-Package: emacs Original-Received: via spool by 30990-submit@debbugs.gnu.org id=B30990.15698583467635 (code B ref 30990); Mon, 30 Sep 2019 15:46:02 +0000 Original-Received: (at 30990) by debbugs.gnu.org; 30 Sep 2019 15:45:46 +0000 Original-Received: from localhost ([127.0.0.1]:60251 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iExru-0001yl-1E for submit@debbugs.gnu.org; Mon, 30 Sep 2019 11:45:46 -0400 Original-Received: from quimby.gnus.org ([80.91.231.51]:56050) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iExrr-0001vo-Ia for 30990@debbugs.gnu.org; Mon, 30 Sep 2019 11:45:44 -0400 Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=marnie) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iExrn-000336-PO; Mon, 30 Sep 2019 17:45:42 +0200 In-Reply-To: (Robert Pluim's message of "Mon, 30 Sep 2019 13:49:28 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:167914 Archived-At: Robert Pluim writes: > (defcustom winner-boring-buffers-regexp nil > "`winner-undo' will not restore windows with buffers matching this reg= exp." > - :type 'string > + :type '(choice (string :tag "Regexp") > + (const :tag "Don't check" nil)) > :version "27.1") > > I=CA=BCm not sure those are worth fixing. I think fixing those would be a win. > I did spot what seem to be some genuine errors though (hmm, would > flymake-cc-command need a :version tag update as well? The existing > definition makes customize error out) [...] > - :type 'bool > + :type 'boolean etc. Looks good to me; please push. --=20 (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no