From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: "Basil L. Contovounesios" Newsgroups: gmane.emacs.bugs Subject: bug#26490: 25.1; package-buffer-info is incorrectly case-insensitive Date: Wed, 02 Oct 2019 00:54:38 +0100 Message-ID: <87imp8dnsx.fsf@tcd.ie> References: <751C9864-CA4C-47AC-9CBF-43C676D40B00@sanityinc.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="255586"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: 26490@debbugs.gnu.org, Steve Purcell To: Stefan Kangas Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Oct 02 03:57:35 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iFTtX-0014Nl-0j for geb-bug-gnu-emacs@m.gmane.org; Wed, 02 Oct 2019 03:57:35 +0200 Original-Received: from localhost ([::1]:50456 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iFTtT-0002xK-Ub for geb-bug-gnu-emacs@m.gmane.org; Tue, 01 Oct 2019 21:57:31 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:45690) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iFRz3-0008M3-L4 for bug-gnu-emacs@gnu.org; Tue, 01 Oct 2019 19:55:11 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iFRz0-00017B-4g for bug-gnu-emacs@gnu.org; Tue, 01 Oct 2019 19:55:07 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:54630) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iFRyv-00014y-W3 for bug-gnu-emacs@gnu.org; Tue, 01 Oct 2019 19:55:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iFRyv-0002YK-Sc for bug-gnu-emacs@gnu.org; Tue, 01 Oct 2019 19:55:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: "Basil L. Contovounesios" Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 01 Oct 2019 23:55:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 26490 X-GNU-PR-Package: emacs Original-Received: via spool by 26490-submit@debbugs.gnu.org id=B26490.15699740959796 (code B ref 26490); Tue, 01 Oct 2019 23:55:01 +0000 Original-Received: (at 26490) by debbugs.gnu.org; 1 Oct 2019 23:54:55 +0000 Original-Received: from localhost ([127.0.0.1]:35218 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iFRyp-0002Xw-8I for submit@debbugs.gnu.org; Tue, 01 Oct 2019 19:54:55 -0400 Original-Received: from mail-wm1-f41.google.com ([209.85.128.41]:33373) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iFRyk-0002Xc-Tc for 26490@debbugs.gnu.org; Tue, 01 Oct 2019 19:54:54 -0400 Original-Received: by mail-wm1-f41.google.com with SMTP id r17so3650915wme.0 for <26490@debbugs.gnu.org>; Tue, 01 Oct 2019 16:54:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd-ie.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=IB7isFdgeLEZ2y5biLVgRib+o3E3wvjQ7RI1H/P7/5M=; b=yF4nRhjV5NHZWn9hGiYSR0EmYZFggHZdciflaPSvdbXY5wj95GZJfHmip6FK7u62vf 41ug4O1OY+p9uuYpCvDKNzy2Q8/aYLP9IVRbqk1o3K1A9Lv6NRUNIE3sFNcjEPlQIrvx gvh5XVlPFZYyRKLW8K8/6RPPXcmC4qi90XFJAP5ZWoQ32KW0DDALMbkxNnR83HbBw/3n yhaAnKLQUMJbN0rXMibxP2mrj3OpQnDfirbukJojXStSQJqKWEMHIdkQyIEaY5T3LnP7 Spd1Q9+FwqskWopm9D18XGybfdVhf+RTHfTh2HZPOn0btjX9Q3WjIFVzfBVab4NYTpMz YADg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=IB7isFdgeLEZ2y5biLVgRib+o3E3wvjQ7RI1H/P7/5M=; b=Z6A6+9K4RF6p8QGcdlj6cetQh9rpjlBgJJM/5WlY496ci+fHfaXW5g8IwQGns+/kAr DZMLeXXwtWgUn1CZrFdjN5YZmiwmFdGHj5SClF2WUGIRJ3F6+p3MDVIe2a0fjmJerzb2 PS+PiG8qA8UvRaofx4p+9V78Ic7jxk2ouI1EJTlotKa5PEezKoaqN8/FfQ0ffPWxtz92 UhakIsaJURFRnxp9kKnW2MV5lt55JSb+sXedeZOAH5rqxmls4o7L7bQzd+HNREYPZls5 KQE6Vkdx8Z4r8Vtwvn7FdrI8daCXi+v9aq6dP+3CHLvYgbAlC3aRWOBo7lf9fgMEjP72 kGNQ== X-Gm-Message-State: APjAAAXeO4nkbTBoDYfRoV0b21YaZgNguv5+9wjaVCfZpeGyMBzd+WSm m4Xs+K/6+JPkifnunBUaihmPdw== X-Google-Smtp-Source: APXvYqxi4yc1kQ8hzzT+4dOHiI5o962tfnbPScqO6KGJiMvJz8zlSPdnJu7vhCJxJbOhFEgW3fnmdQ== X-Received: by 2002:a7b:cc97:: with SMTP id p23mr488112wma.154.1569974084905; Tue, 01 Oct 2019 16:54:44 -0700 (PDT) Original-Received: from localhost ([2a02:8084:20e2:c380:92bd:1bfd:38fc:fae2]) by smtp.gmail.com with ESMTPSA id d10sm5283131wma.42.2019.10.01.16.54.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 01 Oct 2019 16:54:43 -0700 (PDT) In-Reply-To: (Stefan Kangas's message of "Sat, 28 Sep 2019 12:55:09 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:168108 Archived-At: Stefan Kangas writes: > I've attached a patch which I believe would do this in a reasonable way. Sorry, I haven't followed the discussion, but I have a minor nit: > diff --git a/lisp/emacs-lisp/package.el b/lisp/emacs-lisp/package.el > index ef0c5171de..5601e4d630 100644 > --- a/lisp/emacs-lisp/package.el > +++ b/lisp/emacs-lisp/package.el > @@ -1046,10 +1046,12 @@ package-buffer-info > (let ((file-name (match-string-no-properties 1)) > (desc (match-string-no-properties 2)) > (start (line-beginning-position))) > - ;; The terminating comment format could be extended to accept a > - ;; generic string that is not in English. > + ;; This warning was added in Emacs 27.1, and should be removed at > + ;; the earliest in version 31.1. The idea is to phase out the > + ;; requirement for a "footer line" without unduly impacting users > + ;; on earlier Emacs versions. See Bug#26490 for more details. > (unless (search-forward (concat ";;; " file-name ".el ends here")) > - (error "Package lacks a terminating comment")) > + (warn "Package lacks a terminating comment")) Shouldn't this be (lwarn 'package ...) or similar? (See, for example, the call to lwarn in package-initialize.) Thanks, -- Basil