From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#37518: [PATCH] Search upward from current dir for the default TAGS file Date: Mon, 07 Oct 2019 06:19:17 +0200 Message-ID: <87imp19ohm.fsf@gnus.org> References: Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="121219"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: 37518@debbugs.gnu.org To: Hong Xu Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Oct 07 06:20:12 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iHKVI-000VNG-6V for geb-bug-gnu-emacs@m.gmane.org; Mon, 07 Oct 2019 06:20:12 +0200 Original-Received: from localhost ([::1]:40506 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iHKVG-0007gJ-Ag for geb-bug-gnu-emacs@m.gmane.org; Mon, 07 Oct 2019 00:20:10 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:52313) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iHKVA-0007g7-7a for bug-gnu-emacs@gnu.org; Mon, 07 Oct 2019 00:20:05 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iHKV9-0001wt-2Z for bug-gnu-emacs@gnu.org; Mon, 07 Oct 2019 00:20:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:38349) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iHKV8-0001wk-Vi for bug-gnu-emacs@gnu.org; Mon, 07 Oct 2019 00:20:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iHKV8-0006IQ-N8 for bug-gnu-emacs@gnu.org; Mon, 07 Oct 2019 00:20:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 07 Oct 2019 04:20:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 37518 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 37518-submit@debbugs.gnu.org id=B37518.157042196624150 (code B ref 37518); Mon, 07 Oct 2019 04:20:02 +0000 Original-Received: (at 37518) by debbugs.gnu.org; 7 Oct 2019 04:19:26 +0000 Original-Received: from localhost ([127.0.0.1]:47170 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iHKUX-0006HS-Q8 for submit@debbugs.gnu.org; Mon, 07 Oct 2019 00:19:26 -0400 Original-Received: from quimby.gnus.org ([80.91.231.51]:55798) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iHKUV-0006HJ-4V for 37518@debbugs.gnu.org; Mon, 07 Oct 2019 00:19:24 -0400 Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=marnie) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iHKUQ-0005Zv-B9; Mon, 07 Oct 2019 06:19:22 +0200 In-Reply-To: (Hong Xu's message of "Thu, 26 Sep 2019 02:52:30 -0700") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:168493 Archived-At: Hong Xu writes: > * lisp/progmodes/etags.el (tags--find-default-tags-dir) > (tags--find-default-tags-dir-impl, visit-tags-table): Search > upward from current dir for the default TAGS file Sounds good. Some minor comments: [...] > +(defun tags--find-default-tags-dir-impl (current-dir) We don't really call functions for "-impl" or the like -- as this recurses upwards, what about calling it something more descriptive like `tags--find-default-tags-dir-recursively'? [...] > +(defun tags--find-default-tags-dir () > + "Find the directory that hosts the default TAGS file. > +It is the first directory that contains a file named TAGS encountered > +searching upward from `default-directory'." > + (let ((default-tag-dir > + (tags--find-default-tags-dir-impl default-directory))) > + (if default-tag-dir > + default-tag-dir > + default-directory))) This is basically (or (tags--find-default-tags-dir-impl default-directory) default-directory) so I don't think this intermediary function is needed. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no