From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#34448: --no-build-details means system-name is nil Date: Thu, 10 Oct 2019 00:26:53 +0200 Message-ID: <87imoxzhaq.fsf@gnus.org> References: Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="6173"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: 34448@debbugs.gnu.org To: Glenn Morris Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Oct 10 00:27:20 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iIKQJ-0001Gd-NQ for geb-bug-gnu-emacs@m.gmane.org; Thu, 10 Oct 2019 00:27:11 +0200 Original-Received: from localhost ([::1]:60538 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iIKQI-00026I-Jl for geb-bug-gnu-emacs@m.gmane.org; Wed, 09 Oct 2019 18:27:10 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:57443) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iIKQB-00024S-R4 for bug-gnu-emacs@gnu.org; Wed, 09 Oct 2019 18:27:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iIKQA-0000as-ML for bug-gnu-emacs@gnu.org; Wed, 09 Oct 2019 18:27:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:45559) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iIKQA-0000am-J6 for bug-gnu-emacs@gnu.org; Wed, 09 Oct 2019 18:27:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iIKQA-0006K3-E6 for bug-gnu-emacs@gnu.org; Wed, 09 Oct 2019 18:27:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 09 Oct 2019 22:27:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 34448 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: confirmed Original-Received: via spool by 34448-submit@debbugs.gnu.org id=B34448.157066001924293 (code B ref 34448); Wed, 09 Oct 2019 22:27:02 +0000 Original-Received: (at 34448) by debbugs.gnu.org; 9 Oct 2019 22:26:59 +0000 Original-Received: from localhost ([127.0.0.1]:54380 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iIKQ7-0006Jk-7g for submit@debbugs.gnu.org; Wed, 09 Oct 2019 18:26:59 -0400 Original-Received: from quimby.gnus.org ([80.91.231.51]:45848) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iIKQ4-0006Jb-UX for 34448@debbugs.gnu.org; Wed, 09 Oct 2019 18:26:57 -0400 Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=marnie) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iIKQ1-0005PQ-CD; Thu, 10 Oct 2019 00:26:55 +0200 In-Reply-To: (Glenn Morris's message of "Mon, 11 Feb 2019 20:54:32 -0500") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:168813 Archived-At: Glenn Morris writes: > emacs -Q --no-build-details > > then (system-name) returns nil. I expect this switch to only affect the > values stored in the Emacs binary, not the run-time result. Yup. It seems like this was the intention here: void init_system_name (void) { if (!build_details) { /* Set system-name to nil so that the build is deterministic. */ Vsystem_name = Qnil; return; } which is called from static void init_and_cache_system_name (void) { init_system_name (); cached_system_name = Vsystem_name; } which is called from DEFUN ("system-name", Fsystem_name, Ssystem_name, 0, 0, 0, doc: /* Return the host name of the machine you are running on, as a string. */) (void) { if (EQ (Vsystem_name, cached_system_name)) init_and_cache_system_name (); return Vsystem_name; Is --no-build-details just meant to be used during builds? If so, we can just document that, I guess? -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no