all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Adam Porter <adam@alphapapa.net>
To: emacs-orgmode@gnu.org
Subject: Re: [PATCH] org: org-get-priority: reduce `not`, deduplicate magic `(* 1000 ..)` operation
Date: Wed, 09 Oct 2019 14:33:06 -0500	[thread overview]
Message-ID: <87imoxr9xp.fsf@alphapapa.net> (raw)
In-Reply-To: 2458361570573406@sas8-93eeb7dac565.qloud-c.yandex.net

Hi Anton, Nicolas, et al,

I'm in favor of tidying up the priority-related code, as I also have
found it hard to follow.

But please do not change the API of these functions, i.e. the signatures
and return values.  Their output is used in other packages, including
some of mine like org-rifle, org-super-agenda, and org-ql.  If the API
were to change, it would create significant headaches in writing
compatibility code for different Org versions.

I can't easily tell if that's something that's been proposed, but I'm
making the request just in case.

Thanks,
Adam

  reply	other threads:[~2019-10-09 19:33 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-29  0:34 [PATCH] org: org-get-priority: reduce `not`, deduplicate magic `(* 1000 ..)` operation Anton Latukha
2019-10-08  9:25 ` Nicolas Goaziou
2019-10-08 21:28   ` Anton Latukha
2019-10-08 22:23     ` Anton Latukha
2019-10-09 19:33       ` Adam Porter [this message]
2019-10-10  2:25         ` Samuel Wales
2019-10-10 12:47       ` Nicolas Goaziou
2019-10-10 14:24         ` Anton Latukha

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87imoxr9xp.fsf@alphapapa.net \
    --to=adam@alphapapa.net \
    --cc=emacs-orgmode@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.