From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= Newsgroups: gmane.emacs.devel Subject: Re: master e21a1da: Allow completion styles to adjust completion metadata Date: Sat, 26 Oct 2019 23:03:37 +0100 Message-ID: <87imobxiyu.fsf@gmail.com> References: <20191026132223.21074.15227@vcs0.savannah.gnu.org> <20191026132224.B05E120664@vcs0.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="86310"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Oct 27 00:04:02 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iOUAC-000MJB-RN for ged-emacs-devel@m.gmane.org; Sun, 27 Oct 2019 00:04:00 +0200 Original-Received: from localhost ([::1]:42908 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iOUAB-0007zE-3a for ged-emacs-devel@m.gmane.org; Sat, 26 Oct 2019 18:03:59 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:35361) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iOU9v-0007pM-7n for emacs-devel@gnu.org; Sat, 26 Oct 2019 18:03:44 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iOU9u-0007Jm-7e for emacs-devel@gnu.org; Sat, 26 Oct 2019 18:03:43 -0400 Original-Received: from mail-wm1-x32b.google.com ([2a00:1450:4864:20::32b]:33342) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iOU9t-0007JI-W0 for emacs-devel@gnu.org; Sat, 26 Oct 2019 18:03:42 -0400 Original-Received: by mail-wm1-x32b.google.com with SMTP id 6so6802338wmf.0 for ; Sat, 26 Oct 2019 15:03:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=Eb75zl+sgdS6vHNk0Pf6Yaj40zJtAfst5DB/PdqICdY=; b=eMPbGofH/RpECZtk5Xvj+wfxC3Z9RSOpvuFgAtHWMJcwDRxsKL6+tgt+on/hZXB7gF hbHwWiHDeotnyfeKQBU3qw8LWTkbkbltXA2MrbgYoj9qUWT1IP/qveGSe/lhDkHmBwfq +vfi/elOkRX1XfUrM6p89CViN2FfKCvDo2NIQtpFWYj8ZQA1i6QsiSl3PcIgtc+rDKqu 8nM5Fu6uFK6gHH6en05/qMN1ZUaKfwo9SLYDuFMeqxnUYaSljf9+OpS7KD5TpkuvzDDl GTSuU31qaa2tEUtxh1+5NlHvlY/PubSE3YF/Fg6/mdNBlwNg36T0/WBL3/Go0D8Dts6N diFQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=Eb75zl+sgdS6vHNk0Pf6Yaj40zJtAfst5DB/PdqICdY=; b=BaX7wKnErOyYoEpsJ2QMx+bReZcFssVEjEvNQnhrr68LlDk8WkZe153LHkcjSpKGBp 4B76XmJcln5olYGdkUMPVqyxaQwGF+e9UDmN+Vsqi/7lb5Cu3iXnHytliKqnHKNOZpF/ 2svNeSLaek2oKnrS+PjV1N/1CxdqR8whr6ORjQYPDO7oJ+K76ZnNKno5Tj+eCznGlq7k 5GjeVjsG53Qe2DbUlAroXt9hrk3PqUC1kkoAM9W9sl9UFPMgwkpBa3B2qYKqoumqKaMF CXxICM7u/RExNyYJtDLZFmEMVwRgFRsA6LyxUzrbon4Y1Vw+41jveQodm0Pg+41Xd0qe NoOg== X-Gm-Message-State: APjAAAUlYPP/VVCo++DLbEZy7jmh2uQyWctRGNiu3GjDsxKGBiMkJCbt UI64RAGrJlB+dNiofioKzz0F1eswSGI= X-Google-Smtp-Source: APXvYqzQCg9d5M11EJ3G8UK5dIEPEMQN44hQ5PLb3PwxrJshj9K6byjDDc+Bj9MLGrt2Ut/diPy+pQ== X-Received: by 2002:a1c:3c43:: with SMTP id j64mr7656025wma.13.1572127420139; Sat, 26 Oct 2019 15:03:40 -0700 (PDT) Original-Received: from lolita.yourcompany.com ([2001:818:d820:9500:1ebb:afd8:ab26:f0f6]) by smtp.gmail.com with ESMTPSA id u1sm8132476wru.90.2019.10.26.15.03.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 26 Oct 2019 15:03:39 -0700 (PDT) In-Reply-To: (Stefan Monnier's message of "Sat, 26 Oct 2019 16:52:45 -0400") X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::32b X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:241485 Archived-At: Stefan Monnier writes: >> + (when adjust-fn >> + (setcdr metadata (cdr (funcall adjust-fn metadata)))) > > Do we know that the `metadata` argument we received is always a cons > cells? I assumed it is. Do you know that it isn't? nil? BTW I hate this metadata object, I with there were proper writers/constructors that didn't assume anything about its cons-implementation. Perhaps I missed something. > BTW, I just changed the bootstrap so that cl-defgeneric should now be > usable in minibuffer.el. Out of energy right now. Be my guest, the switch to cl-generic is trivally outlined in the now-revert commit. Jo=C3=A3o