From: Sebastian Fieber <sebastian.fieber@web.de>
To: 40397@debbugs.gnu.org
Subject: bug#40397: 28.0.50; epg decrypt does not verify signed content in smime
Date: Fri, 03 Apr 2020 08:47:33 +0200 [thread overview]
Message-ID: <87imih5am2.fsf@web.de> (raw)
In-Reply-To: <87o8s9cvdr.fsf@web.de>
[-- Attachment #1: Type: text/plain, Size: 426 bytes --]
Hey there,
I just thought this may be hard to test as one has to have a smime
certificate to properly receive an encrypted mail.
If someone can point me to the right approach how to fix this I may be
able to dive a bit deeper into the gnus code and submit a bug report.
This is what I have tried now just to get something:
If I alter mm-view-pkcs7-decrypt after the insert epg-decrypt-string to
call something like this:
[-- Attachment #2: Type: application/emacs-lisp, Size: 63 bytes --]
[-- Attachment #3: Type: text/plain, Size: 59 bytes --]
and adjust mm-view-pkcs7-get-type to handle a third case
[-- Attachment #4: Type: application/emacs-lisp, Size: 90 bytes --]
[-- Attachment #5: Type: text/plain, Size: 70 bytes --]
and also mm-copy-to-buffer to check for carriage returns like this:
[-- Attachment #6: Type: application/emacs-lisp, Size: 43 bytes --]
[-- Attachment #7: Type: text/plain, Size: 627 bytes --]
(can't send the carriage return properly so \r it is here instead of ^M)
I am able to get an article buffer that still has the base64 encoded
signed blob in it but after it the verified content.
I have no idea where gnus normalizes the line endings to just newlines
and why the mm-view-pkcs7-get-type adjustment is needed. But calling
gnus-ime-display-part is of course not the right approach here. First
there should be some check if the decrypted content needs to be parsed
and handled again but I have no idea which function to write or feed the
decrypted content to.
I hope this may be helpful
Best regards
Sebastian
next prev parent reply other threads:[~2020-04-03 6:47 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-02 23:37 bug#40397: 28.0.50; epg decrypt does not verify signed content in smime encrypted and signed message Sebastian Fieber
2020-04-03 6:47 ` Sebastian Fieber [this message]
2020-04-03 23:22 ` bug#40397: 28.0.50; epg decrypt does not verify signed content in smime Sebastian Fieber
2020-04-05 0:37 ` Sebastian Fieber
2020-04-06 0:04 ` Sebastian Fieber
2020-04-06 1:17 ` Noam Postavsky
2020-04-06 7:01 ` Sebastian Fieber
2020-04-06 16:32 ` Noam Postavsky
2020-04-07 19:22 ` Sebastian Fieber
2020-04-19 12:16 ` Noam Postavsky
2020-08-02 6:02 ` Lars Ingebrigtsen
2020-08-02 20:11 ` Sebastian Fieber
2020-08-03 2:26 ` Eli Zaretskii
2020-08-03 6:06 ` Lars Ingebrigtsen
2021-07-21 15:41 ` bug#40397: 28.0.50; epg decrypt does not verify signed content in smime encrypted and signed message Lars Ingebrigtsen
2021-07-21 18:07 ` Sebastian Fieber
2021-07-21 22:02 ` Lars Ingebrigtsen
2021-12-21 19:39 ` Sebastian Fieber
2021-12-22 12:44 ` Lars Ingebrigtsen
2021-12-23 18:14 ` Sebastian Fieber
2021-12-23 18:17 ` Sebastian Fieber
2021-12-23 18:25 ` Sebastian Fieber
2021-12-23 21:06 ` Sebastian Fieber
2021-12-24 9:44 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87imih5am2.fsf@web.de \
--to=sebastian.fieber@web.de \
--cc=40397@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.