From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: "Basil L. Contovounesios" Newsgroups: gmane.emacs.bugs Subject: bug#40532: 28.0.50; eww/shr: Anchor link does not work Date: Mon, 04 May 2020 00:49:28 +0100 Message-ID: <87imhcefzr.fsf@tcd.ie> References: <87sghckn7p.fsf@milkypond.org> <87o8rk597f.fsf@milkypond.org> <87blnj92dy.fsf@tcd.ie> <83wo67eien.fsf@gnu.org> <87h7xbjzjh.fsf@tcd.ie> <83r1wfecoc.fsf@gnu.org> <838sij98im.fsf@gnu.org> <878sid4nn7.fsf@gnus.org> <87ees5z3cr.fsf@tcd.ie> <87ftckzkve.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="85504"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 40532@debbugs.gnu.org, arnau@mini-dweeb.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon May 04 01:50:13 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jVONB-000M9j-Hc for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 04 May 2020 01:50:13 +0200 Original-Received: from localhost ([::1]:41892 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jVONA-0004Rm-KI for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 03 May 2020 19:50:12 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:55328) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jVON0-0004R2-PP for bug-gnu-emacs@gnu.org; Sun, 03 May 2020 19:50:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:46940) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jVON0-0003R2-Fy for bug-gnu-emacs@gnu.org; Sun, 03 May 2020 19:50:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jVON0-0001k5-Dh for bug-gnu-emacs@gnu.org; Sun, 03 May 2020 19:50:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: "Basil L. Contovounesios" Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 03 May 2020 23:50:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 40532 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 40532-submit@debbugs.gnu.org id=B40532.15885497776660 (code B ref 40532); Sun, 03 May 2020 23:50:02 +0000 Original-Received: (at 40532) by debbugs.gnu.org; 3 May 2020 23:49:37 +0000 Original-Received: from localhost ([127.0.0.1]:58486 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jVOMb-0001jL-2g for submit@debbugs.gnu.org; Sun, 03 May 2020 19:49:37 -0400 Original-Received: from mail-wr1-f45.google.com ([209.85.221.45]:42421) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jVOMZ-0001j9-Rz for 40532@debbugs.gnu.org; Sun, 03 May 2020 19:49:36 -0400 Original-Received: by mail-wr1-f45.google.com with SMTP id s8so8508784wrt.9 for <40532@debbugs.gnu.org>; Sun, 03 May 2020 16:49:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd-ie.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=FKiot9iQlnIOrUxfCENXcWfVqhWvwD1BcD7WVl1JLgg=; b=mDp/3UUIC02GDKCwuNcOFqbouAg/KzD2wrGc9NHCyt5ZPB48Q/FV64gxDHCvw255mk GGoHyJNFj/YrrfEJ1SrOSapjwA9V8iTLNScI5SpteT1eOMXiD90kKvfQb4SoGagZ5CPw JtLfgFUrNTYLJMSsAbVZTkuetgAmqjaM1tkVLBh3QhuwQz/ZKOi/euHGmbfqonZPaTti ZIIhzugfyjT4zI/CPtSqPtLhq2Ex1KQqK3l9u+dW/D57d1kyp+QklQkFL82DzqjFyJ4/ YSWcAswX9wzQFnSjUH7XQST4PfyIZYl+nob6ULubtsoIv7ZmhWgKz5LzxaCbf+kIAeNS wfHg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=FKiot9iQlnIOrUxfCENXcWfVqhWvwD1BcD7WVl1JLgg=; b=sbck26NXyN9NUhh9J6T/SPEwB7m0MpBSwHRfRFisoTudW1az0wXa/GY0IDCVFRXfTk C+AjihqbNgvuCKYI7Cd4ClaZ5Pb5Ur1O+Dun3Y9wUW689i9cnA93klY+NuVz1Rnp8hww JEWLThAEBhk9rh24GYugowuVYQyOBqjVSYEWseq/hHTLUDAIW74RjRWKykqBBUY80hAg XaRH3fJJiNRFFMN3+xHQRM+R1a8MTos/PLpoVwtSOYkN0cSuAsUojND6R6+spS4Vubtn u8yayEnWF3cDmPlr8gbeCoHy1ksK2UNTnbSNyKbWjKnL43PXe4gt305Rb8hGpo4YQxpO +I5Q== X-Gm-Message-State: AGi0PuYgOAPlX9mYH14zLsplYd3FUHoTEg+fpL+0Tz2OYX0Sll+4Ue1N RQBlt0JJOIvfVQxuS7VqvYMMJw== X-Google-Smtp-Source: APiQypLfC89/eS0vQ73HUeB2nKLGrZ/0e1EEF2PcUp6K0VBb9Hmc6Ea2GJrWtpbB/8cZJnmaIiV/jQ== X-Received: by 2002:adf:cd12:: with SMTP id w18mr12126837wrm.341.1588549770005; Sun, 03 May 2020 16:49:30 -0700 (PDT) Original-Received: from localhost ([2a02:8084:20e2:c380:1f68:7ff5:120d:64e]) by smtp.gmail.com with ESMTPSA id g69sm11656343wmg.17.2020.05.03.16.49.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 03 May 2020 16:49:29 -0700 (PDT) In-Reply-To: <87ftckzkve.fsf@gnus.org> (Lars Ingebrigtsen's message of "Fri, 01 May 2020 00:09:25 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:179645 Archived-At: Lars Ingebrigtsen writes: > "Basil L. Contovounesios" writes: > >> Why not move this binding back into eww-display-html instead, closer to >> where shr-insert-document is called, for the benefit of other callers of >> eww-display-html as well, and deviating the least from previous versions >> of eww, as per the second proposed patch? > > Sorry, I missed that patch. That looks even more logical to me. Thanks, pushed to emacs-27: Fix eww-follow-link on URLs with #target 310112fdc7 2020-05-04 00:40:38 +0100 https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=310112fdc7448a9297085333fcd4bf4088e634bf But unless I hear otherwise I'll hold off from closing this bug until I can look more into the relative #target issue tomorrow. -- Basil