From: "João Távora" <joaotavora@gmail.com>
To: "Basil L. Contovounesios" <contovob@tcd.ie>
Cc: darthandrus@gmail.com, 40693@debbugs.gnu.org,
Dmitry Gutov <dgutov@yandex.ru>
Subject: bug#40693: 28.0.50; json-encode-alist changes alist
Date: Thu, 21 May 2020 23:16:30 +0100 [thread overview]
Message-ID: <87imgp2atd.fsf@gmail.com> (raw)
In-Reply-To: <87367t9ej7.fsf@tcd.ie> (Basil L. Contovounesios's message of "Thu, 21 May 2020 22:14:20 +0100")
"Basil L. Contovounesios" <contovob@tcd.ie> writes:
> The declarations are needed because the byte-compiler does not know that
> loading json.el will e.g. define a dynamically bound variable
> json-object-type and a nullary function symbol json-read. It therefore
> not only complains but also generates invalid byte-code.
Basil, I understand the need for the declarations, but I was suggesting
something different. This, at the top, near all the other requires.
(eval-and-compile
(unless (fboundp 'json-parse-buffer)
(require 'json)))
and then do the defalias without the declarations below.
(defalias blabla
(if (fboundp 'json-parse-buffer)
(lambda () json-c-things...)
(lambda () json-el-things...)))
Am I missing something or doesn't this work like you want? We're
checking json.c function thrice instead of twice, but doesn't seem very
bad, only a 50% increase :-)
> But I find this more heavy handed and intrusive, since it
> unconditionally loads json.el during byte-compilation, even when
> json-parse-buffer is available.
I think the snippet above doesn't have this problem.
Anyway, this is a minor nitpick, push whatever you think is better.
João
next prev parent reply other threads:[~2020-05-21 22:16 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-18 2:59 bug#40693: 28.0.50; json-encode-alist changes alist Ivan Andrus
2020-04-18 17:29 ` Dmitry Gutov
2020-04-18 21:00 ` Ivan Andrus
2020-04-18 23:13 ` Michael Heerdegen
2020-04-19 0:10 ` Dmitry Gutov
2020-04-19 0:29 ` Michael Heerdegen
2020-04-19 0:33 ` Basil L. Contovounesios
2020-04-19 0:34 ` Basil L. Contovounesios
2020-04-29 10:11 ` Basil L. Contovounesios
2020-04-29 10:30 ` Eli Zaretskii
2020-04-29 12:08 ` Dmitry Gutov
2020-04-29 12:21 ` Eli Zaretskii
2020-04-29 14:28 ` Dmitry Gutov
2020-04-29 14:40 ` Eli Zaretskii
2020-04-29 15:02 ` Dmitry Gutov
2020-04-29 15:07 ` Eli Zaretskii
2020-04-29 14:41 ` Basil L. Contovounesios
2020-05-18 1:24 ` Basil L. Contovounesios
2020-05-18 14:27 ` Eli Zaretskii
2020-05-18 22:50 ` Dmitry Gutov
2020-05-18 23:50 ` João Távora
2020-05-21 21:14 ` Basil L. Contovounesios
2020-05-21 22:16 ` João Távora [this message]
2020-05-22 14:54 ` Basil L. Contovounesios
2020-05-22 20:14 ` João Távora
2020-05-23 16:13 ` Basil L. Contovounesios
2020-05-23 19:40 ` João Távora
2020-05-23 22:41 ` Basil L. Contovounesios
2020-05-23 22:45 ` João Távora
2020-04-19 20:35 ` Paul Eggert
2020-04-19 21:01 ` Drew Adams
2020-04-19 22:14 ` Paul Eggert
2020-04-19 22:29 ` Michael Heerdegen
2020-04-19 23:59 ` Paul Eggert
2020-04-20 0:25 ` Michael Heerdegen
2020-04-20 0:32 ` Paul Eggert
2020-04-20 0:57 ` Michael Heerdegen
2020-04-20 2:55 ` Paul Eggert
2020-04-20 14:56 ` Eli Zaretskii
2020-04-20 5:45 ` Drew Adams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87imgp2atd.fsf@gmail.com \
--to=joaotavora@gmail.com \
--cc=40693@debbugs.gnu.org \
--cc=contovob@tcd.ie \
--cc=darthandrus@gmail.com \
--cc=dgutov@yandex.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.