From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#41200: Displaying a tooltip with x-show-tip gets very slow as more faces are defined Date: Mon, 08 Jun 2020 03:21:58 +0300 Organization: LINKOV.NET Message-ID: <87img2z9sp.fsf@mail.linkov.net> References: <8fd8896a-cd5c-66f4-4792-f65cac4dc4f5@gmail.com> <83lflx896q.fsf@gnu.org> <837dxd31cb.fsf@gnu.org> <789d786d-a07a-65c1-c0e4-433e4c18d64e@gmail.com> <835zcxgrby.fsf@gnu.org> <833681glas.fsf@gnu.org> <53252e93-085c-477f-21df-c909082dffc2@gmail.com> <87367z324f.fsf@mail.linkov.net> <3fc34671-54ba-e83d-9514-11e0906c2ac0@gmail.com> <87lflqkznj.fsf@mail.linkov.net> <87zha3d29k.fsf@mail.linkov.net> <83a71z135p.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="82162"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu) Cc: cpitclaudel@gmail.com, 41200@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Jun 08 02:24:10 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ji5aD-000LHI-Sg for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 08 Jun 2020 02:24:09 +0200 Original-Received: from localhost ([::1]:37818 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ji5aC-0007lr-RV for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 07 Jun 2020 20:24:08 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:56720) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ji5a6-0007lj-KQ for bug-gnu-emacs@gnu.org; Sun, 07 Jun 2020 20:24:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:43709) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ji5a6-0002zE-Ad for bug-gnu-emacs@gnu.org; Sun, 07 Jun 2020 20:24:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ji5a6-0003g9-6u for bug-gnu-emacs@gnu.org; Sun, 07 Jun 2020 20:24:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 08 Jun 2020 00:24:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 41200 X-GNU-PR-Package: emacs Original-Received: via spool by 41200-submit@debbugs.gnu.org id=B41200.159157579014081 (code B ref 41200); Mon, 08 Jun 2020 00:24:02 +0000 Original-Received: (at 41200) by debbugs.gnu.org; 8 Jun 2020 00:23:10 +0000 Original-Received: from localhost ([127.0.0.1]:55255 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ji5ZG-0003f1-HM for submit@debbugs.gnu.org; Sun, 07 Jun 2020 20:23:10 -0400 Original-Received: from relay11.mail.gandi.net ([217.70.178.231]:38983) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ji5ZE-0003em-G6 for 41200@debbugs.gnu.org; Sun, 07 Jun 2020 20:23:09 -0400 Original-Received: from mail.gandi.net (m91-129-108-6.cust.tele2.ee [91.129.108.6]) (Authenticated sender: juri@linkov.net) by relay11.mail.gandi.net (Postfix) with ESMTPSA id 59528100006; Mon, 8 Jun 2020 00:23:00 +0000 (UTC) In-Reply-To: <83a71z135p.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 23 May 2020 11:11:46 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:181722 Archived-At: >> >>> + :group 'basic-faces) >> >>> + :group 'basic-faces) >> >>> >> >>> - :group 'tab-bar-faces) >> >>> - :group 'tab-line-faces) >> >> >> >> Could these faces belong to both groups? >> >> >> >> :group 'basic-faces >> >> :group 'tab-bar-faces >> > >> > Yup, but that won't work well if the face is customized before the >> > group is defined, right? Maybe the trick would be to add the group to >> > the face when tab-bar.el and tab-line.el are loaded? >> >> Actually since tab-bar.el is pre-loaded this problem exists only for >> tab-line.el. >> >> Then adding something like >> >> (nconc (get 'tab-line-faces 'custom-group) '((tab-line custom-face) ...)) >> >> to tab-line.el will add faces when tab-line.el are loaded. > > Could you guys please finalize these issues? I'd like to install > these changes on master, for which I'd need a patch that covers both > the changes in the face storage and the fix for the tab-line face. > > Actually, the problem with the tab-line face will probably need to be > fixed on emacs-27. I never used the second argument MEMBERS of 'defgroup', but it's exactly what is needed. Now the problem with the tab-line face is fixed on emacs-27 in commit 6eb18a950d.