From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: "Basil L. Contovounesios" Newsgroups: gmane.emacs.bugs Subject: bug#41890: 28.0.50; [PATCH]: Add bindings for project.el Date: Tue, 16 Jun 2020 21:31:53 +0100 Message-ID: <87imfqoipy.fsf@tcd.ie> References: <87blljbarq.fsf@thornhill.no> <83pn9z13xq.fsf@gnu.org> <87lfknklj8.fsf@thornhill.no> <83h7vb0w3u.fsf@gnu.org> <87ftaulxzr.fsf@thornhill.no> <87r1ueri7m.fsf@tcd.ie> <87imfqn829.fsf@thornhill.no> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="94234"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 41890@debbugs.gnu.org To: Theodor Thornhill Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Jun 16 22:33:13 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jlIGe-000OPG-Lc for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 16 Jun 2020 22:33:12 +0200 Original-Received: from localhost ([::1]:36834 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jlIGd-00031K-Iu for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 16 Jun 2020 16:33:11 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:58122) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jlIGU-0002zK-Ag for bug-gnu-emacs@gnu.org; Tue, 16 Jun 2020 16:33:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:38161) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jlIGU-00082w-14 for bug-gnu-emacs@gnu.org; Tue, 16 Jun 2020 16:33:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jlIGT-0002rT-TG for bug-gnu-emacs@gnu.org; Tue, 16 Jun 2020 16:33:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: "Basil L. Contovounesios" Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 16 Jun 2020 20:33:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 41890 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 41890-submit@debbugs.gnu.org id=B41890.159233952310935 (code B ref 41890); Tue, 16 Jun 2020 20:33:01 +0000 Original-Received: (at 41890) by debbugs.gnu.org; 16 Jun 2020 20:32:03 +0000 Original-Received: from localhost ([127.0.0.1]:49706 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jlIFX-0002qJ-EF for submit@debbugs.gnu.org; Tue, 16 Jun 2020 16:32:03 -0400 Original-Received: from mail-wm1-f53.google.com ([209.85.128.53]:39394) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jlIFV-0002pp-BU for 41890@debbugs.gnu.org; Tue, 16 Jun 2020 16:32:02 -0400 Original-Received: by mail-wm1-f53.google.com with SMTP id t194so4429917wmt.4 for <41890@debbugs.gnu.org>; Tue, 16 Jun 2020 13:32:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd-ie.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=Sop1lJOs0TayUuuDGKc3ZV4shMu6psJNIJBHt1tmlgo=; b=Vva5a4l3Tq9hkreWnu4Y9k3aVDow+GczktZdfMtx06TjhzPdCQgLRcUP0v4F7A38U2 qVexPwnJAoRgV5hDo3g2pX96j20U75ZkWkE977U317HeYrmyqxqgfnuAW8xAto0ppHB+ tXD73HNSA3tZFF6OEUDQbvalZwXASMFWKSLllHYKJGuz092EBENO+a/L188ppvqgPWuI zppCXsCcki3s99QKbgUsDf2dOucCkuZWQSC3r61nd77YoXiucDtdiVenOya4Rb6L0Xx9 +rrciDNjZPTsl9QlcV0NkEDUcFnAZB7T06tUf2aS2wiiC8jZCorPLq9VLXGU+z+bzgiU RZRA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=Sop1lJOs0TayUuuDGKc3ZV4shMu6psJNIJBHt1tmlgo=; b=HznFXzQgLeNpuuvlM1SnugIU8/vGfOWJUSRl7XrpyNPRFgUv2Ue3D0/JargDFAdReS QPH9FZA8XDYU6KFTw/kNAbk3ySB+09BMoXMk6eBeSJAtfAY28K+KW4jUdRhYEOtBvRgu HneCgVc4cNqY3qFVS21rXxOde1OMIQDLS7UjhBj7kWpvA7vwO6V7Z2deMpA517n0+1gw FgIc6eGWL7NeR+bhRkNbYhvAPilhV8u4mcADMp3d8YoPM1tjjN1rXyQxzZEWAuYZsFiH 0QNNVcl03DfUw8FvE4B77HyVOvWNlznzSzURz0uVCDR7bTU6CI1XNZXwsJo5i5nNdKbt Fqew== X-Gm-Message-State: AOAM5322TsVGv4DNWeZ46BWr6A8e08vX/XL9U9DYDpwWLuv9x8xmKlOj ehMMWb3T+Ic3iFhXtHgPQIYybw== X-Google-Smtp-Source: ABdhPJyJ+GUG8owf2yJqsaxPsym/1uwGI09Cx+r9qr5pFGfmbw9M/He1ZIZXVkRZUdNb7w3FM6jXYg== X-Received: by 2002:a7b:cbd9:: with SMTP id n25mr4902358wmi.30.1592339515204; Tue, 16 Jun 2020 13:31:55 -0700 (PDT) Original-Received: from localhost ([2a02:8084:20e2:c380:92bd:1bfd:38fc:fae2]) by smtp.gmail.com with ESMTPSA id b143sm5401178wme.20.2020.06.16.13.31.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 16 Jun 2020 13:31:54 -0700 (PDT) In-Reply-To: <87imfqn829.fsf@thornhill.no> (Theodor Thornhill's message of "Tue, 16 Jun 2020 19:07:32 +0000") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:182044 Archived-At: Theodor Thornhill writes: >> This should be: >> >> (defvar project-prefix-map >> (let ((map (make-sparse-keymap))) >> (define-key map ...) >> ... >> map) >> "...") >> >> (define-key ctl-x-map "p" project-prefix-map) >> >> See the end of (info "(elisp) Tips for Defining"). >> >> Maybe it should also be autoloaded. > > Below is another patch with your suggestions incorporated. Is it correct to also > autoload the (define-key ctl-x-map "p" project-prefix-map)? I'm not an autoload expert, so I'd appreciate if someone else chimed in, but according to the commentary in lisp/bookmark.el, ;;;###autoload (define-key ...) is preferable to ;;;###autoload (define-key ...) since the former is copied to lisp/ldefs-boot.el at build time and skipped at load time (since it's in a comment), so it doesn't override existing user settings. Would that do what we want? Thanks, -- Basil