From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= Newsgroups: gmane.emacs.devel Subject: Re: Byte-compilation warning in eldoc.el Date: Fri, 10 Jul 2020 22:48:57 +0100 Message-ID: <87imevdos6.fsf@gmail.com> References: <83k0zbq2sd.fsf@gnu.org> <874kqfg7ju.fsf@gmail.com> <87v9ive69l.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="10903"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: Eli Zaretskii , emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Jul 10 23:49:39 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ju0tn-0002m4-Cw for ged-emacs-devel@m.gmane-mx.org; Fri, 10 Jul 2020 23:49:39 +0200 Original-Received: from localhost ([::1]:45078 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ju0tm-000666-FE for ged-emacs-devel@m.gmane-mx.org; Fri, 10 Jul 2020 17:49:38 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:58548) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ju0tE-0005g1-TL for emacs-devel@gnu.org; Fri, 10 Jul 2020 17:49:04 -0400 Original-Received: from mail-wr1-x434.google.com ([2a00:1450:4864:20::434]:37837) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ju0tC-0005cj-KV; Fri, 10 Jul 2020 17:49:04 -0400 Original-Received: by mail-wr1-x434.google.com with SMTP id a6so7296495wrm.4; Fri, 10 Jul 2020 14:49:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=F/OatgEUn/eVaKB/Ld35G4rRdhpSU+/WHsU6xnX6ejg=; b=ll4zrcjQlUoPbDiGbsgDfByEDamzVqozcLKYmrza5Xrkwdp0Sd/agILhFxB6ri/kP1 XLVKO/wqiJj+6KZkHKx9uVZc4gtDoTfc7W6ZGS3E2BLM88X81RW863xaSi9+fj5zO3tc MwXT9TEFFSs+avTYNRsdVcSMC5Zq1YpJLcviL+mhem/JsDnro1SMkvXaErOSBoqwTiPG ptzqwY38tpX5Icd6UyRCPLWGRd3XXn+ekCDrGqgZiUU21F2Jqv5y3I2IExHS9cGMJU8L oqlQyRHaZzBs4rIJ3u3Muzhx15X3Qj9paCPGWXGJTBwYghJXMDSvQhjnsrnVE7JsQeXo hs2Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=F/OatgEUn/eVaKB/Ld35G4rRdhpSU+/WHsU6xnX6ejg=; b=lB8w5pPYD3ts4B74PaY7Zu8IJ+Y/9WY+cH9EKpHm8FVEANU+HqAxqUpU9Ou1SvctTl HDTRjZ+1jxt5daZv2AsZWvke9ekUil2dc3v8anwCncg0nJWK241v0liUlTVTxIJbIFMz 3DkMX4sRAECS6XuKyXEC+DXyjmmssT2EsT9XDe2UqzIsG40EJ24P/BxYDYWE+GWYV7AS TPI+b0Gtx1yEyRXe6tN3c1kn8IBLUjI+uHHY5iTEfXsiaHl3B1vNqLinwtZRYSoO4+3i KHdUDY1h6ciDT77oQAqpXQic7zN+k5qJ0tgKFrJcMH8ySWxNJ+uLTc9h4/Z1kNtnGVh3 SQCA== X-Gm-Message-State: AOAM531pNJ9rxPhcpCsWSNks0c2OudaKYVrLewVNbp5Vjmu4Tcx1/n1U rfnnjtduKtdd+d8OKQ7DmZw4bVqu X-Google-Smtp-Source: ABdhPJzxg4mBHRB9k88UFPP+PMB9sQd1nk+eQd5qC/sRFiIHGiQ/uFQdkQbpiyXvT8CmSgRHDesFTA== X-Received: by 2002:a5d:5388:: with SMTP id d8mr68525121wrv.35.1594417740257; Fri, 10 Jul 2020 14:49:00 -0700 (PDT) Original-Received: from krug ([2001:818:d820:9500:824a:171:15a:2213]) by smtp.gmail.com with ESMTPSA id w12sm12788148wrm.79.2020.07.10.14.48.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 10 Jul 2020 14:48:59 -0700 (PDT) In-Reply-To: (Stefan Monnier's message of "Fri, 10 Jul 2020 17:29:10 -0400") Received-SPF: pass client-ip=2a00:1450:4864:20::434; envelope-from=joaotavora@gmail.com; helo=mail-wr1-x434.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:252843 Archived-At: Stefan Monnier writes: >> 1. when you `package-install` the new eldoc 1.2.0 package in Emacs 26.3 >> for the first time, it just compiles it, it doesn't load it. We had >> witnessed this with Flymake too, remember? > > `package-install` is not supposed to "load" the package (it installs > it, activates it, and compiles it). But yes, it is also supposed to > *reload* already loaded files (right before compiling), so it looks like > there might be a bug somewhere. > > You might want to trace through `package--load-files-for-activation` to > see why eldoc.el is not reloaded even though it should be in > `load-history`. > >> 2. When you shut down that Emacs session, start it again, run >> package-initialize, you _still_ don't have the new eldoc.el file >> (1.2.0) loaded. This is only for eldoc.el, flymake.el works >> correctly in this use case. > > Yes, this is because it's preloaded in Emacs, so when package.el comes > to activate the package, the autoloads in `eldoc-autoloads.el` won't have= any > effect because all its functions are already defined (since `eldoc.el` > is already loaded). > > This is not a really bug in package.el but arguably a missing feature, > indeed. When `package-activate-all` is called, it should probably > reload all packages that were already loaded before (when the version > already loaded is different from the one that's just been activated). Sounds reasoable. But can these changes ever reach Emacs 26.3? How? Only by updating package.el itself, right? Is that possible? I'm afraid I don't have time to do either of those things, right now, so I'm just going to hack it in Eglot, for now. But I'm also reporting this as a bug, so we can track it. Jo=C3=A3o