all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: "João Távora" <joaotavora@gmail.com>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: Eli Zaretskii <eliz@gnu.org>, emacs-devel@gnu.org
Subject: Re: Byte-compilation warning in eldoc.el
Date: Fri, 10 Jul 2020 22:48:57 +0100	[thread overview]
Message-ID: <87imevdos6.fsf@gmail.com> (raw)
In-Reply-To: <jwvmu479ihx.fsf-monnier+emacs@gnu.org> (Stefan Monnier's message of "Fri, 10 Jul 2020 17:29:10 -0400")

Stefan Monnier <monnier@iro.umontreal.ca> writes:

>> 1. when you `package-install` the new eldoc 1.2.0 package in Emacs 26.3
>>    for the first time, it just compiles it, it doesn't load it.  We had
>>    witnessed this with Flymake too, remember?
>
> `package-install` is not supposed to "load" the package (it installs
> it, activates it, and compiles it).  But yes, it is also supposed to
> *reload* already loaded files (right before compiling), so it looks like
> there might be a bug somewhere.
>
> You might want to trace through `package--load-files-for-activation` to
> see why eldoc.el is not reloaded even though it should be in
> `load-history`.
>
>> 2. When you shut down that Emacs session, start it again, run
>>    package-initialize, you _still_ don't have the new eldoc.el file
>>    (1.2.0) loaded.  This is only for eldoc.el, flymake.el works
>>    correctly in this use case.
>
> Yes, this is because it's preloaded in Emacs, so when package.el comes
> to activate the package, the autoloads in `eldoc-autoloads.el` won't have any
> effect because all its functions are already defined (since `eldoc.el`
> is already loaded).
>
> This is not a really bug in package.el but arguably a missing feature,
> indeed.  When `package-activate-all` is called, it should probably
> reload all packages that were already loaded before (when the version
> already loaded is different from the one that's just been activated).

Sounds reasoable.  But can these changes ever reach Emacs 26.3?  How?
Only by updating package.el itself, right?  Is that possible?

I'm afraid I don't have time to do either of those things, right now, so
I'm just going to hack it in Eglot, for now.  But I'm also reporting
this as a bug, so we can track it.

João



  reply	other threads:[~2020-07-10 21:48 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-10  6:53 Byte-compilation warning in eldoc.el Eli Zaretskii
2020-07-10  7:20 ` João Távora
2020-07-10  7:43   ` Eli Zaretskii
2020-07-10  9:36   ` Noam Postavsky
2020-07-10 14:41   ` Stefan Monnier
2020-07-10 15:05     ` Drew Adams
2020-07-10 15:31     ` João Távora
2020-07-10 21:29       ` Stefan Monnier
2020-07-10 21:48         ` João Távora [this message]
2020-07-10 22:08           ` Stefan Monnier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87imevdos6.fsf@gmail.com \
    --to=joaotavora@gmail.com \
    --cc=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=monnier@iro.umontreal.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.