From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#33301: 27.0.50; broken elisp indentation for non-definition symbols starting with "def.." Date: Mon, 24 Aug 2020 15:12:34 +0200 Message-ID: <87imd8chml.fsf@gnus.org> References: <87zhukh1ri.fsf@gmail.com> <87tvksv21u.fsf@web.de> <87efbvrj4c.fsf@gmail.com> <8736sbumzj.fsf@web.de> <87a7mjqdym.fsf@gmail.com> <877ehnowgy.fsf@web.de> <875zx6r5a3.fsf@gmail.com> <87efbumvd0.fsf@web.de> <87r2fuh1tm.fsf@gmail.com> <871s7uqbvf.fsf@gmail.com> <871rjyloc4.fsf@gnus.org> <87o8n1fszd.fsf@gnus.org> <871rjxbhw9.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="24202"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: Michael Heerdegen , 33301@debbugs.gnu.org, Noam Postavsky To: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Aug 24 15:13:12 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kACHf-00069B-L5 for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 24 Aug 2020 15:13:11 +0200 Original-Received: from localhost ([::1]:52324 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kACHe-0006FX-Mx for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 24 Aug 2020 09:13:10 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:48106) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kACHW-0006F9-G1 for bug-gnu-emacs@gnu.org; Mon, 24 Aug 2020 09:13:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:44970) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kACHW-00008o-6y for bug-gnu-emacs@gnu.org; Mon, 24 Aug 2020 09:13:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kACHW-00079w-2d for bug-gnu-emacs@gnu.org; Mon, 24 Aug 2020 09:13:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 24 Aug 2020 13:13:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 33301 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: confirmed Original-Received: via spool by 33301-submit@debbugs.gnu.org id=B33301.159827477227504 (code B ref 33301); Mon, 24 Aug 2020 13:13:02 +0000 Original-Received: (at 33301) by debbugs.gnu.org; 24 Aug 2020 13:12:52 +0000 Original-Received: from localhost ([127.0.0.1]:56516 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kACHL-00079Y-Qz for submit@debbugs.gnu.org; Mon, 24 Aug 2020 09:12:52 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:56998) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kACHK-00079K-2J for 33301@debbugs.gnu.org; Mon, 24 Aug 2020 09:12:50 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID :In-Reply-To:Date:References:Subject:Cc:To:From:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=VJKlaJuXs191QSgB8iogg5q5N9DWVv/A8jy5AUBqxXE=; b=evcqWxcBalpGJ+JwD+MrP4rWxO frgAxs+oWhzRzyXK5M+TmXd3YPwPkSPKj0Kg9BcOruQWFpz9eqiUlwgREqgZRa+Mc+ZzfUS6U915n 3BXeBcRIWtfhRGiyw36cq66M7MXoxQLAmHJ2p2fvfdGpUdgpmKyVypl5gcHhxhcKIpKs=; Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kACH5-0006UD-WE; Mon, 24 Aug 2020 15:12:44 +0200 Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwAgMAAAAqbBEUAAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAADFBMVEXo2Md/f3DnS2L/ //9XflpNAAAAAWJLR0QDEQxM8gAAAAd0SU1FB+QIGA0KLVM04CkAAAFfSURBVCjPZdKxbsIwEAbg P1ZA1JOpoGo3q4Iq8lOECpZOGZoBpqgTzVMYxFAx8wAGUcm5p+xdEtqhpwz55Pt9jhUgqakA1wQJ yrKmRpAygJrIC9RZEFwQaMEWsAK3A/xWYSSwiQC+BXGb3bZdGDhBjUxw5xLoUHsnGIUOmueoeDwz 3oKSOSQZvAYIXJZA3ZDZHZTP+ZWfjDOMCMWb6zYjGCn/whmE/AtK63287HjrnIc4TQ1nHgQImog/ 4b3ooTljTIfo+GzqKhl6Ds7zikDTJTq+nftZi/2F0Gc0hSjQ1x6aMRS46FtMl4zMWT+QzLhyFB35 OUNNKqJIBAGufPHUw7SI5L9l6LkDVwN1atvcfwwPW+qrwXTR7cZrDSbFx9Ha3SE1/gk4VcNHrFam yBmzKjVmuUqKxRqY58vU5AmKnGEF4yQ1gzVf4qrsixE/byihbF1u2kGbsvt3/vDbVf4ADoOdtQUT 9loAAAAldEVYdGRhdGU6Y3JlYXRlADIwMjAtMDgtMjRUMTM6MTA6NDUrMDA6MDAyCdQSAAAAJXRF WHRkYXRlOm1vZGlmeQAyMDIwLTA4LTI0VDEzOjEwOjQ1KzAwOjAwQ1RsrgAAAABJRU5ErkJggg== X-Now-Playing: Various's _Alefa Madagascar_: "Jean Kely et Basth - Andosy Mora" In-Reply-To: <871rjxbhw9.fsf@gmail.com> ("=?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?="'s message of "Sun, 23 Aug 2020 14:39:50 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:186134 Archived-At: Jo=C3=A3o T=C3=A1vora writes: >> But the main problem is that it would indent the code differently than >> it does now, and that leads to whitespace churn in the vc, which we >> should avoid unless we have a very, very good reason not to. > > What exactly do you mean "whitespace churn"? Can you illustrate this > hypothetical scenario? I don't expect whitespace/indentation beyond > fixing the akward cases, at least that's the entire point of this > report. It means indenting some things in a different way than today? That leads to whitespace changes. >>> As for out-of-tree definitions, we could be lenient and have this >>> saner indentation be controlled by a variable which we would default >>> to 'insane, but to 'sane inside Emacs's source, via directory local >>> variables. >> >> I'd be against that -- again, because it leads to whitespace VC churn. > > Again, I'm missing something: this option wouldn't lead to that, I think If some people have the variable set to 'insane, they would indent the code they're writing differently than the rest, which would lead to whitespace churn. > PS: another entirely different approach would just limit the current > hacky heuristic to calls/expansions that happen at top-level, i.e. at > "column 0". I believe this to be the vast majority (though not the > entirety) of cases. That's probably true... --=20 (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no