From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#12610: unable to use macro in defadvice Date: Sun, 13 Sep 2020 18:43:10 +0200 Message-ID: <87imchiq5d.fsf@gnus.org> References: Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="37394"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 12610@debbugs.gnu.org To: Le Wang Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Sep 13 18:44:46 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kHV7N-0009dG-R0 for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 13 Sep 2020 18:44:45 +0200 Original-Received: from localhost ([::1]:42174 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kHV7M-0004PD-TH for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 13 Sep 2020 12:44:44 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:33040) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kHV6g-0003iM-Ra for bug-gnu-emacs@gnu.org; Sun, 13 Sep 2020 12:44:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:39979) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kHV6g-0005wS-Cr for bug-gnu-emacs@gnu.org; Sun, 13 Sep 2020 12:44:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kHV6g-0001K4-Ar for bug-gnu-emacs@gnu.org; Sun, 13 Sep 2020 12:44:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 13 Sep 2020 16:44:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 12610 X-GNU-PR-Package: emacs Original-Received: via spool by 12610-submit@debbugs.gnu.org id=B12610.16000154025019 (code B ref 12610); Sun, 13 Sep 2020 16:44:02 +0000 Original-Received: (at 12610) by debbugs.gnu.org; 13 Sep 2020 16:43:22 +0000 Original-Received: from localhost ([127.0.0.1]:51522 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kHV61-0001Is-VP for submit@debbugs.gnu.org; Sun, 13 Sep 2020 12:43:22 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:47262) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kHV60-0001Ic-LP for 12610@debbugs.gnu.org; Sun, 13 Sep 2020 12:43:20 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=A1htlYwTFnM9iOA8Da3yMiw5nUmob+LftTJQW6J7dKc=; b=WqciUgAP4G0ZqUujyNBSBiV8od tTl4FjriSdvzs604EicFuQAL2NcLcrrEnYvA80jQX5lFPEk/L8wLWW/RFE5LYzr9U+QAprz/kUMEq 0EqodJqj3vvtNGjLsLJ/zHSegFhl75wQ4Me4zZIQJcitsN5TqH6maEqNUECMxHfd0u/4=; Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kHV5r-0005D1-HE; Sun, 13 Sep 2020 18:43:14 +0200 X-Now-Playing: Deathcrush's _The Single Series_: "Lesson #16 For Beatmaster V: Fun" In-Reply-To: (Le Wang's message of "Tue, 9 Oct 2012 21:02:58 +0800") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:187982 Archived-At: Le Wang writes: > I have this simplified macro. > > (defadvice kill-buffer (around show-diff-rephrase-question activate compile) > "Prompt when a buffer is about to be killed." > (case (read-char-choice > "(s/k/q)? " > (append "sSKkQq" nil)) > ((?s ?S) > ad-do-it) > ((?k ?K) > ad-do-it) > ((?q ?Q) nil)) > ad-do-it) > > If I compile the file and load it, then I get "Invalid function: (115 83)" > > It works if I evaluate it. I've modernised the code slightly: (require 'cl-lib) (defadvice kill-buffer (around show-diff-rephrase-question activate compile) "Prompt when a buffer is about to be killed." (cl-case (read-char-choice "(s/k/q)? " (append "sSKkQq" nil)) ((?s ?S) ad-do-it) ((?k ?K) ad-do-it) ((?q ?Q) nil)) ad-do-it) I tried byte-compiling it and loading the .elc file, and it still doesn't bug out. So I'm guessing this has been fixed over the years? I'm closing this bug report; if you're still seeing this in recent Emacs versions, please respond to the debbugs address and we'll reopen. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no