From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#43467: [PATCH] defcustom warning-show-suppression-buttons correction Date: Thu, 17 Sep 2020 18:16:13 +0200 Message-ID: <87imccnzua.fsf@gnus.org> References: <87363g8krw.fsf@gmail.com> <87d02k2xvf.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="38846"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 43467@debbugs.gnu.org To: No Wayman Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Sep 17 18:22:01 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kIwfZ-0009vP-28 for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 17 Sep 2020 18:22:01 +0200 Original-Received: from localhost ([::1]:49216 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kIwfY-0001rH-0Y for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 17 Sep 2020 12:22:00 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:48926) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kIwam-0006gh-1T for bug-gnu-emacs@gnu.org; Thu, 17 Sep 2020 12:17:11 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:55501) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kIwak-0007US-8P for bug-gnu-emacs@gnu.org; Thu, 17 Sep 2020 12:17:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kIwak-0005BH-3g for bug-gnu-emacs@gnu.org; Thu, 17 Sep 2020 12:17:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 17 Sep 2020 16:17:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 43467 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 43467-submit@debbugs.gnu.org id=B43467.160035938718346 (code B ref 43467); Thu, 17 Sep 2020 16:17:02 +0000 Original-Received: (at 43467) by debbugs.gnu.org; 17 Sep 2020 16:16:27 +0000 Original-Received: from localhost ([127.0.0.1]:38814 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kIwaB-0004la-FJ for submit@debbugs.gnu.org; Thu, 17 Sep 2020 12:16:27 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:42746) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kIwaA-0004fO-0k for 43467@debbugs.gnu.org; Thu, 17 Sep 2020 12:16:26 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=Q3J6ieY40z9WpUQYDYEqVw6l2iT27vfEPxj0gda5E5Q=; b=NDOeaPGZMpMGXr/Qooxma+udTX IQT4yavt8TdhkPL6wDXPGHA5mU3m80Hy5hpGy5xHnqcsGwNeokOkVlv/W6zS0VdPmwiSGWL1sqCLJ 7nvhtBDaQFGIUBeOIPSiFjCq9pEtXCPiqUCDzArH3btHmIHuOJ10ZkegKATdO4qHlfrw=; Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kIwZy-0002Mx-Cd; Thu, 17 Sep 2020 18:16:19 +0200 Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAFVBMVEUZGRojIyV/f39i YmOhoaDc29n///+lfWGoAAAAAWJLR0QGYWa4fQAAAAd0SU1FB+QJERAOBs9yinQAAAFpSURBVDjL xZJtcoQgDIaTcgGyegGr/b8Ke4Cu4QSF+1+lCeCuqP1dZmCGPOTrJQBEVrYuC9siPTCfoFaE/1qo +ekKoIBPe0EI0PD30Wo1Evr4vAAAXUh8PwJlj5TifErh7JJSOiZB9D8fQey8lvtWXXcLsxjdxJxN L6XpEafVmsB8zI4cCTonoE1ioec585rkrQCGAQiJT2VRWp253wIPrd24FMVBWp+rcBvxKc0kx9Pu AZKbRA6WvZYWNg83fYkeQYEtLyvwrEC1mukP4HKoF+g5ZHtk14bquTjE59iGMhWIIq2HWb0WLCD3 IRO+9TdSr8WKRxsKHBUHEbepCuiWa2Iey/WtVSdGL1sbxD2wuc2S2zagm7hUazXFe7qp8/IZfEdo ytVHC2/t7ZNr9iD/imcgkVJN3YQC+dY41LlpgAgs44lVkR0wkwxItTQgP5apsCegS6b3EtDideCQ DiAruR7Lzb0IYMrgF7e4T4Xs5IhwAAAAJXRFWHRkYXRlOmNyZWF0ZQAyMDIwLTA5LTE3VDE2OjE0 OjA2KzAwOjAwPt+8MgAAACV0RVh0ZGF0ZTptb2RpZnkAMjAyMC0wOS0xN1QxNjoxNDowNiswMDow ME+CBI4AAAAASUVORK5CYII= X-Now-Playing: Noveller's _Arrow_: "Landscape" In-Reply-To: <87d02k2xvf.fsf@gmail.com> (No Wayman's message of "Thu, 17 Sep 2020 12:04:20 -0400") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:188223 Archived-At: No Wayman writes: > * lisp/emacs-lisp/warnings.el (warning-show-suppression-buttons): > new defcustom to disable/enable display of warning suppression buttons > in *Warnings* buffer. Warnings are something you should rarely get, so I'm not quite sure I see the use case for this? In any case, some minor comments... > +(defcustom warning-show-suppression-buttons t > + "Whether or not to show suppresion buttons in the *Warnings* buffer. suppression > +If t, buttons are shown, else they are not." We usually say "if non-nil", not "t". > + :type 'boolean) And there should be a :version here. > - (unless noninteractive > + (unless (or noninteractive (not warning-show-suppression-buttons)) And perhaps this would be clearer as a (when (and .. instead. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no