From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#20687: 25.0.50; `perform-replace' should invoke a key that you have bound in `query-replace-map' Date: Thu, 17 Sep 2020 20:11:22 +0200 Message-ID: <87imccmfxx.fsf@gnus.org> References: <87pp5fb172.fsf@mail.linkov.net> <890ac68c-1c71-49c7-9e60-45afba90d74a@default> <873829u5vg.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="38263"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 20687@debbugs.gnu.org, Kaushal To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Sep 17 20:12:09 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kIyO9-0009rC-2Z for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 17 Sep 2020 20:12:09 +0200 Original-Received: from localhost ([::1]:37596 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kIyO8-0007lx-5C for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 17 Sep 2020 14:12:08 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:53418) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kIyO2-0007lf-Pl for bug-gnu-emacs@gnu.org; Thu, 17 Sep 2020 14:12:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:55682) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kIyO2-0007Pe-H5 for bug-gnu-emacs@gnu.org; Thu, 17 Sep 2020 14:12:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kIyO2-0004Pb-D8 for bug-gnu-emacs@gnu.org; Thu, 17 Sep 2020 14:12:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 17 Sep 2020 18:12:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 20687 X-GNU-PR-Package: emacs Original-Received: via spool by 20687-submit@debbugs.gnu.org id=B20687.160036629616909 (code B ref 20687); Thu, 17 Sep 2020 18:12:02 +0000 Original-Received: (at 20687) by debbugs.gnu.org; 17 Sep 2020 18:11:36 +0000 Original-Received: from localhost ([127.0.0.1]:38992 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kIyNb-0004Oe-Pc for submit@debbugs.gnu.org; Thu, 17 Sep 2020 14:11:35 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:44102) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kIyNZ-0004OK-GL for 20687@debbugs.gnu.org; Thu, 17 Sep 2020 14:11:34 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=nAh18Opbj/cvwawL2aNXyHEzzGMFm0LsRh5x2hXqOew=; b=T2vRarNMR0qNTKrOFlCEHuSzal XQwEEROtIHsO4Usx02i7CSUeN4r3N/AnrfbIUL73cmMgJ3sTWKgfBkShkTBTrrZYxFUcZLUzhOtfR VPzH0W4a8r77rYzN/f5DW0R0ChS3A/T3Bp4Rm1Cc9cZztDNi3lEoUQb1DayGcUpSCCZs=; Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kIyNP-0003RO-Ls; Thu, 17 Sep 2020 20:11:26 +0200 X-Now-Playing: Scritti Politti's _Provision_: "Best thing ever" In-Reply-To: <873829u5vg.fsf@mail.linkov.net> (Juri Linkov's message of "Wed, 03 Jun 2015 01:01:39 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:188241 Archived-At: Juri Linkov writes: > I see there are already commands (as opposed to special internal > values such as `act' and `skip') in query-replace-map: > > (define-key map "\C-v" 'scroll-up) > (define-key map "\M-v" 'scroll-down) > (define-key map [next] 'scroll-up) > (define-key map [prior] 'scroll-down) > (define-key map [?\C-\M-v] 'scroll-other-window) > (define-key map [M-next] 'scroll-other-window) > (define-key map [?\C-\M-\S-v] 'scroll-other-window-down) > (define-key map [M-prior] 'scroll-other-window-down) > > These bindings look like real commands intended to be called > interactively, so after enabling this feature in query-replace > they will start doing their job which is good. [...] > + ((commandp def t) > + (call-interactively def)) I'm not sure I quite understand Kaushal's proposed patch here, and how it relates to the problem Drew describes, but Juri's patch here seems like the right thing, at least? As far as I can tell, it was never applied. So I've applied it to Emacs 28, and I'm closing this bug report. If there are other related things to be done in this area, it might be better to open a separate bug report and restate what the requested feature is. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no