From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#12507: [debbugs-tracker] Processed: severity 12507 wishlist Date: Wed, 23 Sep 2020 15:34:01 +0200 Message-ID: <87imc4d3cm.fsf@gnus.org> References: <87bogubqjy.fsf@gnu.org> <873925ebpd.fsf@gnu.org> <87363ff7qp.fsf@gnus.org> <11ee80e5-6d98-4a1f-93c8-babb6da003f3@default> <87r1qxrgs1.fsf@gnus.org> <87v9g52dvz.fsf@red-bean.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="24785"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: Chong Yidong , 12507@debbugs.gnu.org To: Karl Fogel Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Sep 23 15:35:29 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kL4vg-0006IP-8j for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 23 Sep 2020 15:35:28 +0200 Original-Received: from localhost ([::1]:52498 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kL4vf-0007h7-B8 for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 23 Sep 2020 09:35:27 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:36226) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kL4vG-0007Qz-U1 for bug-gnu-emacs@gnu.org; Wed, 23 Sep 2020 09:35:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:51548) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kL4vG-0005W3-Ka for bug-gnu-emacs@gnu.org; Wed, 23 Sep 2020 09:35:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kL4vG-0003PU-Ic for bug-gnu-emacs@gnu.org; Wed, 23 Sep 2020 09:35:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 23 Sep 2020 13:35:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 12507 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: notabug Original-Received: via spool by 12507-submit@debbugs.gnu.org id=B12507.160086806013031 (code B ref 12507); Wed, 23 Sep 2020 13:35:02 +0000 Original-Received: (at 12507) by debbugs.gnu.org; 23 Sep 2020 13:34:20 +0000 Original-Received: from localhost ([127.0.0.1]:34861 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kL4ua-0003O6-Jz for submit@debbugs.gnu.org; Wed, 23 Sep 2020 09:34:20 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:44354) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kL4uZ-0003Nm-Dc for 12507@debbugs.gnu.org; Wed, 23 Sep 2020 09:34:19 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=6AHsulLaSHeZ8kKJ/gqYZK+Vnz5hKULcVA1HY/Km+KE=; b=C8NrhGmyP808flzsBwuPuxDtHB QHvmbk+5C1VQtcEkcrpkFHflLkmU0f+opkEiGVjoJA3MDgaYhr6Lb403DKZK3fgDZp5T18paWfft2 WcPp5gaBVo6VQo0t3ubsgvVwcdjbCr9QOM20fhSy88BGKYd+JBb74spXV6BU3lu3DjVg=; Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kL4uI-0007ur-SJ; Wed, 23 Sep 2020 15:34:12 +0200 Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAGFBMVEUpKCYfHRxIRjxR UEhAPjpqaWKEgnn///8ghV9sAAAAAWJLR0QHFmGI6wAAAAd0SU1FB+QJFwwgNtL7tjwAAAGISURB VDjLnZO/csMgDMaFCZlxfN4pNDuHTpm7dM+Z4wl66fs/QiXiJPhPlmoAW79In/hwAJpQvQT0FsDC BthVsgan9wFYxWkFe2Qv3TkAHZdEBsEUe4dfIbYNOgCTUrT8C90WUClXE1JaC9jJewaIa9UhJR8N pQraViYFboXbCgY4GY/oYOmS8azxzcuHvEUI2jbgiBhU1MjgKWNugThFSV5cO0Apctwhir/s/lNG 0VWex+vGvlJTl5dLh/vkNEkryv5h6UN78ucSeV0fkKdNIRf2Ki3yKjDw4YdBWMgr9D5MHQrIrSGQ vKeb0WkD+Dbo93zikpBfNw1wqhU0YGD3WzByRXA4iFRpO41c4RWNxPsCGAGAI66AOnoBWVotwUWA yiOtgSQ+gYZd4MBY2akF5Q4gr0G+gyg7tpbkOpW+duxytM1NVeAAxUzXHlBOLCUgaxu6FD40P3QM VM9/XWUfUphnoDQZIsL5JlWvJ9lZIhByPj4/JEUzmFs1Flc1eBPdO3CAf0bV/gPFW0REvhNm3gAA ACV0RVh0ZGF0ZTpjcmVhdGUAMjAyMC0wOS0yM1QxMjozMjo1NCswMDowMPPAF2wAAAAldEVYdGRh dGU6bW9kaWZ5ADIwMjAtMDktMjNUMTI6MzI6NTQrMDA6MDCCna/QAAAAAElFTkSuQmCC X-Now-Playing: Herbert's _Bodily Functions_: "Addiction" In-Reply-To: <87v9g52dvz.fsf@red-bean.com> (Karl Fogel's message of "Wed, 23 Sep 2020 01:41:52 -0500") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:188776 Archived-At: Karl Fogel writes: > I've just been deep-diving into this again. I'd like feedback on this general plan for a solution: > > 1) In files.el: define a new function `back-up-file' [a] that takes a > file name as argument and does most of what `backup-buffer' currently > does -- basically, everything from the second `when' on down to the > end of the function. > > 2) Change `backup-buffer' to use the new function `back-up-file'. > > In other words, we abstract out most of the Emacs file backup > functionality to this new function `back-up-file' so we can call it > in (3) below, passing a file name argument. Sounds perfect. There's a bunch of modes in Emacs that want to do a backup file, and they go through all these contortions to make this happen. > 3) In bookmark.el, in `bookmark-write-file', call `back-up-file' right > before the `write-region' call. (Note that the ambient value of > `version-control' will already be correct at this point.) Sure. > [a] Yes, I know I've inserted a hyphen into "back-up" in that function > name. That's because in English "back up" is a compound verb, > whereas "backup" as one word is a noun. The existing function name > "backup-buffer" is thus grammatically suspect, but I'm not proposing > to fix that here; I'm just trying to avoid repeating the confusion. > If folks would prefer "backup-file" for consistency, I could do > that, or maybe just find another name. I'd rather go with `backup-file', just because of the analogy to `backup-buffer'. `back-up-file' just looks odd in that context, even if more correct. Or perhaps just make it even more explicit: `make-backup-file'? -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no