From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#44319: make mode should recognize ::= as a macro assignment Date: Fri, 30 Oct 2020 13:52:20 +0100 Message-ID: <87imarj2pn.fsf@gnus.org> References: <20201029203409.2nvutolbzkimbgpn@iset.darkempire.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="25057"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 44319@debbugs.gnu.org To: Robert Lange Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Oct 30 14:03:31 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kYU41-0006PF-DE for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 30 Oct 2020 14:03:29 +0100 Original-Received: from localhost ([::1]:55812 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kYU40-0001Mw-ES for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 30 Oct 2020 09:03:28 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:55082) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kYTtx-0001NH-4J for bug-gnu-emacs@gnu.org; Fri, 30 Oct 2020 08:53:05 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:45009) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kYTtu-00037m-BH for bug-gnu-emacs@gnu.org; Fri, 30 Oct 2020 08:53:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kYTtu-0002dx-9S for bug-gnu-emacs@gnu.org; Fri, 30 Oct 2020 08:53:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 30 Oct 2020 12:53:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 44319 X-GNU-PR-Package: emacs Original-Received: via spool by 44319-submit@debbugs.gnu.org id=B44319.160406235610111 (code B ref 44319); Fri, 30 Oct 2020 12:53:02 +0000 Original-Received: (at 44319) by debbugs.gnu.org; 30 Oct 2020 12:52:36 +0000 Original-Received: from localhost ([127.0.0.1]:56552 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kYTtU-0002d1-Ei for submit@debbugs.gnu.org; Fri, 30 Oct 2020 08:52:36 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:37358) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kYTtT-0002ck-5u for 44319@debbugs.gnu.org; Fri, 30 Oct 2020 08:52:35 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=eAUzqU5zCqzQlLaWgjKaEuIVZ7hAXgfDY11ONeKZLgg=; b=P5z9xxny5ouFnH42+vpPQWwIiH IVvXRL9+8L4XJkY14+lWxi2pbfABCbAmjHCXaGNrboEAhxbRxTHTPQ4H/XBzCF+IhLc0f7F4JW9YC TmsbW7Ef9v98r9CzO7K6NCvV595FUfT/b/Q6OiU4HvXdFkNpt8isjkc0nWoYjicLYplM=; Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kYTtF-0000D0-Uf; Fri, 30 Oct 2020 13:52:28 +0100 X-Now-Playing: PJ Harvey's _Dry Demos_: "Water" In-Reply-To: <20201029203409.2nvutolbzkimbgpn@iset.darkempire.org> (Robert Lange's message of "Thu, 29 Oct 2020 16:34:09 -0400") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:192083 Archived-At: Robert Lange writes: > I've tested this on Emacs 26.1 on Debian, as well as a self-compiled > 27.1. When I use the GNU immediate assignment operator `:=` the macro > name ELC_FILES is correctly shown in font-lock in the macro color. But > if I use the POSIX standard `::=` (well, forthcoming POSIX standard, > but GNU emacs has supported it since v4.0) ELC_FILES is incorrectly > shown in the target color. Yup. This bug is still present in Emacs 28. > Looking in lisp/progmodes/make-mode.el, the const > makefile-macroassign-regex is pretty gnarly, but I *think* it should > match a `::=`, so I'm assuming it's getting preempted by something > else, probably the const makefile-dependency-regex. Unfortunately, > that regexp is a bit more than I can interpret, and I don't dare > change it because I'll almost certainly break some other obscure but > legal cases. The bug seemed to be in makefile-match-dependency, which checked for ":=", but not for "::=", and I've now fixed this on the trunk. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no