From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.devel Subject: Re: master 2a4b0da: Make minor mode ARG work as documented Date: Mon, 02 Nov 2020 15:48:08 +0100 Message-ID: <87iman95nb.fsf@gnus.org> References: <20201101140048.24374.21430@vcs0.savannah.gnu.org> <20201101140050.9F050209B1@vcs0.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="38689"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Nov 02 15:49:53 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kZb9c-0009x9-W4 for ged-emacs-devel@m.gmane-mx.org; Mon, 02 Nov 2020 15:49:52 +0100 Original-Received: from localhost ([::1]:41252 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kZb9c-0001gg-0o for ged-emacs-devel@m.gmane-mx.org; Mon, 02 Nov 2020 09:49:52 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:43922) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kZb89-0000hM-AG for emacs-devel@gnu.org; Mon, 02 Nov 2020 09:48:21 -0500 Original-Received: from quimby.gnus.org ([2a01:4f9:2b:f0f::2]:37446) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kZb87-0006yV-5m for emacs-devel@gnu.org; Mon, 02 Nov 2020 09:48:21 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=r2KaQzRN6Djxsao2IP86WNIfbl96pQqo6zXcWNsQOsI=; b=rC9tC/QqdK1zdPMJxYV3amoiKI XEg5DIS6hMQ9rUt2YLvcXWZHXFqkAHJAnbVrL6XnlzzQnbdgnlMzpQzwYVJJupe2lE9VHIZyPXbtp xAMLA1FiaM73cuRnHPXnELQCwg12i3zjk85AZERTy1ORy4XXV26zHlWTcS33Ye6BwUjs=; Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kZb7x-0000sU-Ve; Mon, 02 Nov 2020 15:48:12 +0100 Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAKlBMVEX+7FH87WPLrEaO bDWwjDpNGyhUJSqphUpkNi5ySy5sRUbLrD2LYEv////M2cpMAAAAAWJLR0QN9rRh9QAAAAd0SU1F B+QLAg4sHLt2EEUAAAGDSURBVDjLdZRBbsIwEEVzhPYI0CXLtAvWiN7AI7quZmSWHALLZouEiHoB FHEDrpBDdewZJ04IP1kkfh7/8UziqprRO6v6qGe1qLZGBGgMml6HakuiXR2a+rzWt6OCGGHJsxRg BIbiEnhq2/aGPGkAsrTOJQMZIA2eiWQgJiBTSw9MI0CGJuB37WJWRBOAf5u6uXo00wisDYRzvVm7 wiWBBqK3b1gOSo99Stwk6HTBBH6QU0KIEIIPrgBoKM7km92+erBDRGBflIJcCpAcSI39YB5Lij2w o6yiNU0AeiCQaolcBgGk1BnaDGxeCh15kJAekHjgmQZA+6Kqn04Slp3T0Ker5iUbPBoY9SmDOM1J +uPWkh0+tHHEaGge9Pj4DNwrYF+ClKCb8fCO2RyIwxF8P0VEk2MJIAcwKCO0tdbGtWaz4gIpQP3v +q5b3UcT+OL7yp914KfmorXyPviR3FDEU9vd267tbvfOpYod9MgoGoj6164equVqWWhRPWaOpTc+ lv4BOsy5elBuQLgAAAAldEVYdGRhdGU6Y3JlYXRlADIwMjAtMTEtMDJUMTQ6NDQ6MjgrMDA6MDCs 9+mNAAAAJXRFWHRkYXRlOm1vZGlmeQAyMDIwLTExLTAyVDE0OjQ0OjI4KzAwOjAw3apRMQAAAABJ RU5ErkJggg== X-Now-Playing: The Unthanks's _Diversions, Vol 1: The Songs Of Robert Wyatt And Antony & The Johnsons_: "Cuckoo Madame" In-Reply-To: (Stefan Monnier's message of "Sun, 01 Nov 2020 10:33:24 -0500") Received-SPF: pass client-ip=2a01:4f9:2b:f0f::2; envelope-from=larsi@gnus.org; helo=quimby.gnus.org X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:258627 Archived-At: Stefan Monnier writes: >> +If called from Lisp, toggle the mode if if ARG is `toggle'. >> +Enable the mode if ARG is nil, omitted, or is a positive number. >> +All other values will disable the mode. > > No: only non-positive numbers should be documented to disable the mode. > Other values should not be kept free for future use. I altered the code to do what the documentation said it should do, but that's not really tenable, because people use these other values. So I've partially reverted the code changes and adjusted the doc string instead. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no