From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: "Basil L. Contovounesios" Newsgroups: gmane.emacs.bugs Subject: bug#45034: [PATCH] * lisp/simple.el (async-shell-command): use comint-term-environment Date: Sat, 05 Dec 2020 11:26:47 +0000 Message-ID: <87im9gv6h4.fsf@tcd.ie> References: <20201204000304.8213-1-hi@alyssa.is> <87h7p1nau3.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="31993"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: Alyssa Ross , 45034@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Dec 05 12:27:12 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1klVia-0008D8-6M for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 05 Dec 2020 12:27:12 +0100 Original-Received: from localhost ([::1]:42908 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1klViZ-00009D-7N for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 05 Dec 2020 06:27:11 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:50852) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1klViQ-00008p-BD for bug-gnu-emacs@gnu.org; Sat, 05 Dec 2020 06:27:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:35099) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1klViQ-0004bH-3y for bug-gnu-emacs@gnu.org; Sat, 05 Dec 2020 06:27:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1klViP-0002Vn-V4 for bug-gnu-emacs@gnu.org; Sat, 05 Dec 2020 06:27:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: "Basil L. Contovounesios" Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 05 Dec 2020 11:27:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 45034 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: fixed patch Original-Received: via spool by 45034-submit@debbugs.gnu.org id=B45034.16071676199647 (code B ref 45034); Sat, 05 Dec 2020 11:27:01 +0000 Original-Received: (at 45034) by debbugs.gnu.org; 5 Dec 2020 11:26:59 +0000 Original-Received: from localhost ([127.0.0.1]:46645 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1klViN-0002VX-JA for submit@debbugs.gnu.org; Sat, 05 Dec 2020 06:26:59 -0500 Original-Received: from mail-wr1-f46.google.com ([209.85.221.46]:46923) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1klViJ-0002VF-VS for 45034@debbugs.gnu.org; Sat, 05 Dec 2020 06:26:58 -0500 Original-Received: by mail-wr1-f46.google.com with SMTP id g14so7806481wrm.13 for <45034@debbugs.gnu.org>; Sat, 05 Dec 2020 03:26:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd-ie.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=b/4tlaXIwR8r0WAq3akToRYy7lbG5wlsFOP1q6ZqR08=; b=JlDoD5yc50e8TFmQoc1OPXmFrPv99DT7IrTxAU+Mb7cXBZcOvRdZdlvUYi+sKOjsGu OCD52nFuIbCuFn8It4tWMNJ9OgRyxTq/jknejjJ+UOkWGhnfRxFjgwf0dqfbaUL0alKD jFv17YdMwSqP3AVBV2MFcQN2wGMpnh+isEzGte1CnqY4/WEktJ83Nl0dXs4bq3WTqtWe 9cZEBH0eqOqvs8Gd3FNojcfi41rcR2MIEewH8fV0dz8rvJumsNglnTFW2Y+QExvLBwNb ek+ga+2RaTrIIjYFGQWIiiFJc6AjAXtMKEZhzzSqgpG64xwIWK+Fcvc4+eTo6dytMldN 93DA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=b/4tlaXIwR8r0WAq3akToRYy7lbG5wlsFOP1q6ZqR08=; b=Bwrww7HQ0NppKMm8eXZn7uQG29YVmyvhBFLMt2K4wHLdop07jkK9FNfSQxQv80TDXJ NoLt9HEpQF4708qCRz5ADTYQsEGexmt0YkTJ43GTF02LlhyeKsJM81ALJM/rCSwquqPW ywI1HPY7BP9mAwfwUGFpBQK3KkBcSlKPVrYySyLgzPMTdYwaGKuyWj3R6CLhR4+d3k9U yjsl8Oj9iXuMdksEf1jBhdI7nhZ0m68JR8teYQdiTl4BorNxukOFyv19BeGFDJL8iDz8 EX67G4hszc4BVpHA8TCv70W5Vqnh5JgfgFaLjKPWrf/2ihsDI0uYc9F1AQ9CeeF8/Jrp GeOA== X-Gm-Message-State: AOAM533Rh7/LLBJuuh1AXOMxZL7BcKBMfRuaB96qG3MG6rd5usKDeK+h +7/WR3a/+AabwNCtfdtBu+Mw5A== X-Google-Smtp-Source: ABdhPJzz3qlZfHKkAefcTfK+d62ubh5LXlBuQkzC6qVdbHrmbNwfTD9ciWG5cadAxAkWxIzBv+3w2Q== X-Received: by 2002:adf:fc01:: with SMTP id i1mr10132426wrr.250.1607167610304; Sat, 05 Dec 2020 03:26:50 -0800 (PST) Original-Received: from localhost ([51.37.47.98]) by smtp.gmail.com with ESMTPSA id f23sm6320522wmb.43.2020.12.05.03.26.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 05 Dec 2020 03:26:49 -0800 (PST) In-Reply-To: <87h7p1nau3.fsf@gnus.org> (Lars Ingebrigtsen's message of "Fri, 04 Dec 2020 11:07:32 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:195024 Archived-At: Lars Ingebrigtsen writes: > Alyssa Ross writes: > >> With this change, a simple (setq comint-terminfo-terminal "dumb-emacs-ansi") >> is all that's required to get colored output from many programs on a >> GNU/Linux system with a recent version of ncurses when run through >> async-shell-command. > > Thanks; makes sense to me, so I've applied it to Emacs 28 (with some > small changes). This caused an error with: 0. emacs -Q 1. (async-shell-command "true") C-x C-e I pushed the following fixes to master; let me know if there's anything wrong with them. Fix last change to shell-command e5a18efd3d 2020-12-05 10:45:17 +0000 https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=e5a18efd3d96a942c6d6bdc04d0d431165f3138a Thanks, -- Basil