From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#44631: 28.0.50; Byte compilation fails if destination file is a mount point Date: Sun, 13 Dec 2020 13:32:37 +0100 Message-ID: <87im956g4a.fsf@gnus.org> References: <87ima8ylfv.fsf@gnus.org> <87y2irb7pj.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="29631"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 44631@debbugs.gnu.org To: Philipp Stephani Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Dec 13 13:33:08 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1koQYm-0007ao-QX for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 13 Dec 2020 13:33:08 +0100 Original-Received: from localhost ([::1]:39130 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1koQYl-0000Sw-TV for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 13 Dec 2020 07:33:07 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:37888) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1koQYg-0000Sq-5v for bug-gnu-emacs@gnu.org; Sun, 13 Dec 2020 07:33:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:36056) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1koQYf-0007el-S4 for bug-gnu-emacs@gnu.org; Sun, 13 Dec 2020 07:33:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1koQYf-0003Z0-OQ for bug-gnu-emacs@gnu.org; Sun, 13 Dec 2020 07:33:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 13 Dec 2020 12:33:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 44631 X-GNU-PR-Package: emacs Original-Received: via spool by 44631-submit@debbugs.gnu.org id=B44631.160786277213669 (code B ref 44631); Sun, 13 Dec 2020 12:33:01 +0000 Original-Received: (at 44631) by debbugs.gnu.org; 13 Dec 2020 12:32:52 +0000 Original-Received: from localhost ([127.0.0.1]:47602 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1koQYW-0003YP-4Z for submit@debbugs.gnu.org; Sun, 13 Dec 2020 07:32:52 -0500 Original-Received: from quimby.gnus.org ([95.216.78.240]:57932) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1koQYU-0003Xq-JA for 44631@debbugs.gnu.org; Sun, 13 Dec 2020 07:32:51 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=kedgTIKAgJ3a7OC43InaJf/eGy4diT+wMm7pqu56rfo=; b=BeNruXLj62leuL10BmrYQAP9zR O3GNW8dGjO7pKh2I6bJNPrxQsjm6R5rp4n0uHd7n5YpYc+ZUPzvYE4QZEHxwc5XFKEEctLXmzM/yp YtqIKR1n7xnGMktBqEZjDlYtJjpeIDDufaRu6tEysDclY4IZ3nxsALAsCQiHfGLKHpbI=; Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1koQYI-0004hW-Iq; Sun, 13 Dec 2020 13:32:44 +0100 Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAJ1BMVEUnKjFIWW55hYZX Ym+RmZyMd4beO1DQtL/MydHqHjSzucl8quv////g3T9KAAAAAWJLR0QMgbNRYwAAAAd0SU1FB+QM DQwbKg0MPcAAAAGjSURBVDjLbdFLbsIwEAZgrmDcCxBygcSpVHVpoqrqtmXBvg2EA5DQAxCLAwR5 XzXWdN37dfyIY1MGCYb5/DtOMpvN5nmSJEv9tSCJrxmC/5OR+U1YEkJuQoaQ3wAdIBSblPMyBB3Q kbTUZUA3nJs5obwc4c4uWVgg6QSm4ZmD+RWsCIkiHjIPRQRTgNAIpoDbywEP5vbyDhYZu4pY4Czc ihYeVixMUOaBZZSxac4KBytmyozZfVW95g7sPNMPPW27ppYfqQFul+MUoGla0aEYWOBilrzAGWBo jMj+Tb8PyvJSCSFAB7CEONbvCJRmz8LOh62R5tRXCAUr9Bw3+tlIU31V9QgPehsT+JVj1VsNnQvA xoNsDeyVHsPTNL8IDeKwv5rL1kInq/W6kmFA2IsfZVy7EU7xvBcW8Ke+DrhEHNGBEaLIdgIQhyDQ ejiD6qKzjoB3p6YTtxFAFwcMAOCzVZsoYEGps1LuxD1eUAilEB71Tkq5E++ww1OKEbC+bUAoUBEM Q20C5tVAmAC8yf4TZ/gBFQKeeDv2EAIcbeA/fF18C38TwJZnmmD7qQAAACV0RVh0ZGF0ZTpjcmVh dGUAMjAyMC0xMi0xM1QxMjoyNzo0MiswMDowMOcXzaIAAAAldEVYdGRhdGU6bW9kaWZ5ADIwMjAt MTItMTNUMTI6Mjc6NDErMDA6MDCnom+DAAAAAElFTkSuQmCC X-Now-Playing: Colleen's _A Flame My Love, A Frequency_: "Another World" In-Reply-To: (Philipp Stephani's message of "Sat, 12 Dec 2020 16:19:27 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:195948 Archived-At: Philipp Stephani writes: > I guess it also depends on what the semantics are that > byte-compile-file guarantees. If it attempts to guarantee atomicity, > then only a intra-filesystem rename (or similar alternatives such as > O_TMPFILE + linkat) are acceptable, and technically, not even the > current fallback on EXDEV (which makes rename-file nonatomic) is OK. > If atomic writes are best-effort, then we could always fall back to > copy-file + delete-file on any file-error. It's definitely best-effort, so altering byte-compile-file to try copy-file + delete-file sounds like the best solution to me. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no