From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#38523: 27.0.50; tab-line faces don't update to reflect selected tab Date: Wed, 23 Dec 2020 23:08:30 +0200 Organization: LINKOV.NET Message-ID: <87im8sz0x9.fsf@mail.linkov.net> References: <87k0v7en6k.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="18119"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu) Cc: David O'Toole , 38523@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Dec 23 22:12:43 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ksBR4-0004Y8-Hm for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 23 Dec 2020 22:12:42 +0100 Original-Received: from localhost ([::1]:50872 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ksBR3-0007QB-I5 for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 23 Dec 2020 16:12:41 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:42122) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ksBQR-0006pZ-9P for bug-gnu-emacs@gnu.org; Wed, 23 Dec 2020 16:12:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:42715) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ksBQR-0007LT-1b for bug-gnu-emacs@gnu.org; Wed, 23 Dec 2020 16:12:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ksBQQ-0001i5-Sg for bug-gnu-emacs@gnu.org; Wed, 23 Dec 2020 16:12:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 23 Dec 2020 21:12:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 38523 X-GNU-PR-Package: emacs Original-Received: via spool by 38523-submit@debbugs.gnu.org id=B38523.16087579056536 (code B ref 38523); Wed, 23 Dec 2020 21:12:02 +0000 Original-Received: (at 38523) by debbugs.gnu.org; 23 Dec 2020 21:11:45 +0000 Original-Received: from localhost ([127.0.0.1]:54260 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ksBQ9-0001hL-5L for submit@debbugs.gnu.org; Wed, 23 Dec 2020 16:11:45 -0500 Original-Received: from relay7-d.mail.gandi.net ([217.70.183.200]:56229) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ksBQ7-0001h1-C6 for 38523@debbugs.gnu.org; Wed, 23 Dec 2020 16:11:43 -0500 X-Originating-IP: 91.129.99.98 Original-Received: from mail.gandi.net (m91-129-99-98.cust.tele2.ee [91.129.99.98]) (Authenticated sender: juri@linkov.net) by relay7-d.mail.gandi.net (Postfix) with ESMTPSA id 9F79620002; Wed, 23 Dec 2020 21:11:36 +0000 (UTC) In-Reply-To: <87k0v7en6k.fsf@gnus.org> (Lars Ingebrigtsen's message of "Fri, 30 Oct 2020 16:41:23 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:196641 Archived-At: >> The following change seems to make the tab faces update properly after clicking a >> tab. But I'm not sure this is the correct way to do it. > > [...] > >> + (progn >> + (tab-line-select-tab-buffer buffer (posn-window posnp)) >> + (force-mode-line-update t) >> + (set-window-parameter nil 'tab-line-cache nil) >> + (setf tab-line-format '(:eval (tab-line-format))) > > No, I have a feeling that may be too heavy-handed. > >> I configured the tab bar and tab line faces (tab-bar-tab and >> tab-line-tab-current) to show the currently selected tab with yellow text. >> >> Although the tab __bar__ faces do update properly to highlight the >> selected tab, the tab __line__ faces don't update; no matter which is >> clicked, the first tab that had been highlighted stays highlighted >> (or sometimes none of them are highlighted.) Also, the close buttons >> on tab line tabs do not work; instead it just switches to that tab's >> buffer. > > Perhaps Juri has some insight here (added to the Cc). Sorry for the delay. Now I pushed to master a patch from emacs-devel that improves tab-line face calculation logic. David, could you please confirm if everything works correctly now.