From: Juri Linkov <juri@linkov.net>
To: Lars Ingebrigtsen <larsi@gnus.org>
Cc: David O'Toole <deeteeoh1138@gmail.com>, 38523@debbugs.gnu.org
Subject: bug#38523: 27.0.50; tab-line faces don't update to reflect selected tab
Date: Wed, 23 Dec 2020 23:08:30 +0200 [thread overview]
Message-ID: <87im8sz0x9.fsf@mail.linkov.net> (raw)
In-Reply-To: <87k0v7en6k.fsf@gnus.org> (Lars Ingebrigtsen's message of "Fri, 30 Oct 2020 16:41:23 +0100")
>> The following change seems to make the tab faces update properly after clicking a
>> tab. But I'm not sure this is the correct way to do it.
>
> [...]
>
>> + (progn
>> + (tab-line-select-tab-buffer buffer (posn-window posnp))
>> + (force-mode-line-update t)
>> + (set-window-parameter nil 'tab-line-cache nil)
>> + (setf tab-line-format '(:eval (tab-line-format)))
>
> No, I have a feeling that may be too heavy-handed.
>
>> I configured the tab bar and tab line faces (tab-bar-tab and
>> tab-line-tab-current) to show the currently selected tab with yellow text.
>>
>> Although the tab __bar__ faces do update properly to highlight the
>> selected tab, the tab __line__ faces don't update; no matter which is
>> clicked, the first tab that had been highlighted stays highlighted
>> (or sometimes none of them are highlighted.) Also, the close buttons
>> on tab line tabs do not work; instead it just switches to that tab's
>> buffer.
>
> Perhaps Juri has some insight here (added to the Cc).
Sorry for the delay. Now I pushed to master a patch from emacs-devel
that improves tab-line face calculation logic.
David, could you please confirm if everything works correctly now.
next prev parent reply other threads:[~2020-12-23 21:08 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-07 16:48 bug#38522: 27.0.50; tab-line faces don't update to reflect selected tab David O'Toole
2019-12-07 17:54 ` bug#38523: " David O'Toole
2020-10-30 15:41 ` Lars Ingebrigtsen
2020-12-23 21:08 ` Juri Linkov [this message]
2021-01-06 17:50 ` Juri Linkov
2019-12-08 22:09 ` bug#38522: " Juri Linkov
2019-12-09 22:23 ` David O'Toole
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87im8sz0x9.fsf@mail.linkov.net \
--to=juri@linkov.net \
--cc=38523@debbugs.gnu.org \
--cc=deeteeoh1138@gmail.com \
--cc=larsi@gnus.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.