From: Lars Ingebrigtsen <larsi@gnus.org>
To: Phil Sainty <psainty@orcon.net.nz>
Cc: 41836@debbugs.gnu.org
Subject: bug#41836: 26.3; Could we stop `help-buffer' from ever signalling errors?
Date: Thu, 21 Jan 2021 17:04:53 +0100 [thread overview]
Message-ID: <87im7q8ee2.fsf@gnus.org> (raw)
In-Reply-To: <871rmj9js2.fsf@orcon.net.nz> (Phil Sainty's message of "Sun, 14 Jun 2020 01:29:01 +1200")
Phil Sainty <psainty@orcon.net.nz> writes:
> My motivation is from wondering whether it was simple to
> display all of the function and variable symbols displayed by
> `so-long-commentary' as help buttons. I found that calling
> `help-make-xrefs' does exactly that, but then trying to use any
> of the buttons causes the "Current buffer is not in Help mode"
> error.
>
> With the suggested change I get the desirable behaviour of those
> help buttons popping up a help window with the relevant help.
> It seems to work beautifully for my use-case, and would surely
> be equally useful in other similar situations.
>
> Is there any good reason to maintain that error?
Looking at the code, my impression is that `help-make-xrefs' is meant to
be used in `help-mode' buffers only, and the `error' call is just a
sanity check for that, kinda? Lifting the restriction by removing that
`error' would allow other usages. I'm not sure whether they're
all taken into account, though.
Anybody got an opinion here?
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
next prev parent reply other threads:[~2021-01-21 16:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-13 13:29 bug#41836: 26.3; Could we stop `help-buffer' from ever signalling errors? Phil Sainty
2021-01-21 16:04 ` Lars Ingebrigtsen [this message]
2022-06-06 14:12 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87im7q8ee2.fsf@gnus.org \
--to=larsi@gnus.org \
--cc=41836@debbugs.gnu.org \
--cc=psainty@orcon.net.nz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.