From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.devel Subject: Re: Patch to avoid flicker in Isearch with lazy count Date: Thu, 28 Jan 2021 20:48:30 +0200 Organization: LINKOV.NET Message-ID: <87im7gaoe9.fsf@mail.linkov.net> References: <87r1m6jsk7.fsf@gmail.com> <87lfce2ruh.fsf@mail.linkov.net> <87tur1bjof.fsf@gmail.com> <871re5e809.fsf@mail.linkov.net> <87lfcd5n0t.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="13956"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu) Cc: emacs-devel@gnu.org To: Augusto Stoffel Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Jan 28 20:02:49 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l5CZ7-0003WS-IH for ged-emacs-devel@m.gmane-mx.org; Thu, 28 Jan 2021 20:02:49 +0100 Original-Received: from localhost ([::1]:43772 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l5CZ6-0006Jw-Ix for ged-emacs-devel@m.gmane-mx.org; Thu, 28 Jan 2021 14:02:48 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:37404) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l5CTx-00028l-0k for emacs-devel@gnu.org; Thu, 28 Jan 2021 13:57:29 -0500 Original-Received: from relay3-d.mail.gandi.net ([217.70.183.195]:36689) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l5CTn-0001tb-R8 for emacs-devel@gnu.org; Thu, 28 Jan 2021 13:57:28 -0500 X-Originating-IP: 91.129.98.64 Original-Received: from mail.gandi.net (m91-129-98-64.cust.tele2.ee [91.129.98.64]) (Authenticated sender: juri@linkov.net) by relay3-d.mail.gandi.net (Postfix) with ESMTPSA id 3767960008; Thu, 28 Jan 2021 18:57:14 +0000 (UTC) In-Reply-To: <87lfcd5n0t.fsf@gmail.com> (Augusto Stoffel's message of "Thu, 28 Jan 2021 12:17:06 +0100") Received-SPF: pass client-ip=217.70.183.195; envelope-from=juri@linkov.net; helo=relay3-d.mail.gandi.net X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:263555 Archived-At: >> Definitely, ‘lazy-highlight-delay-max-chars’ should not affect >> ‘lazy-highlight-interval’ because with pauses between highlighting >> portions of matches, when lazy-highlight-buffer-max-at-a-time is 20, >> this could create a situation when only first 20 matches are counted, >> and during the delay before processing the next portion of matches, >> the users might think this is the final total of all existing matches, >> so this is misleading for users. > > Good, I'll make it so. By the way, why is the default > ‘lazy-highlight-buffer-max-at-a-time’ (20) so low? The overhead of > creating a timer for every 20 matches is pretty substantial. On my > machine, a value like 500 or 1000 makes the lazy count finish visibly > faster, and doesn't affect responsiveness even in huge files. For historical reasons, when computers were slow. Maybe now it's time to bump up the default value.