Separating colour and positioning functioning

all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed

* Separating colour and positioning functioning
@ 2021-02-08 15:02 Christopher Dimech
  2021-02-08 21:37 ` Emanuel Berg via Users list for the GNU Emacs text editor
  0 siblings, 1 reply; 6+ messages in thread
From: Christopher Dimech @ 2021-02-08 15:02 UTC (permalink / raw)
  To: Help Gnu Emacs

Have written a minor mode with part of the the code below and want to
modify tex-typeface-crucible so that the colour scheme is enabled when
the minor-mode is on.

Then one can apply supinf as an option

(defface colour-tex-cruc
  '( (default :inherit bold)
     ( ((class color) (min-colors 88) (background light))
       :foreground "#FF0000" )
     ( ((class color) (min-colors 88) (background dark))
       :foreground "#FF0000")
     (t :inherit font-lock-builtin-face) )
  "Typeface for tex keywords.")

(defconst crucible-tex-keywords
  `( (,(rx "\\" word-start (group (or "alpha" "beta")) word-end)
     (1 'colour-tex-cruc)) )
  "Fontification for letters and symbols.")

(defun supinf-disable-cruc (beg end)
  "Set typeface for text between BEG and END."
  (font-lock-default-unfontify-region beg end)
  (while (< beg end)
    (let ((next (next-single-property-change beg 'display nil end))
	  (prop (get-text-property beg 'display)))
      (if (and (eq (car-safe prop) 'raise)
	       (member (car-safe (cdr prop)) crucible-supinf-vshift)
	       (null (cddr prop)))
	  (put-text-property beg next 'display nil))
      (setq beg next))))

(defun tex-typeface-crucible ()
  "Font-lock setup for mathematical symbols."
  (font-lock-flush (point-min) (point-max))
  (if crucible-supinf-enable
      (progn
        (font-lock-add-keywords nil crucible-tex-keywords t)
        (font-lock-add-keywords nil supinf-font-lock-cruc t))
    (font-lock-remove-keywords nil crucible-tex-keywords)
    (supinf-disable-cruc (point-min) (point-max)))
  (font-lock-flush (point-min) (point-max)))




^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: Separating colour and positioning functioning
  2021-02-08 15:02 Separating colour and positioning functioning Christopher Dimech
@ 2021-02-08 21:37 ` Emanuel Berg via Users list for the GNU Emacs text editor
  2021-02-09  0:20   ` Christopher Dimech
  2021-02-09  0:27   ` Christopher Dimech
  0 siblings, 2 replies; 6+ messages in thread
From: Emanuel Berg via Users list for the GNU Emacs text editor @ 2021-02-08 21:37 UTC (permalink / raw)
  To: help-gnu-emacs

Christopher Dimech wrote:

> Have written a minor mode with part of the the code below
> and want to modify tex-typeface-crucible so that the colour
> scheme is enabled when the minor-mode is on.

I got the following warnings from the byte compiler:

  Warning: defface for ‘colour-tex-cruc’ fails to specify containing group
  Warning: reference to free variable ‘crucible-supinf-enable’
  Warning: reference to free variable ‘crucible-supinf-vshift’
  Warning: reference to free variable ‘supinf-font-lock-cruc’

Style PO-lice:

> (defface colour-tex-cruc

US English is preferable, then it becomes consistent. The user
shouldn't have think, "is the programmer a 'bloke' or
a 'dude'?" ...

>   '( (default :inherit bold)
>      ( ((class color) (min-colors 88) (background light))
>        :foreground "#FF0000" )
>      ( ((class color) (min-colors 88) (background dark))
>        :foreground "#FF0000")
>      (t :inherit font-lock-builtin-face) )
>   "Typeface for tex keywords.")

Avoid hard-coding the same data (88 and "#FF0000") repeatedly.
Normally, the method is to use `let'.

> (defun supinf-disable-cruc (beg end)
>   "Set typeface for text between BEG and END."
>   (font-lock-default-unfontify-region beg end)
>   (while (< beg end)
>     (let ((next (next-single-property-change beg 'display nil end))
> 	  (prop (get-text-property beg 'display)))
>       (if (and (eq (car-safe prop) 'raise)

`if' -> `while'

> 	       (member (car-safe (cdr prop)) crucible-supinf-vshift)
> 	       (null (cddr prop)))
> 	  (put-text-property beg next 'display nil))
>       (setq beg next))))

This looks unorthodox but OK, I don't have a snappy answer
what to do instead...

> (defun tex-typeface-crucible ()
>   "Font-lock setup for mathematical symbols."
>   (font-lock-flush (point-min) (point-max))

Is that the same as just (font-lock-flush) ?

>   (if crucible-supinf-enable
>       (progn
>         (font-lock-add-keywords nil crucible-tex-keywords t)
>         (font-lock-add-keywords nil supinf-font-lock-cruc t))
>     (font-lock-remove-keywords nil crucible-tex-keywords)
>     (supinf-disable-cruc (point-min) (point-max)))
>   (font-lock-flush (point-min) (point-max)))

Is that the same as ... same.

-- 
underground experts united
http://user.it.uu.se/~embe8573
https://dataswamp.org/~incal




^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: Separating colour and positioning functioning
  2021-02-08 21:37 ` Emanuel Berg via Users list for the GNU Emacs text editor
@ 2021-02-09  0:20   ` Christopher Dimech
  2021-02-09  0:27   ` Christopher Dimech
  1 sibling, 0 replies; 6+ messages in thread
From: Christopher Dimech @ 2021-02-09  0:20 UTC (permalink / raw)
  To: moasenwood; +Cc: help-gnu-emacs

> Sent: Tuesday, February 09, 2021 at 9:37 AM
> From: "Emanuel Berg via Users list for the GNU Emacs text editor" <help-gnu-emacs@gnu.org>
> To: help-gnu-emacs@gnu.org
> Subject: Re: Separating colour and positioning functioning
>
> Christopher Dimech wrote:
> 
> > Have written a minor mode with part of the the code below
> > and want to modify tex-typeface-crucible so that the colour
> > scheme is enabled when the minor-mode is on.
> 
> I got the following warnings from the byte compiler:
> 
>   Warning: defface for ‘colour-tex-cruc’ fails to specify containing group
>   Warning: reference to free variable ‘crucible-supinf-enable’
>   Warning: reference to free variable ‘crucible-supinf-vshift’
>   Warning: reference to free variable ‘supinf-font-lock-cruc’
> 
> Style PO-lice:
> 
> > (defface colour-tex-cruc
> 
> US English is preferable, then it becomes consistent. The user
> shouldn't have think, "is the programmer a 'bloke' or
> a 'dude'?" ...
> 
> >   '( (default :inherit bold)
> >      ( ((class color) (min-colors 88) (background light))
> >        :foreground "#FF0000" )
> >      ( ((class color) (min-colors 88) (background dark))
> >        :foreground "#FF0000")
> >      (t :inherit font-lock-builtin-face) )
> >   "Typeface for tex keywords.")
> 
> Avoid hard-coding the same data (88 and "#FF0000") repeatedly.
> Normally, the method is to use `let'.
> 
> > (defun supinf-disable-cruc (beg end)
> >   "Set typeface for text between BEG and END."
> >   (font-lock-default-unfontify-region beg end)
> >   (while (< beg end)
> >     (let ((next (next-single-property-change beg 'display nil end))
> > 	  (prop (get-text-property beg 'display)))
> >       (if (and (eq (car-safe prop) 'raise)
> 
> `if' -> `while'
> 
> > 	       (member (car-safe (cdr prop)) crucible-supinf-vshift)
> > 	       (null (cddr prop)))
> > 	  (put-text-property beg next 'display nil))
> >       (setq beg next))))
> 
> This looks unorthodox but OK, I don't have a snappy answer
> what to do instead...
> 
> > (defun tex-typeface-crucible ()
> >   "Font-lock setup for mathematical symbols."
> >   (font-lock-flush (point-min) (point-max))
> 
> Is that the same as just (font-lock-flush) ?

The code is using narrow-to-region for finding areas where superior and
inferior typeface is enabled.

(defun crucible-supinf-match (limit)
  "Match superior and inferior glyph patterns up to LIMIT."
  (when (and crucible-mode
	     (re-search-forward "[_^] *\\([^\n\\{}]\\|\
\\\\\\([a-zA-Z@]+\\|[^ \t\n]\\)\\|\\({\\)\\)" limit t))
    (when (match-end 3)
      (let ((beg (match-beginning 3))
	    (end (save-restriction
		   (narrow-to-region (point-min) limit)
		   (condition-case nil
		       (scan-lists (point) 1 1) (error nil)))))
	;; body of let
	(store-match-data
           (if end
	       (list (match-beginning 0) end beg end)
	     (list beg beg beg beg)))))
    t))



 
> >   (if crucible-supinf-enable
> >       (progn
> >         (font-lock-add-keywords nil crucible-tex-keywords t)
> >         (font-lock-add-keywords nil supinf-font-lock-cruc t))
> >     (font-lock-remove-keywords nil crucible-tex-keywords)
> >     (supinf-disable-cruc (point-min) (point-max)))
> >   (font-lock-flush (point-min) (point-max)))
> 
> Is that the same as ... same.
> 
> -- 
> underground experts united
> http://user.it.uu.se/~embe8573
> https://dataswamp.org/~incal
> 
> 
>



^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: Separating colour and positioning functioning
  2021-02-08 21:37 ` Emanuel Berg via Users list for the GNU Emacs text editor
  2021-02-09  0:20   ` Christopher Dimech
@ 2021-02-09  0:27   ` Christopher Dimech
  2021-02-09  1:01     ` Emanuel Berg via Users list for the GNU Emacs text editor
  1 sibling, 1 reply; 6+ messages in thread
From: Christopher Dimech @ 2021-02-09  0:27 UTC (permalink / raw)
  To: moasenwood; +Cc: help-gnu-emacs

I am working on crucible-supinf-enable, which currently does both
font-lock-add-keywords and font-lock-unfontify-region-function

And would like the functionality to enable or disable only supinf
rather than disabling tex-keywords-cruc.

tex-keywords-cruc turns tex keywords to a red colour.

I want to have two functions, one to enable supinf, another to disable it.

> Sent: Tuesday, February 09, 2021 at 9:37 AM
> From: "Emanuel Berg via Users list for the GNU Emacs text editor" <help-gnu-emacs@gnu.org>
> To: help-gnu-emacs@gnu.org
> Subject: Re: Separating colour and positioning functioning
>
> Christopher Dimech wrote:
> 
> > Have written a minor mode with part of the the code below
> > and want to modify tex-typeface-crucible so that the colour
> > scheme is enabled when the minor-mode is on.
> 
> I got the following warnings from the byte compiler:
> 
>   Warning: defface for ‘colour-tex-cruc’ fails to specify containing group
>   Warning: reference to free variable ‘crucible-supinf-enable’
>   Warning: reference to free variable ‘crucible-supinf-vshift’
>   Warning: reference to free variable ‘supinf-font-lock-cruc’
> 
> Style PO-lice:
> 
> > (defface colour-tex-cruc
> 
> US English is preferable, then it becomes consistent. The user
> shouldn't have think, "is the programmer a 'bloke' or
> a 'dude'?" ...
> 
> >   '( (default :inherit bold)
> >      ( ((class color) (min-colors 88) (background light))
> >        :foreground "#FF0000" )
> >      ( ((class color) (min-colors 88) (background dark))
> >        :foreground "#FF0000")
> >      (t :inherit font-lock-builtin-face) )
> >   "Typeface for tex keywords.")
> 
> Avoid hard-coding the same data (88 and "#FF0000") repeatedly.
> Normally, the method is to use `let'.
> 
> > (defun supinf-disable-cruc (beg end)
> >   "Set typeface for text between BEG and END."
> >   (font-lock-default-unfontify-region beg end)
> >   (while (< beg end)
> >     (let ((next (next-single-property-change beg 'display nil end))
> > 	  (prop (get-text-property beg 'display)))
> >       (if (and (eq (car-safe prop) 'raise)
> 
> `if' -> `while'
> 
> > 	       (member (car-safe (cdr prop)) crucible-supinf-vshift)
> > 	       (null (cddr prop)))
> > 	  (put-text-property beg next 'display nil))
> >       (setq beg next))))
> 
> This looks unorthodox but OK, I don't have a snappy answer
> what to do instead...
> 
> > (defun tex-typeface-crucible ()
> >   "Font-lock setup for mathematical symbols."
> >   (font-lock-flush (point-min) (point-max))
> 
> Is that the same as just (font-lock-flush) ?
> 
> >   (if crucible-supinf-enable
> >       (progn
> >         (font-lock-add-keywords nil crucible-tex-keywords t)
> >         (font-lock-add-keywords nil supinf-font-lock-cruc t))
> >     (font-lock-remove-keywords nil crucible-tex-keywords)
> >     (supinf-disable-cruc (point-min) (point-max)))
> >   (font-lock-flush (point-min) (point-max)))
> 
> Is that the same as ... same.
> 
> -- 
> underground experts united
> http://user.it.uu.se/~embe8573
> https://dataswamp.org/~incal
> 
> 
>



^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: Separating colour and positioning functioning
  2021-02-09  0:27   ` Christopher Dimech
@ 2021-02-09  1:01     ` Emanuel Berg via Users list for the GNU Emacs text editor
  2021-02-09  2:30       ` Christopher Dimech
  0 siblings, 1 reply; 6+ messages in thread
From: Emanuel Berg via Users list for the GNU Emacs text editor @ 2021-02-09  1:01 UTC (permalink / raw)
  To: help-gnu-emacs

Christopher Dimech wrote:

> I want to have two functions, one to enable supinf, another
> to disable it.

An example toggle function:

(defvar erc-do-spell)
(setq erc-do-spell t)

(defun erc-toggle-spell ()
  (interactive)
  (setq erc-do-spell (not erc-do-spell)) )

https://dataswamp.org/~incal/emacs-init/erc-incal.el

-- 
underground experts united
http://user.it.uu.se/~embe8573
https://dataswamp.org/~incal




^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: Separating colour and positioning functioning
  2021-02-09  1:01     ` Emanuel Berg via Users list for the GNU Emacs text editor
@ 2021-02-09  2:30       ` Christopher Dimech
  0 siblings, 0 replies; 6+ messages in thread
From: Christopher Dimech @ 2021-02-09  2:30 UTC (permalink / raw)
  To: moasenwood; +Cc: help-gnu-emacs

I am thinking to call tex-font-lock-unfontify-region

Have done

(defun supinf-disable ()
  "Disable the supinf typeface"
  (font-lock-flush (point-min) (point-max))
  (setq font-lock-defaults
	'(font-lock-unfontify-region-function . tex-font-lock-unfontify-region))
  (font-lock-flush (point-min) (point-max)) )




> Sent: Tuesday, February 09, 2021 at 1:01 PM
> From: "Emanuel Berg via Users list for the GNU Emacs text editor" <help-gnu-emacs@gnu.org>
> To: help-gnu-emacs@gnu.org
> Subject: Re: Separating colour and positioning functioning
>
> Christopher Dimech wrote:
>
> > I want to have two functions, one to enable supinf, another
> > to disable it.
>
> An example toggle function:
>
> (defvar erc-do-spell)
> (setq erc-do-spell t)
>
> (defun erc-toggle-spell ()
>   (interactive)
>   (setq erc-do-spell (not erc-do-spell)) )
>
> https://dataswamp.org/~incal/emacs-init/erc-incal.el
>
> --
> underground experts united
> http://user.it.uu.se/~embe8573
> https://dataswamp.org/~incal
>
>
>



^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2021-02-09  2:30 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-02-08 15:02 Separating colour and positioning functioning Christopher Dimech
2021-02-08 21:37 ` Emanuel Berg via Users list for the GNU Emacs text editor
2021-02-09  0:20   ` Christopher Dimech
2021-02-09  0:27   ` Christopher Dimech
2021-02-09  1:01     ` Emanuel Berg via Users list for the GNU Emacs text editor
2021-02-09  2:30       ` Christopher Dimech

Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.