From: "Óscar Fuentes" <ofv@wanadoo.es>
To: emacs-devel@gnu.org
Subject: Re: Patch upstream Git for Elisp diff hunk headings
Date: Thu, 11 Feb 2021 20:15:34 +0100 [thread overview]
Message-ID: <87im6yju09.fsf@telefonica.net> (raw)
In-Reply-To: CAOkDyE_HFTnGz2mcKs7zVzrB3Y2smOyQJfMMV_HtZX_uFOAgKQ@mail.gmail.com
Adam Spiers <emacs-devel@adamspiers.org> writes:
> git_config diff.elisp.xfuncname "^(\\(.*)$"
>
> Indeed this is what Prot initially suggested in his original blog post
> which sparked this discussion:
>
> https://protesilaos.com/codelog/2021-01-26-git-diff-hunk-elisp-org/
>
> While of course no one is claiming that this is technically correct in
> all cases, I don't think I can actually recall ever seeing a single
> instance of a top-level form which *was* indented. So presumably it's
> a good enough heuristic to be helpful in the vast majority of cases.
> Or at least it's more likely to be right than a heuristic which
> assumes that all top-level forms include "def" in the first symbol in
> the form, since the latter obviously fails in many common scenarios
> including the init files one mentioned above.
>
> Would be grateful to hear other views on this.
Indeed, "^(\\(.*)$" is good enough IMHO, and I do not understand the
advantages of the second variant that Prot mentioned on his blog.
next prev parent reply other threads:[~2021-02-11 19:15 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-11 14:42 Patch upstream Git for Elisp diff hunk headings Protesilaos Stavrou
2021-02-11 18:27 ` Adam Spiers
2021-02-11 19:05 ` Stefan Kangas
2021-02-12 17:39 ` Basil L. Contovounesios
2021-02-11 19:13 ` Clément Pit-Claudel
2021-02-11 19:15 ` Óscar Fuentes [this message]
2021-02-11 19:38 ` Stefan Monnier
2021-02-13 19:35 ` Adam Spiers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87im6yju09.fsf@telefonica.net \
--to=ofv@wanadoo.es \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.