sql change: NEWS entry necessary? or no defcustoms at all?

sql change: NEWS entry necessary? or no defcustoms at all?

[Ingo Lohmar]

A week ago, I added (on master, dac694b8bb) the defcustom
`sql-postgres-statement-starters'.  It is a regexp for
sql-product-specific additional statement start commands, analogous to
the existing `sql-oracle-statement-starters'.  It now occurs to me that
my commit may lack a NEWS entry, after all it's a new user option.

The reason I did not add an entry, and that now I am asking for
guidance, is that this "option" should, IMO, ideally be a defvar (or
even defconst), it's *not* really intended for customization, but just
states some knowledge about PostgreSQL.  The reason I still did use a
defcustom was only for the analogy with the Oracle-specific variable.

WDYT?

Re: sql change: NEWS entry necessary? or no defcustoms at all?

[Lars Ingebrigtsen]

Ingo Lohmar <ingo.lohmar@posteo.net> writes:

> The reason I did not add an entry, and that now I am asking for
> guidance, is that this "option" should, IMO, ideally be a defvar (or
> even defconst), it's *not* really intended for customization, but just
> states some knowledge about PostgreSQL.  The reason I still did use a
> defcustom was only for the analogy with the Oracle-specific variable.
>
> WDYT?

Changing it (and the Oracle user option) into defvars sounds OK to me.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Re: sql change: NEWS entry necessary? or no defcustoms at all?

[Eli Zaretskii]

> From: Lars Ingebrigtsen <larsi@gnus.org>
> Date: Wed, 26 May 2021 23:39:45 +0200
> Cc: emacs-devel@gnu.org
> 
> Ingo Lohmar <ingo.lohmar@posteo.net> writes:
> 
> > The reason I did not add an entry, and that now I am asking for
> > guidance, is that this "option" should, IMO, ideally be a defvar (or
> > even defconst), it's *not* really intended for customization, but just
> > states some knowledge about PostgreSQL.  The reason I still did use a
> > defcustom was only for the analogy with the Oracle-specific variable.
> >
> > WDYT?
> 
> Changing it (and the Oracle user option) into defvars sounds OK to me.

No objections from me, either.

Re: sql change: NEWS entry necessary? or no defcustoms at all?

[Ingo Lohmar]

On Thu, May 27 2021 09:48 (+0300), Eli Zaretskii wrote:
>> Changing it (and the Oracle user option) into defvars sounds OK to me.
>
> No objections from me, either.

Thanks for the quick feedback, done in a29a03c3bc.  I also demoted
`sql-ansi-statement-starters' to a defvar (same reasons, and for
consistency).