all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Juri Linkov <juri@linkov.net>
To: Trust me I am a Doctor <pillule@riseup.net>
Cc: 49069@debbugs.gnu.org
Subject: bug#49069: 28.0.50; [PATCH] Use display-buffer for re-builder
Date: Thu, 08 Jul 2021 20:40:39 +0300	[thread overview]
Message-ID: <87im1kya94.fsf@mail.linkov.net> (raw)
In-Reply-To: <87mtqw6cg8.fsf@riseup.net> (Trust me I. am a. Doctor's message of "Thu, 08 Jul 2021 17:18:33 +0200")

tags 49069 fixed
close 49069 28.0.50
thanks

> To be fair, blaming the different repositories gives no evidence that
> this macro is a reaction to perspective.el

Indeed, we don't know for sure, it was just a hypothesis.
But anyway such "catch-all" tricks as ".*" should be avoided.

Also I don't know if there is any chance to fix Org-mode.
Anyway, I'm using such workaround for Org-mode problem:

#+begin_src emacs-lisp
;; Unfortunately, Org window customization has no effect because
;; ‘display-buffer-alist’ is ignored in ‘org-no-popups’
;; until ‘org-switch-to-buffer-other-window’ is overridden below:
(defalias 'org-switch-to-buffer-other-window 'switch-to-buffer-other-window)

;; This allows such user customizations:
(push '("\\`\\*Org \\(Links\\|Select\\)\\*\\'"
        display-buffer-below-selected
        (window-height . fit-window-to-buffer)
        (preserve-size . (nil . t)))
      display-buffer-alist)
#+end_src

> Ok you convinced me. Thanks for the tip, I installed it on a low-vision
> setup of a knowledge of me. We will see more in detail the differences
> that it implies.
>
> So it seems that the patch of the Thu, 17 Jun 2021 16:50:07 +0200
> was indeed the one we want to keep.
>
> I tested it again, with :
>
> (customize-set-variable
>  'display-buffer-base-action
>  '((display-buffer-reuse-window display-buffer-same-window)))
>
> (setf (alist-get "*RE-Builder*" display-buffer-alist nil nil #'string=)
>       `((display-buffer-in-direction)
>         (direction . top)
>         (dedicated . t)))
>
> (re-builder)
>
> And it obeys to display-buffer-alist, be it for an other
> function or others parameters, and keep being functional ... etc.

Thanks for confirming and for implementing the patch.
Now your patch was pushed in commit 57354bc64b.





  reply	other threads:[~2021-07-08 17:40 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-17  1:16 bug#49069: 28.0.50; [PATCH] Use display-buffer for re-builder pillule
2021-06-17  4:10 ` pillule
2021-06-17 14:50   ` pillule
2021-06-29 15:51     ` Trust me I am a Doctor
2021-06-29 20:47       ` Juri Linkov
2021-06-29 21:50         ` Trust me I am a Doctor
2021-06-30 19:49           ` Juri Linkov
2021-07-08 15:18             ` Trust me I am a Doctor
2021-07-08 17:40               ` Juri Linkov [this message]
2021-07-08 21:12                 ` Trust me I am a Doctor
     [not found]                   ` <87bl7c5wgl.fsf@riseup.net>
     [not found]                     ` <7355eaf3-5ae2-46e7-80f5-d3d23ffff7d8@Spark>
2021-07-09  9:00                       ` bug#49069: Fwd: " Trust me I am a Doctor
2021-07-08 18:38               ` Constantine Vetoshev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87im1kya94.fsf@mail.linkov.net \
    --to=juri@linkov.net \
    --cc=49069@debbugs.gnu.org \
    --cc=pillule@riseup.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.